| Differences between
and this patch
- a/Source/WebCore/ChangeLog +90 lines
Lines 1-3 a/Source/WebCore/ChangeLog_sec1
1
2021-02-10  Yusuke Suzuki  <ysuzuki@apple.com>
2
3
        JS Modules in Workers
4
        https://bugs.webkit.org/show_bug.cgi?id=164860
5
6
        Reviewed by NOBODY (OOPS!).
7
8
        * Sources.txt:
9
        * WebCore.xcodeproj/project.pbxproj:
10
        * bindings/js/CachedModuleScriptLoader.cpp:
11
        (WebCore::CachedModuleScriptLoader::create):
12
        (WebCore::CachedModuleScriptLoader::CachedModuleScriptLoader):
13
        (WebCore::CachedModuleScriptLoader::load):
14
        (WebCore::CachedModuleScriptLoader::notifyFinished):
15
        * bindings/js/CachedModuleScriptLoader.h:
16
        * bindings/js/CachedScriptFetcher.cpp:
17
        (WebCore::CachedScriptFetcher::requestScriptWithCache const):
18
        * bindings/js/JSDOMGlobalObject.cpp:
19
        (WebCore::scriptModuleLoader):
20
        (WebCore::JSDOMGlobalObject::moduleLoaderResolve):
21
        (WebCore::JSDOMGlobalObject::moduleLoaderFetch):
22
        (WebCore::JSDOMGlobalObject::moduleLoaderEvaluate):
23
        (WebCore::JSDOMGlobalObject::moduleLoaderImportModule):
24
        (WebCore::JSDOMGlobalObject::moduleLoaderCreateImportMetaProperties):
25
        * bindings/js/JSDOMGlobalObject.h:
26
        * bindings/js/JSDOMWindowBase.cpp:
27
        (WebCore::JSDOMWindowBase::moduleLoaderResolve): Deleted.
28
        (WebCore::JSDOMWindowBase::moduleLoaderFetch): Deleted.
29
        (WebCore::JSDOMWindowBase::moduleLoaderEvaluate): Deleted.
30
        (WebCore::JSDOMWindowBase::moduleLoaderImportModule): Deleted.
31
        (WebCore::JSDOMWindowBase::moduleLoaderCreateImportMetaProperties): Deleted.
32
        * bindings/js/JSDOMWindowBase.h:
33
        * bindings/js/JSWorkerGlobalScopeBase.cpp:
34
        * bindings/js/JSWorkletGlobalScopeBase.cpp:
35
        * bindings/js/ModuleScriptLoader.h: Copied from Source/WebCore/bindings/js/CachedModuleScriptLoader.h.
36
        (WebCore::ModuleScriptLoader::clearClient):
37
        (WebCore::ModuleScriptLoader::ModuleScriptLoader):
38
        * bindings/js/ModuleScriptLoaderClient.h: Renamed from Source/WebCore/bindings/js/CachedModuleScriptLoaderClient.h.
39
        * bindings/js/ScriptModuleLoader.cpp:
40
        (WebCore::ScriptModuleLoader::ScriptModuleLoader):
41
        (WebCore::resolveModuleSpecifier):
42
        (WebCore::ScriptModuleLoader::resolve):
43
        (WebCore::ScriptModuleLoader::fetch):
44
        (WebCore::ScriptModuleLoader::moduleURL):
45
        (WebCore::ScriptModuleLoader::responseURLFromRequestURL):
46
        (WebCore::ScriptModuleLoader::evaluate):
47
        (WebCore::ScriptModuleLoader::importModule):
48
        (WebCore::ScriptModuleLoader::notifyFinished):
49
        * bindings/js/ScriptModuleLoader.h:
50
        * bindings/js/WorkerModuleScriptLoader.cpp: Copied from Source/WebCore/bindings/js/CachedModuleScriptLoader.cpp.
51
        (WebCore::WorkerModuleScriptLoader::create):
52
        (WebCore::WorkerModuleScriptLoader::WorkerModuleScriptLoader):
53
        (WebCore::WorkerModuleScriptLoader::~WorkerModuleScriptLoader):
54
        (WebCore::WorkerModuleScriptLoader::load):
55
        (WebCore::WorkerModuleScriptLoader::notifyFinished):
56
        * bindings/js/WorkerModuleScriptLoader.h: Copied from Source/WebCore/bindings/js/CachedModuleScriptLoader.h.
57
        * dom/Document.cpp:
58
        * dom/LoadableModuleScript.cpp:
59
        (WebCore::LoadableModuleScript::load): Deleted.
60
        * dom/LoadableModuleScript.h:
61
        * dom/ScriptElement.cpp:
62
        (WebCore::ScriptElement::requestModuleScript):
63
        * workers/Worker.cpp:
64
        (WebCore::Worker::Worker):
65
        (WebCore::Worker::create):
66
        (WebCore::Worker::notifyFinished):
67
        * workers/Worker.h:
68
        * workers/Worker.idl:
69
        * workers/WorkerGlobalScope.h:
70
        * workers/WorkerGlobalScopeProxy.h:
71
        * workers/WorkerMessagingProxy.cpp:
72
        (WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
73
        * workers/WorkerMessagingProxy.h:
74
        * workers/WorkerOrWorkletGlobalScope.cpp:
75
        (WebCore::WorkerOrWorkletGlobalScope::WorkerOrWorkletGlobalScope):
76
        * workers/WorkerOrWorkletGlobalScope.h:
77
        (WebCore::WorkerOrWorkletGlobalScope::moduleLoader):
78
        * workers/WorkerOrWorkletScriptController.cpp:
79
        (WebCore::jsValueToModuleKey):
80
        (WebCore::WorkerOrWorkletScriptController::evaluateModule):
81
        (WebCore::WorkerOrWorkletScriptController::loadModuleSynchronously):
82
        (WebCore::WorkerOrWorkletScriptController::linkAndEvaluateModule):
83
        * workers/WorkerOrWorkletScriptController.h:
84
        * workers/WorkerThread.cpp:
85
        (WebCore::WorkerParameters::isolatedCopy const):
86
        (WebCore::WorkerThread::evaluateScriptIfNecessary):
87
        * workers/WorkerThread.h:
88
        * workers/service/context/ServiceWorkerThread.cpp:
89
        (WebCore::ServiceWorkerThread::ServiceWorkerThread):
90
1
2021-02-07  Lauro Moura  <lmoura@igalia.com>
91
2021-02-07  Lauro Moura  <lmoura@igalia.com>
2
92
3
        REGRESSION(r272379) [WPE] imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant tests are Image Failing
93
        REGRESSION(r272379) [WPE] imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant tests are Image Failing
- a/Source/WebCore/Sources.txt +1 lines
Lines 638-643 bindings/js/StructuredClone.cpp a/Source/WebCore/Sources.txt_sec1
638
bindings/js/WebCoreJITOperations.cpp
638
bindings/js/WebCoreJITOperations.cpp
639
bindings/js/WebCoreJSClientData.cpp
639
bindings/js/WebCoreJSClientData.cpp
640
bindings/js/WebCoreTypedArrayController.cpp
640
bindings/js/WebCoreTypedArrayController.cpp
641
bindings/js/WorkerModuleScriptLoader.cpp
641
bindings/js/WindowProxy.cpp
642
bindings/js/WindowProxy.cpp
642
bindings/js/WritableStream.cpp
643
bindings/js/WritableStream.cpp
643
bridge/IdentifierRep.cpp
644
bridge/IdentifierRep.cpp
- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj -4 / +14 lines
Lines 5062-5076 a/Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec1
5062
		E30592641E27A3AD00D57C98 /* InlineClassicScript.h in Headers */ = {isa = PBXBuildFile; fileRef = E30592621E27A38C00D57C98 /* InlineClassicScript.h */; settings = {ATTRIBUTES = (Private, ); }; };
5062
		E30592641E27A3AD00D57C98 /* InlineClassicScript.h in Headers */ = {isa = PBXBuildFile; fileRef = E30592621E27A38C00D57C98 /* InlineClassicScript.h */; settings = {ATTRIBUTES = (Private, ); }; };
5063
		E30592681E27A3D100D57C98 /* CachedScriptFetcher.h in Headers */ = {isa = PBXBuildFile; fileRef = E30592661E27A3C600D57C98 /* CachedScriptFetcher.h */; settings = {ATTRIBUTES = (Private, ); }; };
5063
		E30592681E27A3D100D57C98 /* CachedScriptFetcher.h in Headers */ = {isa = PBXBuildFile; fileRef = E30592661E27A3C600D57C98 /* CachedScriptFetcher.h */; settings = {ATTRIBUTES = (Private, ); }; };
5064
		E307DED01D81E4C700141CAF /* CachedModuleScriptLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = E307DEC71D81E44800141CAF /* CachedModuleScriptLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
5064
		E307DED01D81E4C700141CAF /* CachedModuleScriptLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = E307DEC71D81E44800141CAF /* CachedModuleScriptLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
5065
		E307DED11D81E4CB00141CAF /* CachedModuleScriptLoaderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = E307DEC81D81E44800141CAF /* CachedModuleScriptLoaderClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
5066
		E307DED51D81E4F200141CAF /* LoadableModuleScript.h in Headers */ = {isa = PBXBuildFile; fileRef = E307DED31D81E4ED00141CAF /* LoadableModuleScript.h */; settings = {ATTRIBUTES = (Private, ); }; };
5065
		E307DED51D81E4F200141CAF /* LoadableModuleScript.h in Headers */ = {isa = PBXBuildFile; fileRef = E307DED31D81E4ED00141CAF /* LoadableModuleScript.h */; settings = {ATTRIBUTES = (Private, ); }; };
5067
		E3150EA71DA7219300194012 /* DOMJITHelpers.h in Headers */ = {isa = PBXBuildFile; fileRef = E3150EA51DA7218D00194012 /* DOMJITHelpers.h */; };
5066
		E3150EA71DA7219300194012 /* DOMJITHelpers.h in Headers */ = {isa = PBXBuildFile; fileRef = E3150EA51DA7218D00194012 /* DOMJITHelpers.h */; };
5068
		E3201C1A1F8E82130076A032 /* ModuleFetchParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = E38D06091F8E811900649CF2 /* ModuleFetchParameters.h */; settings = {ATTRIBUTES = (Private, ); }; };
5067
		E3201C1A1F8E82130076A032 /* ModuleFetchParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = E38D06091F8E811900649CF2 /* ModuleFetchParameters.h */; settings = {ATTRIBUTES = (Private, ); }; };
5069
		E323CFFA1E5AF6AF00F0B4A0 /* JSDOMConvertPromise.h in Headers */ = {isa = PBXBuildFile; fileRef = E323CFF91E5AF6A500F0B4A0 /* JSDOMConvertPromise.h */; settings = {ATTRIBUTES = (Private, ); }; };
5068
		E323CFFA1E5AF6AF00F0B4A0 /* JSDOMConvertPromise.h in Headers */ = {isa = PBXBuildFile; fileRef = E323CFF91E5AF6A500F0B4A0 /* JSDOMConvertPromise.h */; settings = {ATTRIBUTES = (Private, ); }; };
5069
		E3432DE425D377E30058E612 /* WorkerModuleScriptLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = E3432DE025D377E20058E612 /* WorkerModuleScriptLoader.h */; };
5070
		E35188B425D387CF00A77AF3 /* ModuleScriptLoaderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = E35188B325D387CF00A77AF3 /* ModuleScriptLoaderClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
5070
		E3565B7B1DC2D6C900217DBD /* JSEventCustom.h in Headers */ = {isa = PBXBuildFile; fileRef = E34EE49F1DC2D57500EAA9D3 /* JSEventCustom.h */; settings = {ATTRIBUTES = (Private, ); }; };
5071
		E3565B7B1DC2D6C900217DBD /* JSEventCustom.h in Headers */ = {isa = PBXBuildFile; fileRef = E34EE49F1DC2D57500EAA9D3 /* JSEventCustom.h */; settings = {ATTRIBUTES = (Private, ); }; };
5071
		E35802B61DC8435D00A9773C /* DOMJITIDLTypeFilter.h in Headers */ = {isa = PBXBuildFile; fileRef = E35802B51DC8435800A9773C /* DOMJITIDLTypeFilter.h */; settings = {ATTRIBUTES = (Private, ); }; };
5072
		E35802B61DC8435D00A9773C /* DOMJITIDLTypeFilter.h in Headers */ = {isa = PBXBuildFile; fileRef = E35802B51DC8435800A9773C /* DOMJITIDLTypeFilter.h */; settings = {ATTRIBUTES = (Private, ); }; };
5072
		E3582C282527F66900D1B790 /* WebCoreJITOperations.h in Headers */ = {isa = PBXBuildFile; fileRef = E3582C262527F66800D1B790 /* WebCoreJITOperations.h */; settings = {ATTRIBUTES = (Private, ); }; };
5073
		E3582C282527F66900D1B790 /* WebCoreJITOperations.h in Headers */ = {isa = PBXBuildFile; fileRef = E3582C262527F66800D1B790 /* WebCoreJITOperations.h */; settings = {ATTRIBUTES = (Private, ); }; };
5073
		E35B907F23F60A50000011FF /* LocalizedDeviceModel.h in Headers */ = {isa = PBXBuildFile; fileRef = E35B907C23F60677000011FF /* LocalizedDeviceModel.h */; settings = {ATTRIBUTES = (Private, ); }; };
5074
		E35B907F23F60A50000011FF /* LocalizedDeviceModel.h in Headers */ = {isa = PBXBuildFile; fileRef = E35B907C23F60677000011FF /* LocalizedDeviceModel.h */; settings = {ATTRIBUTES = (Private, ); }; };
5075
		E364321C25D37A6700F90E2A /* ModuleScriptLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = E364321A25D37A6600F90E2A /* ModuleScriptLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
5074
		E377FE4D1DADE16500CDD025 /* NodeConstants.h in Headers */ = {isa = PBXBuildFile; fileRef = E3D049931DADC04500718F3C /* NodeConstants.h */; settings = {ATTRIBUTES = (Private, ); }; };
5076
		E377FE4D1DADE16500CDD025 /* NodeConstants.h in Headers */ = {isa = PBXBuildFile; fileRef = E3D049931DADC04500718F3C /* NodeConstants.h */; settings = {ATTRIBUTES = (Private, ); }; };
5075
		E37C86501EB63E3F0087C6CA /* JSDOMPromise.h in Headers */ = {isa = PBXBuildFile; fileRef = E37C864F1EB63E2D0087C6CA /* JSDOMPromise.h */; settings = {ATTRIBUTES = (Private, ); }; };
5077
		E37C86501EB63E3F0087C6CA /* JSDOMPromise.h in Headers */ = {isa = PBXBuildFile; fileRef = E37C864F1EB63E2D0087C6CA /* JSDOMPromise.h */; settings = {ATTRIBUTES = (Private, ); }; };
5076
		E39628BF2395728F00658ECD /* DeviceOrientationUpdateProvider.h in Headers */ = {isa = PBXBuildFile; fileRef = E39628BD2395728E00658ECD /* DeviceOrientationUpdateProvider.h */; settings = {ATTRIBUTES = (Private, ); }; };
5078
		E39628BF2395728F00658ECD /* DeviceOrientationUpdateProvider.h in Headers */ = {isa = PBXBuildFile; fileRef = E39628BD2395728E00658ECD /* DeviceOrientationUpdateProvider.h */; settings = {ATTRIBUTES = (Private, ); }; };
Lines 16177-16183 a/Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec2
16177
		E30592661E27A3C600D57C98 /* CachedScriptFetcher.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CachedScriptFetcher.h; sourceTree = "<group>"; };
16179
		E30592661E27A3C600D57C98 /* CachedScriptFetcher.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CachedScriptFetcher.h; sourceTree = "<group>"; };
16178
		E307DEC61D81E44800141CAF /* CachedModuleScriptLoader.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CachedModuleScriptLoader.cpp; sourceTree = "<group>"; };
16180
		E307DEC61D81E44800141CAF /* CachedModuleScriptLoader.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CachedModuleScriptLoader.cpp; sourceTree = "<group>"; };
16179
		E307DEC71D81E44800141CAF /* CachedModuleScriptLoader.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CachedModuleScriptLoader.h; sourceTree = "<group>"; };
16181
		E307DEC71D81E44800141CAF /* CachedModuleScriptLoader.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CachedModuleScriptLoader.h; sourceTree = "<group>"; };
16180
		E307DEC81D81E44800141CAF /* CachedModuleScriptLoaderClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CachedModuleScriptLoaderClient.h; sourceTree = "<group>"; };
16181
		E307DED21D81E4ED00141CAF /* LoadableModuleScript.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LoadableModuleScript.cpp; sourceTree = "<group>"; };
16182
		E307DED21D81E4ED00141CAF /* LoadableModuleScript.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LoadableModuleScript.cpp; sourceTree = "<group>"; };
16182
		E307DED31D81E4ED00141CAF /* LoadableModuleScript.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = LoadableModuleScript.h; sourceTree = "<group>"; };
16183
		E307DED31D81E4ED00141CAF /* LoadableModuleScript.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = LoadableModuleScript.h; sourceTree = "<group>"; };
16183
		E3150EA51DA7218D00194012 /* DOMJITHelpers.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMJITHelpers.h; sourceTree = "<group>"; };
16184
		E3150EA51DA7218D00194012 /* DOMJITHelpers.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMJITHelpers.h; sourceTree = "<group>"; };
Lines 16190-16201 a/Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec3
16190
		E329276322543F5900308A9A /* TypedOMCSSUnitValue.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = TypedOMCSSUnitValue.cpp; sourceTree = "<group>"; };
16191
		E329276322543F5900308A9A /* TypedOMCSSUnitValue.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = TypedOMCSSUnitValue.cpp; sourceTree = "<group>"; };
16191
		E329276622543FDE00308A9A /* DOMRectReadOnly.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = DOMRectReadOnly.cpp; sourceTree = "<group>"; };
16192
		E329276622543FDE00308A9A /* DOMRectReadOnly.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = DOMRectReadOnly.cpp; sourceTree = "<group>"; };
16192
		E334825E1DC93AA0009C9544 /* DOMJITAbstractHeapRepository.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DOMJITAbstractHeapRepository.h; path = DerivedSources/WebCore/DOMJITAbstractHeapRepository.h; sourceTree = BUILT_PRODUCTS_DIR; };
16193
		E334825E1DC93AA0009C9544 /* DOMJITAbstractHeapRepository.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DOMJITAbstractHeapRepository.h; path = DerivedSources/WebCore/DOMJITAbstractHeapRepository.h; sourceTree = BUILT_PRODUCTS_DIR; };
16194
		E3432DE025D377E20058E612 /* WorkerModuleScriptLoader.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WorkerModuleScriptLoader.h; sourceTree = "<group>"; };
16195
		E3432DE325D377E30058E612 /* WorkerModuleScriptLoader.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WorkerModuleScriptLoader.cpp; sourceTree = "<group>"; };
16193
		E34EE49F1DC2D57500EAA9D3 /* JSEventCustom.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSEventCustom.h; sourceTree = "<group>"; };
16196
		E34EE49F1DC2D57500EAA9D3 /* JSEventCustom.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSEventCustom.h; sourceTree = "<group>"; };
16197
		E35188B325D387CF00A77AF3 /* ModuleScriptLoaderClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ModuleScriptLoaderClient.h; sourceTree = "<group>"; };
16194
		E35802B51DC8435800A9773C /* DOMJITIDLTypeFilter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMJITIDLTypeFilter.h; sourceTree = "<group>"; };
16198
		E35802B51DC8435800A9773C /* DOMJITIDLTypeFilter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMJITIDLTypeFilter.h; sourceTree = "<group>"; };
16195
		E3582C242527F66800D1B790 /* WebCoreJITOperations.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebCoreJITOperations.cpp; sourceTree = "<group>"; };
16199
		E3582C242527F66800D1B790 /* WebCoreJITOperations.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebCoreJITOperations.cpp; sourceTree = "<group>"; };
16196
		E3582C262527F66800D1B790 /* WebCoreJITOperations.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreJITOperations.h; sourceTree = "<group>"; };
16200
		E3582C262527F66800D1B790 /* WebCoreJITOperations.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreJITOperations.h; sourceTree = "<group>"; };
16197
		E35B907C23F60677000011FF /* LocalizedDeviceModel.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = LocalizedDeviceModel.h; sourceTree = "<group>"; };
16201
		E35B907C23F60677000011FF /* LocalizedDeviceModel.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = LocalizedDeviceModel.h; sourceTree = "<group>"; };
16198
		E35B907E23F60677000011FF /* LocalizedDeviceModel.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = LocalizedDeviceModel.mm; sourceTree = "<group>"; };
16202
		E35B907E23F60677000011FF /* LocalizedDeviceModel.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = LocalizedDeviceModel.mm; sourceTree = "<group>"; };
16203
		E364321A25D37A6600F90E2A /* ModuleScriptLoader.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ModuleScriptLoader.h; sourceTree = "<group>"; };
16199
		E37C864F1EB63E2D0087C6CA /* JSDOMPromise.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSDOMPromise.h; sourceTree = "<group>"; };
16204
		E37C864F1EB63E2D0087C6CA /* JSDOMPromise.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSDOMPromise.h; sourceTree = "<group>"; };
16200
		E38838941BAD145F00D62EE3 /* ScriptModuleLoader.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ScriptModuleLoader.cpp; sourceTree = "<group>"; };
16205
		E38838941BAD145F00D62EE3 /* ScriptModuleLoader.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ScriptModuleLoader.cpp; sourceTree = "<group>"; };
16201
		E38838951BAD145F00D62EE3 /* ScriptModuleLoader.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ScriptModuleLoader.h; sourceTree = "<group>"; };
16206
		E38838951BAD145F00D62EE3 /* ScriptModuleLoader.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ScriptModuleLoader.h; sourceTree = "<group>"; };
Lines 26987-26993 a/Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec4
26987
				2DFA488E1DB541C200362B99 /* BufferSource.h */,
26992
				2DFA488E1DB541C200362B99 /* BufferSource.h */,
26988
				E307DEC61D81E44800141CAF /* CachedModuleScriptLoader.cpp */,
26993
				E307DEC61D81E44800141CAF /* CachedModuleScriptLoader.cpp */,
26989
				E307DEC71D81E44800141CAF /* CachedModuleScriptLoader.h */,
26994
				E307DEC71D81E44800141CAF /* CachedModuleScriptLoader.h */,
26990
				E307DEC81D81E44800141CAF /* CachedModuleScriptLoaderClient.h */,
26991
				E30592651E27A3C600D57C98 /* CachedScriptFetcher.cpp */,
26995
				E30592651E27A3C600D57C98 /* CachedScriptFetcher.cpp */,
26992
				E30592661E27A3C600D57C98 /* CachedScriptFetcher.h */,
26996
				E30592661E27A3C600D57C98 /* CachedScriptFetcher.h */,
26993
				BCD533630ED6848900887468 /* CachedScriptSourceProvider.h */,
26997
				BCD533630ED6848900887468 /* CachedScriptSourceProvider.h */,
Lines 27061-27066 a/Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec5
27061
				4BDEA32D218034050052DFCD /* JSWorkletGlobalScopeBase.cpp */,
27065
				4BDEA32D218034050052DFCD /* JSWorkletGlobalScopeBase.cpp */,
27062
				4BDEA32B218033EB0052DFCD /* JSWorkletGlobalScopeBase.h */,
27066
				4BDEA32B218033EB0052DFCD /* JSWorkletGlobalScopeBase.h */,
27063
				709A01FD1E3D0BCC006B0D4C /* ModuleFetchFailureKind.h */,
27067
				709A01FD1E3D0BCC006B0D4C /* ModuleFetchFailureKind.h */,
27068
				E364321A25D37A6600F90E2A /* ModuleScriptLoader.h */,
27069
				E35188B325D387CF00A77AF3 /* ModuleScriptLoaderClient.h */,
27064
				41B459ED1F55EBC70000F6FD /* ReadableStream.cpp */,
27070
				41B459ED1F55EBC70000F6FD /* ReadableStream.cpp */,
27065
				41B459DA1F4CADB90000F6FD /* ReadableStream.h */,
27071
				41B459DA1F4CADB90000F6FD /* ReadableStream.h */,
27066
				418C395E1C8F0AAB0051C8A3 /* ReadableStreamDefaultController.cpp */,
27072
				418C395E1C8F0AAB0051C8A3 /* ReadableStreamDefaultController.cpp */,
Lines 27092-27097 a/Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec6
27092
				0F099D0717B968A100FF84B9 /* WebCoreTypedArrayController.h */,
27098
				0F099D0717B968A100FF84B9 /* WebCoreTypedArrayController.h */,
27093
				463521AC2081090E00C28922 /* WindowProxy.cpp */,
27099
				463521AC2081090E00C28922 /* WindowProxy.cpp */,
27094
				463521AA2081090B00C28922 /* WindowProxy.h */,
27100
				463521AA2081090B00C28922 /* WindowProxy.h */,
27101
				E3432DE325D377E30058E612 /* WorkerModuleScriptLoader.cpp */,
27102
				E3432DE025D377E20058E612 /* WorkerModuleScriptLoader.h */,
27095
				41418A0325643E1200363417 /* WritableStream.cpp */,
27103
				41418A0325643E1200363417 /* WritableStream.cpp */,
27096
				41418A0425643E1300363417 /* WritableStream.h */,
27104
				41418A0425643E1300363417 /* WritableStream.h */,
27097
			);
27105
			);
Lines 31357-31363 a/Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec7
31357
				BCB16C1C0979C3BD00467741 /* CachedImage.h in Headers */,
31365
				BCB16C1C0979C3BD00467741 /* CachedImage.h in Headers */,
31358
				319FBD5F15D2F464009640A6 /* CachedImageClient.h in Headers */,
31366
				319FBD5F15D2F464009640A6 /* CachedImageClient.h in Headers */,
31359
				E307DED01D81E4C700141CAF /* CachedModuleScriptLoader.h in Headers */,
31367
				E307DED01D81E4C700141CAF /* CachedModuleScriptLoader.h in Headers */,
31360
				E307DED11D81E4CB00141CAF /* CachedModuleScriptLoaderClient.h in Headers */,
31361
				510184690B08602A004A825F /* CachedPage.h in Headers */,
31368
				510184690B08602A004A825F /* CachedPage.h in Headers */,
31362
				D0EDA775143E303C0028E383 /* CachedRawResource.h in Headers */,
31369
				D0EDA775143E303C0028E383 /* CachedRawResource.h in Headers */,
31363
				E1B533491717DEE300F205F9 /* CachedRawResourceClient.h in Headers */,
31370
				E1B533491717DEE300F205F9 /* CachedRawResourceClient.h in Headers */,
Lines 33827-33832 a/Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec8
33827
				C6D74AD509AA282E000B0A52 /* ModifySelectionListLevel.h in Headers */,
33834
				C6D74AD509AA282E000B0A52 /* ModifySelectionListLevel.h in Headers */,
33828
				709A01FE1E3D0BDD006B0D4C /* ModuleFetchFailureKind.h in Headers */,
33835
				709A01FE1E3D0BDD006B0D4C /* ModuleFetchFailureKind.h in Headers */,
33829
				E3201C1A1F8E82130076A032 /* ModuleFetchParameters.h in Headers */,
33836
				E3201C1A1F8E82130076A032 /* ModuleFetchParameters.h in Headers */,
33837
				E364321C25D37A6700F90E2A /* ModuleScriptLoader.h in Headers */,
33838
				E35188B425D387CF00A77AF3 /* ModuleScriptLoaderClient.h in Headers */,
33830
				F55B3DC61251F12D003EF269 /* MonthInputType.h in Headers */,
33839
				F55B3DC61251F12D003EF269 /* MonthInputType.h in Headers */,
33831
				E39628C12395743100658ECD /* MotionManagerClient.h in Headers */,
33840
				E39628C12395743100658ECD /* MotionManagerClient.h in Headers */,
33832
				85031B460A44EFC700F992E0 /* MouseEvent.h in Headers */,
33841
				85031B460A44EFC700F992E0 /* MouseEvent.h in Headers */,
Lines 35476-35481 a/Source/WebCore/WebCore.xcodeproj/project.pbxproj_sec9
35476
				18F831B80FD48C7800D8C56B /* WorkerLoaderProxy.h in Headers */,
35485
				18F831B80FD48C7800D8C56B /* WorkerLoaderProxy.h in Headers */,
35477
				2E43464D0F546A8200B0F1BA /* WorkerLocation.h in Headers */,
35486
				2E43464D0F546A8200B0F1BA /* WorkerLocation.h in Headers */,
35478
				2E4346500F546A8200B0F1BA /* WorkerMessagingProxy.h in Headers */,
35487
				2E4346500F546A8200B0F1BA /* WorkerMessagingProxy.h in Headers */,
35488
				E3432DE425D377E30058E612 /* WorkerModuleScriptLoader.h in Headers */,
35479
				E1271A0B0EEEC77A00F61213 /* WorkerNavigator.h in Headers */,
35489
				E1271A0B0EEEC77A00F61213 /* WorkerNavigator.h in Headers */,
35480
				A5CB05251FB51F3A00089B97 /* WorkerNetworkAgent.h in Headers */,
35490
				A5CB05251FB51F3A00089B97 /* WorkerNetworkAgent.h in Headers */,
35481
				2E4346510F546A8200B0F1BA /* WorkerObjectProxy.h in Headers */,
35491
				2E4346510F546A8200B0F1BA /* WorkerObjectProxy.h in Headers */,
- a/Source/WebCore/bindings/js/CachedModuleScriptLoader.cpp -6 / +6 lines
Lines 40-52 a/Source/WebCore/bindings/js/CachedModuleScriptLoader.cpp_sec1
40
40
41
namespace WebCore {
41
namespace WebCore {
42
42
43
Ref<CachedModuleScriptLoader> CachedModuleScriptLoader::create(CachedModuleScriptLoaderClient& client, DeferredPromise& promise, CachedScriptFetcher& scriptFetcher, RefPtr<ModuleFetchParameters>&& parameters)
43
Ref<CachedModuleScriptLoader> CachedModuleScriptLoader::create(ModuleScriptLoaderClient& client, DeferredPromise& promise, CachedScriptFetcher& scriptFetcher, RefPtr<ModuleFetchParameters>&& parameters)
44
{
44
{
45
    return adoptRef(*new CachedModuleScriptLoader(client, promise, scriptFetcher, WTFMove(parameters)));
45
    return adoptRef(*new CachedModuleScriptLoader(client, promise, scriptFetcher, WTFMove(parameters)));
46
}
46
}
47
47
48
CachedModuleScriptLoader::CachedModuleScriptLoader(CachedModuleScriptLoaderClient& client, DeferredPromise& promise, CachedScriptFetcher& scriptFetcher, RefPtr<ModuleFetchParameters>&& parameters)
48
CachedModuleScriptLoader::CachedModuleScriptLoader(ModuleScriptLoaderClient& client, DeferredPromise& promise, CachedScriptFetcher& scriptFetcher, RefPtr<ModuleFetchParameters>&& parameters)
49
    : m_client(&client)
49
    : ModuleScriptLoader(client)
50
    , m_promise(&promise)
50
    , m_promise(&promise)
51
    , m_scriptFetcher(scriptFetcher)
51
    , m_scriptFetcher(scriptFetcher)
52
    , m_parameters(WTFMove(parameters))
52
    , m_parameters(WTFMove(parameters))
Lines 61-74 CachedModuleScriptLoader::~CachedModuleScriptLoader() a/Source/WebCore/bindings/js/CachedModuleScriptLoader.cpp_sec2
61
    }
61
    }
62
}
62
}
63
63
64
bool CachedModuleScriptLoader::load(Document& document, const URL& sourceURL)
64
bool CachedModuleScriptLoader::load(Document& document, URL&& sourceURL)
65
{
65
{
66
    ASSERT(!m_cachedScript);
66
    ASSERT(!m_cachedScript);
67
    String integrity = m_parameters ? m_parameters->integrity() : String { };
67
    String integrity = m_parameters ? m_parameters->integrity() : String { };
68
    m_cachedScript = m_scriptFetcher->requestModuleScript(document, sourceURL, WTFMove(integrity));
68
    m_cachedScript = m_scriptFetcher->requestModuleScript(document, sourceURL, WTFMove(integrity));
69
    if (!m_cachedScript)
69
    if (!m_cachedScript)
70
        return false;
70
        return false;
71
    m_sourceURL = sourceURL;
71
    m_sourceURL = WTFMove(sourceURL);
72
72
73
    // If the content is already cached, this immediately calls notifyFinished.
73
    // If the content is already cached, this immediately calls notifyFinished.
74
    m_cachedScript->addClient(*this);
74
    m_cachedScript->addClient(*this);
Lines 83-89 void CachedModuleScriptLoader::notifyFinished(CachedResource& resource, const Ne a/Source/WebCore/bindings/js/CachedModuleScriptLoader.cpp_sec3
83
83
84
    Ref<CachedModuleScriptLoader> protectedThis(*this);
84
    Ref<CachedModuleScriptLoader> protectedThis(*this);
85
    if (m_client)
85
    if (m_client)
86
        m_client->notifyFinished(*this, WTFMove(m_promise));
86
        m_client->notifyFinished(*this, WTFMove(m_sourceURL), m_promise.releaseNonNull());
87
87
88
    // Remove the client after calling notifyFinished to keep the data buffer in
88
    // Remove the client after calling notifyFinished to keep the data buffer in
89
    // CachedResource alive while notifyFinished processes the resource.
89
    // CachedResource alive while notifyFinished processes the resource.
- a/Source/WebCore/bindings/js/CachedModuleScriptLoader.h -13 / +6 lines
Lines 27-32 a/Source/WebCore/bindings/js/CachedModuleScriptLoader.h_sec1
27
27
28
#include "CachedResourceClient.h"
28
#include "CachedResourceClient.h"
29
#include "CachedResourceHandle.h"
29
#include "CachedResourceHandle.h"
30
#include "ModuleScriptLoader.h"
30
#include <wtf/Ref.h>
31
#include <wtf/Ref.h>
31
#include <wtf/RefCounted.h>
32
#include <wtf/RefCounted.h>
32
#include <wtf/RefPtr.h>
33
#include <wtf/RefPtr.h>
Lines 34-40 a/Source/WebCore/bindings/js/CachedModuleScriptLoader.h_sec2
34
35
35
namespace WebCore {
36
namespace WebCore {
36
37
37
class CachedModuleScriptLoaderClient;
38
class ModuleScriptLoaderClient;
38
class CachedScript;
39
class CachedScript;
39
class CachedScriptFetcher;
40
class CachedScriptFetcher;
40
class DeferredPromise;
41
class DeferredPromise;
Lines 42-72 class Document; a/Source/WebCore/bindings/js/CachedModuleScriptLoader.h_sec3
42
class JSDOMGlobalObject;
43
class JSDOMGlobalObject;
43
class ModuleFetchParameters;
44
class ModuleFetchParameters;
44
45
45
class CachedModuleScriptLoader final : public RefCounted<CachedModuleScriptLoader>, private CachedResourceClient {
46
class CachedModuleScriptLoader final : public ModuleScriptLoader, private CachedResourceClient {
46
public:
47
public:
47
    static Ref<CachedModuleScriptLoader> create(CachedModuleScriptLoaderClient&, DeferredPromise&, CachedScriptFetcher&, RefPtr<ModuleFetchParameters>&&);
48
    static Ref<CachedModuleScriptLoader> create(ModuleScriptLoaderClient&, DeferredPromise&, CachedScriptFetcher&, RefPtr<ModuleFetchParameters>&&);
48
49
49
    virtual ~CachedModuleScriptLoader();
50
    virtual ~CachedModuleScriptLoader();
50
51
51
    bool load(Document&, const URL& sourceURL);
52
    bool load(Document&, URL&& sourceURL);
52
53
53
    CachedScriptFetcher& scriptFetcher() { return m_scriptFetcher.get(); }
54
    CachedScriptFetcher& scriptFetcher() { return m_scriptFetcher.get(); }
54
    CachedScript* cachedScript() { return m_cachedScript.get(); }
55
    CachedScript* cachedScript() { return m_cachedScript.get(); }
55
    ModuleFetchParameters* parameters() { return m_parameters.get(); }
56
    ModuleFetchParameters* parameters() { return m_parameters.get(); }
56
    const URL& sourceURL() const { return m_sourceURL; }
57
58
    void clearClient()
59
    {
60
        ASSERT(m_client);
61
        m_client = nullptr;
62
    }
63
57
64
private:
58
private:
65
    CachedModuleScriptLoader(CachedModuleScriptLoaderClient&, DeferredPromise&, CachedScriptFetcher&, RefPtr<ModuleFetchParameters>&&);
59
    CachedModuleScriptLoader(ModuleScriptLoaderClient&, DeferredPromise&, CachedScriptFetcher&, RefPtr<ModuleFetchParameters>&&);
66
60
67
    void notifyFinished(CachedResource&, const NetworkLoadMetrics&) final;
61
    void notifyFinished(CachedResource&, const NetworkLoadMetrics&) final;
68
62
69
    CachedModuleScriptLoaderClient* m_client { nullptr };
70
    RefPtr<DeferredPromise> m_promise;
63
    RefPtr<DeferredPromise> m_promise;
71
    Ref<CachedScriptFetcher> m_scriptFetcher;
64
    Ref<CachedScriptFetcher> m_scriptFetcher;
72
    RefPtr<ModuleFetchParameters> m_parameters;
65
    RefPtr<ModuleFetchParameters> m_parameters;
- a/Source/WebCore/bindings/js/CachedModuleScriptLoaderClient.h -40 lines
Lines 1-40 a/Source/WebCore/bindings/js/CachedModuleScriptLoaderClient.h_sec1
1
/*
2
 * Copyright (C) 2016 Apple, Inc. All Rights Reserved.
3
 *
4
 * Redistribution and use in source and binary forms, with or without
5
 * modification, are permitted provided that the following conditions
6
 * are met:
7
 * 1. Redistributions of source code must retain the above copyright
8
 *    notice, this list of conditions and the following disclaimer.
9
 * 2. Redistributions in binary form must reproduce the above copyright
10
 *    notice, this list of conditions and the following disclaimer in the
11
 *    documentation and/or other materials provided with the distribution.
12
 *
13
 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14
 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16
 * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
17
 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18
 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19
 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20
 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21
 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24
 */
25
26
#pragma once
27
28
namespace WebCore {
29
30
class CachedModuleScriptLoader;
31
class DeferredPromise;
32
33
class CachedModuleScriptLoaderClient {
34
public:
35
    virtual ~CachedModuleScriptLoaderClient() = default;
36
37
    virtual void notifyFinished(CachedModuleScriptLoader&, RefPtr<DeferredPromise>) = 0;
38
};
39
40
}
- a/Source/WebCore/bindings/js/CachedScriptFetcher.cpp +2 lines
Lines 32-37 a/Source/WebCore/bindings/js/CachedScriptFetcher.cpp_sec1
32
#include "CrossOriginAccessControl.h"
32
#include "CrossOriginAccessControl.h"
33
#include "Document.h"
33
#include "Document.h"
34
#include "Settings.h"
34
#include "Settings.h"
35
#include "WorkerOrWorkletGlobalScope.h"
35
36
36
namespace WebCore {
37
namespace WebCore {
37
38
Lines 47-52 CachedResourceHandle<CachedScript> CachedScriptFetcher::requestModuleScript(Docu a/Source/WebCore/bindings/js/CachedScriptFetcher.cpp_sec2
47
48
48
CachedResourceHandle<CachedScript> CachedScriptFetcher::requestScriptWithCache(Document& document, const URL& sourceURL, const String& crossOriginMode, String&& integrity, Optional<ResourceLoadPriority> resourceLoadPriority) const
49
CachedResourceHandle<CachedScript> CachedScriptFetcher::requestScriptWithCache(Document& document, const URL& sourceURL, const String& crossOriginMode, String&& integrity, Optional<ResourceLoadPriority> resourceLoadPriority) const
49
{
50
{
51
    // Without scripting, there is no way to start Workers.
50
    if (!document.settings().isScriptEnabled())
52
    if (!document.settings().isScriptEnabled())
51
        return nullptr;
53
        return nullptr;
52
54
- a/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp +74 lines
Lines 47-52 a/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp_sec1
47
#include "JSWorkletGlobalScope.h"
47
#include "JSWorkletGlobalScope.h"
48
#include "RejectedPromiseTracker.h"
48
#include "RejectedPromiseTracker.h"
49
#include "RuntimeEnabledFeatures.h"
49
#include "RuntimeEnabledFeatures.h"
50
#include "ScriptModuleLoader.h"
50
#include "StructuredClone.h"
51
#include "StructuredClone.h"
51
#include "WebCoreJSClientData.h"
52
#include "WebCoreJSClientData.h"
52
#include "WorkerGlobalScope.h"
53
#include "WorkerGlobalScope.h"
Lines 422-427 JSC::JSPromise* JSDOMGlobalObject::instantiateStreaming(JSC::JSGlobalObject* glo a/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp_sec2
422
}
423
}
423
#endif
424
#endif
424
425
426
static ScriptModuleLoader* scriptModuleLoader(JSDOMGlobalObject* globalObject)
427
{
428
    VM& vm = globalObject->vm();
429
    if (globalObject->inherits<JSDOMWindowBase>(vm)) {
430
        if (auto document = jsCast<const JSDOMWindowBase*>(globalObject)->wrapped().document())
431
            return &document->moduleLoader();
432
        return nullptr;
433
    }
434
    if (globalObject->inherits<JSRemoteDOMWindowBase>(vm))
435
        return nullptr;
436
    if (globalObject->inherits<JSWorkerGlobalScopeBase>(vm))
437
        return &jsCast<const JSWorkerGlobalScopeBase*>(globalObject)->wrapped().moduleLoader();
438
    if (globalObject->inherits<JSWorkletGlobalScopeBase>(vm))
439
        return &jsCast<const JSWorkletGlobalScopeBase*>(globalObject)->wrapped().moduleLoader();
440
#if ENABLE(INDEXED_DATABASE)
441
    if (globalObject->inherits<JSIDBSerializationGlobalObject>(vm))
442
        return nullptr;
443
#endif
444
    dataLog("Unexpected global object: ", JSValue(globalObject), "\n");
445
    RELEASE_ASSERT_NOT_REACHED();
446
    return nullptr;
447
}
448
449
JSC::Identifier JSDOMGlobalObject::moduleLoaderResolve(JSC::JSGlobalObject* globalObject, JSC::JSModuleLoader* moduleLoader, JSC::JSValue moduleName, JSC::JSValue importerModuleKey, JSC::JSValue scriptFetcher)
450
{
451
    JSDOMGlobalObject* thisObject = JSC::jsCast<JSDOMGlobalObject*>(globalObject);
452
    if (auto* loader = scriptModuleLoader(thisObject))
453
        return loader->resolve(globalObject, moduleLoader, moduleName, importerModuleKey, scriptFetcher);
454
    return { };
455
}
456
457
JSC::JSInternalPromise* JSDOMGlobalObject::moduleLoaderFetch(JSC::JSGlobalObject* globalObject, JSC::JSModuleLoader* moduleLoader, JSC::JSValue moduleKey, JSC::JSValue parameters, JSC::JSValue scriptFetcher)
458
{
459
    VM& vm = globalObject->vm();
460
    auto scope = DECLARE_THROW_SCOPE(vm);
461
    JSDOMGlobalObject* thisObject = JSC::jsCast<JSDOMGlobalObject*>(globalObject);
462
    if (auto* loader = scriptModuleLoader(thisObject))
463
        RELEASE_AND_RETURN(scope, loader->fetch(globalObject, moduleLoader, moduleKey, parameters, scriptFetcher));
464
    JSC::JSInternalPromise* promise = JSC::JSInternalPromise::create(vm, globalObject->internalPromiseStructure());
465
    scope.release();
466
    promise->reject(globalObject, jsUndefined());
467
    return promise;
468
}
469
470
JSC::JSValue JSDOMGlobalObject::moduleLoaderEvaluate(JSC::JSGlobalObject* globalObject, JSC::JSModuleLoader* moduleLoader, JSC::JSValue moduleKey, JSC::JSValue moduleRecord, JSC::JSValue scriptFetcher)
471
{
472
    JSDOMGlobalObject* thisObject = JSC::jsCast<JSDOMGlobalObject*>(globalObject);
473
    if (auto* loader = scriptModuleLoader(thisObject))
474
        return loader->evaluate(globalObject, moduleLoader, moduleKey, moduleRecord, scriptFetcher);
475
    return JSC::jsUndefined();
476
}
477
478
JSC::JSInternalPromise* JSDOMGlobalObject::moduleLoaderImportModule(JSC::JSGlobalObject* globalObject, JSC::JSModuleLoader* moduleLoader, JSC::JSString* moduleName, JSC::JSValue parameters, const JSC::SourceOrigin& sourceOrigin)
479
{
480
    VM& vm = globalObject->vm();
481
    auto scope = DECLARE_THROW_SCOPE(vm);
482
    JSDOMGlobalObject* thisObject = JSC::jsCast<JSDOMGlobalObject*>(globalObject);
483
    if (auto* loader = scriptModuleLoader(thisObject))
484
        RELEASE_AND_RETURN(scope, loader->importModule(globalObject, moduleLoader, moduleName, parameters, sourceOrigin));
485
    JSC::JSInternalPromise* promise = JSC::JSInternalPromise::create(vm, globalObject->internalPromiseStructure());
486
    scope.release();
487
    promise->reject(globalObject, jsUndefined());
488
    return promise;
489
}
490
491
JSC::JSObject* JSDOMGlobalObject::moduleLoaderCreateImportMetaProperties(JSC::JSGlobalObject* globalObject, JSC::JSModuleLoader* moduleLoader, JSC::JSValue moduleKey, JSC::JSModuleRecord* moduleRecord, JSC::JSValue scriptFetcher)
492
{
493
    JSDOMGlobalObject* thisObject = JSC::jsCast<JSDOMGlobalObject*>(globalObject);
494
    if (auto* loader = scriptModuleLoader(thisObject))
495
        return loader->createImportMetaProperties(globalObject, moduleLoader, moduleKey, moduleRecord, scriptFetcher);
496
    return constructEmptyObject(globalObject->vm(), globalObject->nullPrototypeObjectStructure());
497
}
498
425
JSDOMGlobalObject& callerGlobalObject(JSGlobalObject& lexicalGlobalObject, CallFrame& callFrame)
499
JSDOMGlobalObject& callerGlobalObject(JSGlobalObject& lexicalGlobalObject, CallFrame& callFrame)
426
{
500
{
427
    class GetCallerGlobalObjectFunctor {
501
    class GetCallerGlobalObjectFunctor {
- a/Source/WebCore/bindings/js/JSDOMGlobalObject.h +6 lines
Lines 105-110 class WEBCORE_EXPORT JSDOMGlobalObject : public JSC::JSGlobalObject { a/Source/WebCore/bindings/js/JSDOMGlobalObject.h_sec1
105
    static JSC::JSPromise* instantiateStreaming(JSC::JSGlobalObject*, JSC::JSValue, JSC::JSObject*);
105
    static JSC::JSPromise* instantiateStreaming(JSC::JSGlobalObject*, JSC::JSValue, JSC::JSObject*);
106
#endif
106
#endif
107
107
108
    static JSC::Identifier moduleLoaderResolve(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSValue, JSC::JSValue);
109
    static JSC::JSInternalPromise* moduleLoaderFetch(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSValue, JSC::JSValue);
110
    static JSC::JSValue moduleLoaderEvaluate(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSValue, JSC::JSValue);
111
    static JSC::JSInternalPromise* moduleLoaderImportModule(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSString*, JSC::JSValue, const JSC::SourceOrigin&);
112
    static JSC::JSObject* moduleLoaderCreateImportMetaProperties(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSModuleRecord*, JSC::JSValue);
113
108
    JSDOMStructureMap m_structures;
114
    JSDOMStructureMap m_structures;
109
    JSDOMConstructorMap m_constructors;
115
    JSDOMConstructorMap m_constructors;
110
    DOMGuardedObjectSet m_guardedObjects;
116
    DOMGuardedObjectSet m_guardedObjects;
- a/Source/WebCore/bindings/js/JSDOMWindowBase.cpp -50 lines
Lines 339-392 void JSDOMWindowBase::fireFrameClearedWatchpointsForWindow(DOMWindow* window) a/Source/WebCore/bindings/js/JSDOMWindowBase.cpp_sec1
339
    }
339
    }
340
}
340
}
341
341
342
JSC::Identifier JSDOMWindowBase::moduleLoaderResolve(JSC::JSGlobalObject* globalObject, JSC::JSModuleLoader* moduleLoader, JSC::JSValue moduleName, JSC::JSValue importerModuleKey, JSC::JSValue scriptFetcher)
343
{
344
    JSDOMWindowBase* thisObject = JSC::jsCast<JSDOMWindowBase*>(globalObject);
345
    if (RefPtr<Document> document = thisObject->wrapped().document())
346
        return document->moduleLoader().resolve(globalObject, moduleLoader, moduleName, importerModuleKey, scriptFetcher);
347
    return { };
348
}
349
350
JSC::JSInternalPromise* JSDOMWindowBase::moduleLoaderFetch(JSC::JSGlobalObject* globalObject, JSC::JSModuleLoader* moduleLoader, JSC::JSValue moduleKey, JSC::JSValue parameters, JSC::JSValue scriptFetcher)
351
{
352
    VM& vm = globalObject->vm();
353
    auto scope = DECLARE_THROW_SCOPE(vm);
354
    JSDOMWindowBase* thisObject = JSC::jsCast<JSDOMWindowBase*>(globalObject);
355
    if (RefPtr<Document> document = thisObject->wrapped().document())
356
        RELEASE_AND_RETURN(scope, document->moduleLoader().fetch(globalObject, moduleLoader, moduleKey, parameters, scriptFetcher));
357
    JSC::JSInternalPromise* promise = JSC::JSInternalPromise::create(vm, globalObject->internalPromiseStructure());
358
    scope.release();
359
    promise->reject(globalObject, jsUndefined());
360
    return promise;
361
}
362
363
JSC::JSValue JSDOMWindowBase::moduleLoaderEvaluate(JSC::JSGlobalObject* globalObject, JSC::JSModuleLoader* moduleLoader, JSC::JSValue moduleKey, JSC::JSValue moduleRecord, JSC::JSValue scriptFetcher)
364
{
365
    JSDOMWindowBase* thisObject = JSC::jsCast<JSDOMWindowBase*>(globalObject);
366
    if (RefPtr<Document> document = thisObject->wrapped().document())
367
        return document->moduleLoader().evaluate(globalObject, moduleLoader, moduleKey, moduleRecord, scriptFetcher);
368
    return JSC::jsUndefined();
369
}
370
371
JSC::JSInternalPromise* JSDOMWindowBase::moduleLoaderImportModule(JSC::JSGlobalObject* globalObject, JSC::JSModuleLoader* moduleLoader, JSC::JSString* moduleName, JSC::JSValue parameters, const JSC::SourceOrigin& sourceOrigin)
372
{
373
    VM& vm = globalObject->vm();
374
    auto scope = DECLARE_THROW_SCOPE(vm);
375
    JSDOMWindowBase* thisObject = JSC::jsCast<JSDOMWindowBase*>(globalObject);
376
    if (RefPtr<Document> document = thisObject->wrapped().document())
377
        RELEASE_AND_RETURN(scope, document->moduleLoader().importModule(globalObject, moduleLoader, moduleName, parameters, sourceOrigin));
378
    JSC::JSInternalPromise* promise = JSC::JSInternalPromise::create(vm, globalObject->internalPromiseStructure());
379
    scope.release();
380
    promise->reject(globalObject, jsUndefined());
381
    return promise;
382
}
383
384
JSC::JSObject* JSDOMWindowBase::moduleLoaderCreateImportMetaProperties(JSC::JSGlobalObject* globalObject, JSC::JSModuleLoader* moduleLoader, JSC::JSValue moduleKey, JSC::JSModuleRecord* moduleRecord, JSC::JSValue scriptFetcher)
385
{
386
    JSDOMWindowBase* thisObject = JSC::jsCast<JSDOMWindowBase*>(globalObject);
387
    if (RefPtr<Document> document = thisObject->wrapped().document())
388
        return document->moduleLoader().createImportMetaProperties(globalObject, moduleLoader, moduleKey, moduleRecord, scriptFetcher);
389
    return constructEmptyObject(globalObject->vm(), globalObject->nullPrototypeObjectStructure());
390
}
391
392
} // namespace WebCore
342
} // namespace WebCore
- a/Source/WebCore/bindings/js/JSDOMWindowBase.h -6 lines
Lines 99-110 class WEBCORE_EXPORT JSDOMWindowBase : public JSDOMGlobalObject { a/Source/WebCore/bindings/js/JSDOMWindowBase.h_sec1
99
private:
99
private:
100
    using ResponseCallback = WTF::Function<void(const char*, size_t)>;
100
    using ResponseCallback = WTF::Function<void(const char*, size_t)>;
101
101
102
    static JSC::Identifier moduleLoaderResolve(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSValue, JSC::JSValue);
103
    static JSC::JSInternalPromise* moduleLoaderFetch(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSValue, JSC::JSValue);
104
    static JSC::JSValue moduleLoaderEvaluate(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSValue, JSC::JSValue);
105
    static JSC::JSInternalPromise* moduleLoaderImportModule(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSString*, JSC::JSValue, const JSC::SourceOrigin&);
106
    static JSC::JSObject* moduleLoaderCreateImportMetaProperties(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSModuleRecord*, JSC::JSValue);
107
108
    RefPtr<DOMWindow> m_wrapped;
102
    RefPtr<DOMWindow> m_wrapped;
109
    RefPtr<Event> m_currentEvent;
103
    RefPtr<Event> m_currentEvent;
110
};
104
};
- a/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp -5 / +5 lines
Lines 59-69 const GlobalObjectMethodTable JSWorkerGlobalScopeBase::s_globalObjectMethodTable a/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp_sec1
59
    &javaScriptRuntimeFlags,
59
    &javaScriptRuntimeFlags,
60
    &queueMicrotaskToEventLoop,
60
    &queueMicrotaskToEventLoop,
61
    &shouldInterruptScriptBeforeTimeout,
61
    &shouldInterruptScriptBeforeTimeout,
62
    nullptr, // moduleLoaderImportModule
62
    &moduleLoaderImportModule,
63
    nullptr, // moduleLoaderResolve
63
    &moduleLoaderResolve,
64
    nullptr, // moduleLoaderFetch
64
    &moduleLoaderFetch,
65
    nullptr, // moduleLoaderCreateImportMetaProperties
65
    &moduleLoaderCreateImportMetaProperties,
66
    nullptr, // moduleLoaderEvaluate
66
    &moduleLoaderEvaluate,
67
    &promiseRejectionTracker,
67
    &promiseRejectionTracker,
68
    &reportUncaughtExceptionAtEventLoop,
68
    &reportUncaughtExceptionAtEventLoop,
69
    &currentScriptExecutionOwner,
69
    &currentScriptExecutionOwner,
- a/Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.cpp -5 / +5 lines
Lines 49-59 const GlobalObjectMethodTable JSWorkletGlobalScopeBase::s_globalObjectMethodTabl a/Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.cpp_sec1
49
    &javaScriptRuntimeFlags,
49
    &javaScriptRuntimeFlags,
50
    nullptr, // queueMicrotaskToEventLoop
50
    nullptr, // queueMicrotaskToEventLoop
51
    &shouldInterruptScriptBeforeTimeout,
51
    &shouldInterruptScriptBeforeTimeout,
52
    nullptr, // moduleLoaderImportModule
52
    &moduleLoaderImportModule,
53
    nullptr, // moduleLoaderResolve
53
    &moduleLoaderResolve,
54
    nullptr, // moduleLoaderFetch
54
    &moduleLoaderFetch,
55
    nullptr, // moduleLoaderCreateImportMetaProperties
55
    &moduleLoaderCreateImportMetaProperties,
56
    nullptr, // moduleLoaderEvaluate
56
    &moduleLoaderEvaluate,
57
    &promiseRejectionTracker,
57
    &promiseRejectionTracker,
58
    &reportUncaughtExceptionAtEventLoop,
58
    &reportUncaughtExceptionAtEventLoop,
59
    &currentScriptExecutionOwner,
59
    &currentScriptExecutionOwner,
- a/Source/WebCore/bindings/js/ModuleScriptLoader.h +53 lines
Line 0 a/Source/WebCore/bindings/js/ModuleScriptLoader.h_sec1
1
/*
2
 * Copyright (C) 2021 Apple Inc. All rights reserved.
3
 *
4
 * Redistribution and use in source and binary forms, with or without
5
 * modification, are permitted provided that the following conditions
6
 * are met:
7
 * 1. Redistributions of source code must retain the above copyright
8
 *    notice, this list of conditions and the following disclaimer.
9
 * 2. Redistributions in binary form must reproduce the above copyright
10
 *    notice, this list of conditions and the following disclaimer in the
11
 *    documentation and/or other materials provided with the distribution.
12
 *
13
 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
14
 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
15
 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16
 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
17
 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
18
 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
19
 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
20
 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
21
 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
22
 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
23
 * THE POSSIBILITY OF SUCH DAMAGE.
24
 */
25
26
#pragma once
27
28
#include <wtf/RefCounted.h>
29
30
namespace WebCore {
31
32
class ModuleScriptLoaderClient;
33
34
class ModuleScriptLoader : public RefCounted<ModuleScriptLoader> {
35
public:
36
    virtual ~ModuleScriptLoader() = default;
37
38
    void clearClient()
39
    {
40
        ASSERT(m_client);
41
        m_client = nullptr;
42
    }
43
44
protected:
45
    ModuleScriptLoader(ModuleScriptLoaderClient& client)
46
        : m_client(&client)
47
    {
48
    }
49
50
    ModuleScriptLoaderClient* m_client;
51
};
52
53
} // namespace WebCore
- a/Source/WebCore/bindings/js/ModuleScriptLoaderClient.h +40 lines
Line 0 a/Source/WebCore/bindings/js/ModuleScriptLoaderClient.h_sec1
1
/*
2
 * Copyright (C) 2021 Apple, Inc. All Rights Reserved.
3
 *
4
 * Redistribution and use in source and binary forms, with or without
5
 * modification, are permitted provided that the following conditions
6
 * are met:
7
 * 1. Redistributions of source code must retain the above copyright
8
 *    notice, this list of conditions and the following disclaimer.
9
 * 2. Redistributions in binary form must reproduce the above copyright
10
 *    notice, this list of conditions and the following disclaimer in the
11
 *    documentation and/or other materials provided with the distribution.
12
 *
13
 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14
 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16
 * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
17
 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18
 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19
 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20
 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21
 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24
 */
25
26
#pragma once
27
28
namespace WebCore {
29
30
class ModuleScriptLoader;
31
class DeferredPromise;
32
33
class ModuleScriptLoaderClient {
34
public:
35
    virtual ~ModuleScriptLoaderClient() = default;
36
37
    virtual void notifyFinished(ModuleScriptLoader&, URL&&, Ref<DeferredPromise>) = 0;
38
};
39
40
}
- a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp -64 / +133 lines
Lines 29-35 a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec1
29
#include "CachedModuleScriptLoader.h"
29
#include "CachedModuleScriptLoader.h"
30
#include "CachedScript.h"
30
#include "CachedScript.h"
31
#include "CachedScriptFetcher.h"
31
#include "CachedScriptFetcher.h"
32
#include "Document.h"
33
#include "Frame.h"
32
#include "Frame.h"
34
#include "JSDOMBinding.h"
33
#include "JSDOMBinding.h"
35
#include "JSDOMPromiseDeferred.h"
34
#include "JSDOMPromiseDeferred.h"
Lines 52-59 a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec2
52
51
53
namespace WebCore {
52
namespace WebCore {
54
53
55
ScriptModuleLoader::ScriptModuleLoader(Document& document)
54
ScriptModuleLoader::ScriptModuleLoader(ScriptExecutionContext& context, OwnerType ownerType)
56
    : m_document(document)
55
    : m_context(context)
56
    , m_ownerType(ownerType)
57
{
57
{
58
}
58
}
59
59
Lines 68-74 static bool isRootModule(JSC::JSValue importerModuleKey) a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec3
68
    return importerModuleKey.isSymbol() || importerModuleKey.isUndefined();
68
    return importerModuleKey.isSymbol() || importerModuleKey.isUndefined();
69
}
69
}
70
70
71
static Expected<URL, String> resolveModuleSpecifier(Document& document, const String& specifier, const URL& baseURL)
71
static Expected<URL, String> resolveModuleSpecifier(ScriptExecutionContext& context, ScriptModuleLoader::OwnerType ownerType, const String& specifier, const URL& baseURL)
72
{
72
{
73
    // https://html.spec.whatwg.org/multipage/webappapis.html#resolve-a-module-specifier
73
    // https://html.spec.whatwg.org/multipage/webappapis.html#resolve-a-module-specifier
74
74
Lines 79-85 static Expected<URL, String> resolveModuleSpecifier(Document& document, const St a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec4
79
    if (!specifier.startsWith('/') && !specifier.startsWith("./") && !specifier.startsWith("../"))
79
    if (!specifier.startsWith('/') && !specifier.startsWith("./") && !specifier.startsWith("../"))
80
        return makeUnexpected(makeString("Module specifier, '"_s, specifier, "' does not start with \"/\", \"./\", or \"../\". Referenced from "_s, baseURL.string()));
80
        return makeUnexpected(makeString("Module specifier, '"_s, specifier, "' does not start with \"/\", \"./\", or \"../\". Referenced from "_s, baseURL.string()));
81
81
82
    auto result = document.completeURL(specifier, baseURL);
82
    URL result;
83
    if (ownerType == ScriptModuleLoader::OwnerType::Document)
84
        result = downcast<Document>(context).completeURL(specifier, baseURL);
85
    else
86
        result = URL(baseURL, specifier);
87
83
    if (!result.isValid())
88
    if (!result.isValid())
84
        return makeUnexpected(makeString("Module name, '"_s, result.string(), "' does not resolve to a valid URL."_s));
89
        return makeUnexpected(makeString("Module name, '"_s, result.string(), "' does not resolve to a valid URL."_s));
85
    return result;
90
    return result;
Lines 107-113 JSC::Identifier ScriptModuleLoader::resolve(JSC::JSGlobalObject* jsGlobalObject, a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec5
107
    URL baseURL = responseURLFromRequestURL(*jsGlobalObject, importerModuleKey);
112
    URL baseURL = responseURLFromRequestURL(*jsGlobalObject, importerModuleKey);
108
    RETURN_IF_EXCEPTION(scope, { });
113
    RETURN_IF_EXCEPTION(scope, { });
109
114
110
    auto result = resolveModuleSpecifier(m_document, specifier, baseURL);
115
    auto result = resolveModuleSpecifier(m_context, m_ownerType, specifier, baseURL);
111
    if (!result) {
116
    if (!result) {
112
        JSC::throwTypeError(jsGlobalObject, scope, result.error());
117
        JSC::throwTypeError(jsGlobalObject, scope, result.error());
113
        return { };
118
        return { };
Lines 161-173 JSC::JSInternalPromise* ScriptModuleLoader::fetch(JSC::JSGlobalObject* jsGlobalO a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec6
161
    if (auto* scriptFetchParameters = JSC::jsDynamicCast<JSC::JSScriptFetchParameters*>(vm, parameters))
166
    if (auto* scriptFetchParameters = JSC::jsDynamicCast<JSC::JSScriptFetchParameters*>(vm, parameters))
162
        topLevelFetchParameters = static_cast<ModuleFetchParameters*>(&scriptFetchParameters->parameters());
167
        topLevelFetchParameters = static_cast<ModuleFetchParameters*>(&scriptFetchParameters->parameters());
163
168
164
    auto loader = CachedModuleScriptLoader::create(*this, deferred.get(), *static_cast<CachedScriptFetcher*>(JSC::jsCast<JSC::JSScriptFetcher*>(scriptFetcher)->fetcher()), WTFMove(topLevelFetchParameters));
169
    if (m_ownerType == OwnerType::Document) {
165
    m_loaders.add(loader.copyRef());
170
        auto loader = CachedModuleScriptLoader::create(*this, deferred.get(), *static_cast<CachedScriptFetcher*>(JSC::jsCast<JSC::JSScriptFetcher*>(scriptFetcher)->fetcher()), WTFMove(topLevelFetchParameters));
166
    if (!loader->load(m_document, completedURL)) {
171
        m_loaders.add(loader.copyRef());
167
        loader->clearClient();
172
        if (!loader->load(downcast<Document>(m_context), WTFMove(completedURL))) {
168
        m_loaders.remove(WTFMove(loader));
173
            loader->clearClient();
169
        rejectToPropagateNetworkError(deferred.get(), ModuleFetchFailureKind::WasErrored, "Importing a module script failed."_s);
174
            m_loaders.remove(WTFMove(loader));
170
        return jsPromise;
175
            rejectToPropagateNetworkError(deferred.get(), ModuleFetchFailureKind::WasErrored, "Importing a module script failed."_s);
176
            return jsPromise;
177
        }
178
    } else {
179
        auto loader = WorkerModuleScriptLoader::create(*this, deferred.get(), *static_cast<CachedScriptFetcher*>(JSC::jsCast<JSC::JSScriptFetcher*>(scriptFetcher)->fetcher()), WTFMove(topLevelFetchParameters));
180
        m_loaders.add(loader.copyRef());
181
        loader->load(m_context, WTFMove(completedURL));
171
    }
182
    }
172
183
173
    return jsPromise;
184
    return jsPromise;
Lines 176-182 JSC::JSInternalPromise* ScriptModuleLoader::fetch(JSC::JSGlobalObject* jsGlobalO a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec7
176
URL ScriptModuleLoader::moduleURL(JSC::JSGlobalObject& jsGlobalObject, JSC::JSValue moduleKeyValue)
187
URL ScriptModuleLoader::moduleURL(JSC::JSGlobalObject& jsGlobalObject, JSC::JSValue moduleKeyValue)
177
{
188
{
178
    if (moduleKeyValue.isSymbol())
189
    if (moduleKeyValue.isSymbol())
179
        return m_document.url();
190
        return m_context.url();
180
191
181
    ASSERT(moduleKeyValue.isString());
192
    ASSERT(moduleKeyValue.isString());
182
    return URL(URL(), asString(moduleKeyValue)->value(&jsGlobalObject));
193
    return URL(URL(), asString(moduleKeyValue)->value(&jsGlobalObject));
Lines 187-194 URL ScriptModuleLoader::responseURLFromRequestURL(JSC::JSGlobalObject& jsGlobalO a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec8
187
    JSC::VM& vm = jsGlobalObject.vm();
198
    JSC::VM& vm = jsGlobalObject.vm();
188
    auto scope = DECLARE_THROW_SCOPE(vm);
199
    auto scope = DECLARE_THROW_SCOPE(vm);
189
200
190
    if (isRootModule(moduleKeyValue))
201
    if (isRootModule(moduleKeyValue)) {
191
        return m_document.baseURL();
202
        if (m_ownerType == OwnerType::Document)
203
            return downcast<Document>(m_context).baseURL();
204
        return m_context.url();
205
    }
192
206
193
    ASSERT(!isRootModule(moduleKeyValue));
207
    ASSERT(!isRootModule(moduleKeyValue));
194
    ASSERT(moduleKeyValue.isString());
208
    ASSERT(moduleKeyValue.isString());
Lines 219-226 JSC::JSValue ScriptModuleLoader::evaluate(JSC::JSGlobalObject* jsGlobalObject, J a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec9
219
    if (!sourceURL.isValid())
233
    if (!sourceURL.isValid())
220
        return JSC::throwTypeError(jsGlobalObject, scope, "Module key is an invalid URL."_s);
234
        return JSC::throwTypeError(jsGlobalObject, scope, "Module key is an invalid URL."_s);
221
235
222
    if (auto* frame = m_document.frame())
236
    if (m_ownerType == OwnerType::Document) {
223
        return frame->script().evaluateModule(sourceURL, *moduleRecord);
237
        if (auto* frame = downcast<Document>(m_context).frame())
238
            return frame->script().evaluateModule(sourceURL, *moduleRecord);
239
    } else {
240
        ASSERT(is<WorkerOrWorkletGlobalScope>(m_context));
241
        if (auto* script = downcast<WorkerOrWorkletGlobalScope>(m_context).script())
242
            return script->evaluateModule(*moduleRecord);
243
    }
224
    return JSC::jsUndefined();
244
    return JSC::jsUndefined();
225
}
245
}
226
246
Lines 248-270 JSC::JSInternalPromise* ScriptModuleLoader::importModule(JSC::JSGlobalObject* js a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec10
248
    URL baseURL;
268
    URL baseURL;
249
    RefPtr<JSC::ScriptFetcher> scriptFetcher;
269
    RefPtr<JSC::ScriptFetcher> scriptFetcher;
250
    if (sourceOrigin.isNull()) {
270
    if (sourceOrigin.isNull()) {
251
        baseURL = m_document.baseURL();
271
        String charset;
252
        scriptFetcher = CachedScriptFetcher::create(m_document.charset());
272
        if (m_ownerType == OwnerType::Document) {
273
            baseURL = downcast<Document>(m_context).baseURL();
274
            charset = downcast<Document>(m_context).charset();
275
        } else {
276
            baseURL = m_context.url();
277
            charset = "utf-8"_s;
278
        }
279
        scriptFetcher = CachedScriptFetcher::create(WTFMove(charset));
253
    } else {
280
    } else {
254
        baseURL = URL(URL(), sourceOrigin.string());
281
        baseURL = URL(URL(), sourceOrigin.string());
255
        if (!baseURL.isValid())
282
        if (!baseURL.isValid())
256
            return rejectPromise(globalObject, TypeError, "Importer module key is not a Symbol or a String."_s);
283
            return rejectPromise(globalObject, TypeError, "Importer module key is not a Symbol or a String."_s);
257
284
285
        String charset;
286
        if (m_ownerType == OwnerType::Document)
287
            charset = downcast<Document>(m_context).charset();
288
        else
289
            charset = "utf-8"_s;
290
258
        if (sourceOrigin.fetcher())
291
        if (sourceOrigin.fetcher())
259
            scriptFetcher = sourceOrigin.fetcher();
292
            scriptFetcher = sourceOrigin.fetcher();
260
        else
293
        else
261
            scriptFetcher = CachedScriptFetcher::create(m_document.charset());
294
            scriptFetcher = CachedScriptFetcher::create(WTFMove(charset));
262
    }
295
    }
263
    ASSERT(baseURL.isValid());
296
    ASSERT(baseURL.isValid());
264
    ASSERT(scriptFetcher);
297
    ASSERT(scriptFetcher);
265
298
266
    auto specifier = moduleName->value(jsGlobalObject);
299
    auto specifier = moduleName->value(jsGlobalObject);
267
    auto result = resolveModuleSpecifier(m_document, specifier, baseURL);
300
    auto result = resolveModuleSpecifier(m_context, m_ownerType, specifier, baseURL);
268
    if (!result)
301
    if (!result)
269
        return rejectPromise(globalObject, TypeError, result.error());
302
        return rejectPromise(globalObject, TypeError, result.error());
270
303
Lines 288-349 JSC::JSObject* ScriptModuleLoader::createImportMetaProperties(JSC::JSGlobalObjec a/Source/WebCore/bindings/js/ScriptModuleLoader.cpp_sec11
288
    return metaProperties;
321
    return metaProperties;
289
}
322
}
290
323
291
void ScriptModuleLoader::notifyFinished(CachedModuleScriptLoader& loader, RefPtr<DeferredPromise> promise)
324
void ScriptModuleLoader::notifyFinished(ModuleScriptLoader& moduleScriptLoader, URL&& sourceURL, Ref<DeferredPromise> promise)
292
{
325
{
293
    // https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-single-module-script
326
    // https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-single-module-script
294
327
295
    URL sourceURL = loader.sourceURL();
328
    if (!m_loaders.remove(&moduleScriptLoader))
296
    if (!m_loaders.remove(&loader))
297
        return;
329
        return;
298
    loader.clearClient();
330
    moduleScriptLoader.clearClient();
299
331
300
    auto& cachedScript = *loader.cachedScript();
332
    if (m_ownerType == OwnerType::Document) {
333
        auto& loader = static_cast<CachedModuleScriptLoader&>(moduleScriptLoader);
334
        auto& cachedScript = *loader.cachedScript();
301
335
302
    if (cachedScript.resourceError().isAccessControl()) {
336
        if (cachedScript.resourceError().isAccessControl()) {
303
        promise->reject(TypeError, "Cross-origin script load denied by Cross-Origin Resource Sharing policy."_s);
337
            promise->reject(TypeError, "Cross-origin script load denied by Cross-Origin Resource Sharing policy."_s);
304
        return;
338
            return;
305
    }
339
        }
306
340
307
    if (cachedScript.errorOccurred()) {
341
        if (cachedScript.errorOccurred()) {
308
        rejectToPropagateNetworkError(*promise, ModuleFetchFailureKind::WasErrored, "Importing a module script failed."_s);
342
            rejectToPropagateNetworkError(promise.get(), ModuleFetchFailureKind::WasErrored, "Importing a module script failed."_s);
309
        return;
343
            return;
310
    }
344
        }
311
345
312
    if (cachedScript.wasCanceled()) {
346
        if (cachedScript.wasCanceled()) {
313
        rejectToPropagateNetworkError(*promise, ModuleFetchFailureKind::WasCanceled, "Importing a module script is canceled."_s);
347
            rejectToPropagateNetworkError(promise.get(), ModuleFetchFailureKind::WasCanceled, "Importing a module script is canceled."_s);
314
        return;
348
            return;
315
    }
349
        }
316
350
317
    if (!MIMETypeRegistry::isSupportedJavaScriptMIMEType(cachedScript.response().mimeType())) {
351
        if (!MIMETypeRegistry::isSupportedJavaScriptMIMEType(cachedScript.response().mimeType())) {
318
        // https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-single-module-script
352
            // https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-single-module-script
319
        // The result of extracting a MIME type from response's header list (ignoring parameters) is not a JavaScript MIME type.
353
            // The result of extracting a MIME type from response's header list (ignoring parameters) is not a JavaScript MIME type.
320
        // For historical reasons, fetching a classic script does not include MIME type checking. In contrast, module scripts will fail to load if they are not of a correct MIME type.
354
            // For historical reasons, fetching a classic script does not include MIME type checking. In contrast, module scripts will fail to load if they are not of a correct MIME type.
321
        promise->reject(TypeError, makeString("'", cachedScript.response().mimeType(), "' is not a valid JavaScript MIME type."));
355
            promise->reject(TypeError, makeString("'", cachedScript.response().mimeType(), "' is not a valid JavaScript MIME type."));
322
        return;
356
            return;
323
    }
357
        }
324
358
325
    if (auto* parameters = loader.parameters()) {
359
        if (auto* parameters = loader.parameters()) {
326
        if (!matchIntegrityMetadata(cachedScript, parameters->integrity())) {
360
            if (!matchIntegrityMetadata(cachedScript, parameters->integrity())) {
327
            promise->reject(TypeError, makeString("Cannot load script ", integrityMismatchDescription(cachedScript, parameters->integrity())));
361
                promise->reject(TypeError, makeString("Cannot load script ", integrityMismatchDescription(cachedScript, parameters->integrity())));
362
                return;
363
            }
364
        }
365
366
        URL responseURL = cachedScript.response().url();
367
        // If we do not have redirection, we must reserve the source URL's fragment explicitly here since ResourceResponse::url() is the one when we first cache it to MemoryCache.
368
        // FIXME: We should track fragments through redirections.
369
        // https://bugs.webkit.org/show_bug.cgi?id=158420
370
        // https://bugs.webkit.org/show_bug.cgi?id=210490
371
        if (!cachedScript.hasRedirections() && cachedScript.response().source() != ResourceResponse::Source::ServiceWorker) {
372
            if (sourceURL.hasFragmentIdentifier())
373
                responseURL.setFragmentIdentifier(sourceURL.fragmentIdentifier());
374
        }
375
376
        m_requestURLToResponseURLMap.add(sourceURL.string(), WTFMove(responseURL));
377
        promise->resolveWithCallback([&] (JSDOMGlobalObject& jsGlobalObject) {
378
            return JSC::JSSourceCode::create(jsGlobalObject.vm(),
379
                JSC::SourceCode { ScriptSourceCode { &cachedScript, JSC::SourceProviderSourceType::Module, loader.scriptFetcher() }.jsSourceCode() });
380
        });
381
    } else {
382
        auto& loader = static_cast<WorkerModuleScriptLoader&>(moduleScriptLoader);
383
        auto& workerScriptLoader = loader.scriptLoader();
384
385
        if (workerScriptLoader.failed()) {
386
            if (workerScriptLoader.error().isAccessControl()) {
387
                promise->reject(TypeError, "Cross-origin script load denied by Cross-Origin Resource Sharing policy."_s);
388
                return;
389
            }
390
391
            if (workerScriptLoader.error().isCancellation()) {
392
                rejectToPropagateNetworkError(promise.get(), ModuleFetchFailureKind::WasCanceled, "Importing a module script is canceled."_s);
393
                return;
394
            }
395
396
            rejectToPropagateNetworkError(promise.get(), ModuleFetchFailureKind::WasErrored, "Importing a module script failed."_s);
328
            return;
397
            return;
329
        }
398
        }
330
    }
331
399
332
    URL responseURL = cachedScript.response().url();
400
        if (!MIMETypeRegistry::isSupportedJavaScriptMIMEType(workerScriptLoader.responseMIMEType())) {
333
    // If we do not have redirection, we must reserve the source URL's fragment explicitly here since ResourceResponse::url() is the one when we first cache it to MemoryCache.
401
            // https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-single-module-script
334
    // FIXME: We should track fragments through redirections.
402
            // The result of extracting a MIME type from response's header list (ignoring parameters) is not a JavaScript MIME type.
335
    // https://bugs.webkit.org/show_bug.cgi?id=158420
403
            // For historical reasons, fetching a classic script does not include MIME type checking. In contrast, module scripts will fail to load if they are not of a correct MIME type.
336
    // https://bugs.webkit.org/show_bug.cgi?id=210490
404
            promise->reject(TypeError, makeString("'", workerScriptLoader.responseMIMEType(), "' is not a valid JavaScript MIME type."));
337
    if (!cachedScript.hasRedirections() && cachedScript.response().source() != ResourceResponse::Source::ServiceWorker) {
405
            return;
338
        if (sourceURL.hasFragmentIdentifier())
406
        }
339
            responseURL.setFragmentIdentifier(sourceURL.fragmentIdentifier());
340
    }
341
407
342
    m_requestURLToResponseURLMap.add(sourceURL.string(), WTFMove(responseURL));
408
        URL responseURL = workerScriptLoader.responseURL();
343
    promise->resolveWithCallback([&] (JSDOMGlobalObject& jsGlobalObject) {
409
344
        return JSC::JSSourceCode::create(jsGlobalObject.vm(),
410
        m_requestURLToResponseURLMap.add(sourceURL.string(), responseURL);
345
            JSC::SourceCode { ScriptSourceCode { &cachedScript, JSC::SourceProviderSourceType::Module, loader.scriptFetcher() }.jsSourceCode() });
411
        promise->resolveWithCallback([&] (JSDOMGlobalObject& jsGlobalObject) {
346
    });
412
            return JSC::JSSourceCode::create(jsGlobalObject.vm(),
413
                JSC::SourceCode { ScriptSourceCode { workerScriptLoader.script(), WTFMove(responseURL), { }, JSC::SourceProviderSourceType::Module, loader.scriptFetcher() }.jsSourceCode() });
414
        });
415
    }
347
}
416
}
348
417
349
}
418
}
- a/Source/WebCore/bindings/js/ScriptModuleLoader.h -9 / +12 lines
Lines 25-32 a/Source/WebCore/bindings/js/ScriptModuleLoader.h_sec1
25
25
26
#pragma once
26
#pragma once
27
27
28
#include "CachedModuleScriptLoader.h"
28
#include "ModuleScriptLoader.h"
29
#include "CachedModuleScriptLoaderClient.h"
29
#include "ModuleScriptLoaderClient.h"
30
#include <JavaScriptCore/JSCJSValue.h>
30
#include <JavaScriptCore/JSCJSValue.h>
31
#include <wtf/HashSet.h>
31
#include <wtf/HashSet.h>
32
#include <wtf/Noncopyable.h>
32
#include <wtf/Noncopyable.h>
Lines 45-60 class SourceOrigin; a/Source/WebCore/bindings/js/ScriptModuleLoader.h_sec2
45
45
46
namespace WebCore {
46
namespace WebCore {
47
47
48
class Document;
49
class JSDOMGlobalObject;
48
class JSDOMGlobalObject;
49
class ScriptExecutionContext;
50
50
51
class ScriptModuleLoader final : private CachedModuleScriptLoaderClient {
51
class ScriptModuleLoader final : private ModuleScriptLoaderClient {
52
    WTF_MAKE_NONCOPYABLE(ScriptModuleLoader); WTF_MAKE_FAST_ALLOCATED;
52
    WTF_MAKE_NONCOPYABLE(ScriptModuleLoader); WTF_MAKE_FAST_ALLOCATED;
53
public:
53
public:
54
    explicit ScriptModuleLoader(Document&);
54
    enum class OwnerType : uint8_t { Document, WorkerOrWorklet };
55
    explicit ScriptModuleLoader(ScriptExecutionContext&, OwnerType);
55
    ~ScriptModuleLoader();
56
    ~ScriptModuleLoader();
56
57
57
    Document& document() { return m_document; }
58
    ScriptExecutionContext& context() { return m_context; }
58
59
59
    JSC::Identifier resolve(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue moduleName, JSC::JSValue importerModuleKey, JSC::JSValue scriptFetcher);
60
    JSC::Identifier resolve(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue moduleName, JSC::JSValue importerModuleKey, JSC::JSValue scriptFetcher);
60
    JSC::JSInternalPromise* fetch(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue moduleKey, JSC::JSValue parameters, JSC::JSValue scriptFetcher);
61
    JSC::JSInternalPromise* fetch(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue moduleKey, JSC::JSValue parameters, JSC::JSValue scriptFetcher);
Lines 63-75 class ScriptModuleLoader final : private CachedModuleScriptLoaderClient { a/Source/WebCore/bindings/js/ScriptModuleLoader.h_sec3
63
    JSC::JSObject* createImportMetaProperties(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSModuleRecord*, JSC::JSValue);
64
    JSC::JSObject* createImportMetaProperties(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSModuleRecord*, JSC::JSValue);
64
65
65
private:
66
private:
66
    void notifyFinished(CachedModuleScriptLoader&, RefPtr<DeferredPromise>) final;
67
    void notifyFinished(ModuleScriptLoader&, URL&&, Ref<DeferredPromise>) final;
68
67
    URL moduleURL(JSC::JSGlobalObject&, JSC::JSValue);
69
    URL moduleURL(JSC::JSGlobalObject&, JSC::JSValue);
68
    URL responseURLFromRequestURL(JSC::JSGlobalObject&, JSC::JSValue);
70
    URL responseURLFromRequestURL(JSC::JSGlobalObject&, JSC::JSValue);
69
71
70
    Document& m_document;
72
    ScriptExecutionContext& m_context;
71
    HashMap<String, URL> m_requestURLToResponseURLMap;
73
    HashMap<String, URL> m_requestURLToResponseURLMap;
72
    HashSet<Ref<CachedModuleScriptLoader>> m_loaders;
74
    HashSet<Ref<ModuleScriptLoader>> m_loaders;
75
    OwnerType m_ownerType;
73
};
76
};
74
77
75
} // namespace WebCore
78
} // namespace WebCore
- a/Source/WebCore/bindings/js/WorkerModuleScriptLoader.cpp +89 lines
Line 0 a/Source/WebCore/bindings/js/WorkerModuleScriptLoader.cpp_sec1
1
/*
2
 * Copyright (C) 2021 Apple Inc. All rights reserved.
3
 *
4
 * Redistribution and use in source and binary forms, with or without
5
 * modification, are permitted provided that the following conditions
6
 * are met:
7
 * 1. Redistributions of source code must retain the above copyright
8
 *    notice, this list of conditions and the following disclaimer.
9
 * 2. Redistributions in binary form must reproduce the above copyright
10
 *    notice, this list of conditions and the following disclaimer in the
11
 *    documentation and/or other materials provided with the distribution.
12
 *
13
 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
14
 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
15
 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16
 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
17
 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
18
 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
19
 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
20
 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
21
 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
22
 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
23
 * THE POSSIBILITY OF SUCH DAMAGE.
24
 */
25
26
#include "config.h"
27
#include "WorkerModuleScriptLoader.h"
28
29
#include "CachedScriptFetcher.h"
30
#include "DOMWrapperWorld.h"
31
#include "Frame.h"
32
#include "JSDOMBinding.h"
33
#include "JSDOMPromiseDeferred.h"
34
#include "ModuleFetchParameters.h"
35
#include "ResourceLoaderOptions.h"
36
#include "ScriptController.h"
37
#include "ScriptModuleLoader.h"
38
#include "ScriptSourceCode.h"
39
#include "WorkerScriptLoader.h"
40
41
namespace WebCore {
42
43
Ref<WorkerModuleScriptLoader> WorkerModuleScriptLoader::create(ModuleScriptLoaderClient& client, DeferredPromise& promise, CachedScriptFetcher& scriptFetcher, RefPtr<ModuleFetchParameters>&& parameters)
44
{
45
    return adoptRef(*new WorkerModuleScriptLoader(client, promise, scriptFetcher, WTFMove(parameters)));
46
}
47
48
WorkerModuleScriptLoader::WorkerModuleScriptLoader(ModuleScriptLoaderClient& client, DeferredPromise& promise, CachedScriptFetcher& scriptFetcher, RefPtr<ModuleFetchParameters>&& parameters)
49
    : ModuleScriptLoader(client)
50
    , m_promise(&promise)
51
    , m_scriptFetcher(scriptFetcher)
52
    , m_parameters(WTFMove(parameters))
53
    , m_scriptLoader(WorkerScriptLoader::create())
54
{
55
}
56
57
WorkerModuleScriptLoader::~WorkerModuleScriptLoader()
58
{
59
    m_scriptLoader->cancel();
60
}
61
62
bool WorkerModuleScriptLoader::load(ScriptExecutionContext& context, URL&& sourceURL)
63
{
64
    m_sourceURL = WTFMove(sourceURL);
65
66
    ResourceRequest request { m_sourceURL };
67
68
    FetchOptions fetchOptions;
69
    fetchOptions.mode = FetchOptions::Mode::Cors;
70
    fetchOptions.cache = FetchOptions::Cache::Default;
71
    fetchOptions.redirect = FetchOptions::Redirect::Follow;
72
    // FIXME: Propagate credentials.
73
    // fetchOptions.credentials = scriptFetchJob.credentials;
74
    auto contentSecurityPolicyEnforcement = context.shouldBypassMainWorldContentSecurityPolicy() ? ContentSecurityPolicyEnforcement::DoNotEnforce : ContentSecurityPolicyEnforcement::EnforceChildSrcDirective;
75
76
    m_scriptLoader->loadAsynchronously(context, WTFMove(request), WTFMove(fetchOptions), contentSecurityPolicyEnforcement, ServiceWorkersMode::All, *this);
77
    return true;
78
}
79
80
void WorkerModuleScriptLoader::notifyFinished()
81
{
82
    ASSERT(m_promise);
83
84
    auto protectedThis = makeRef(*this);
85
    if (m_client)
86
        m_client->notifyFinished(*this, WTFMove(m_sourceURL), m_promise.releaseNonNull());
87
}
88
89
}
- a/Source/WebCore/bindings/js/WorkerModuleScriptLoader.h +69 lines
Line 0 a/Source/WebCore/bindings/js/WorkerModuleScriptLoader.h_sec1
1
/*
2
 * Copyright (C) 2021 Apple Inc. All rights reserved.
3
 *
4
 * Redistribution and use in source and binary forms, with or without
5
 * modification, are permitted provided that the following conditions
6
 * are met:
7
 * 1. Redistributions of source code must retain the above copyright
8
 *    notice, this list of conditions and the following disclaimer.
9
 * 2. Redistributions in binary form must reproduce the above copyright
10
 *    notice, this list of conditions and the following disclaimer in the
11
 *    documentation and/or other materials provided with the distribution.
12
 *
13
 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
14
 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
15
 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16
 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
17
 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
18
 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
19
 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
20
 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
21
 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
22
 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
23
 * THE POSSIBILITY OF SUCH DAMAGE.
24
 */
25
26
#pragma once
27
28
#include "ModuleScriptLoader.h"
29
#include "WorkerScriptLoaderClient.h"
30
#include <wtf/Ref.h>
31
#include <wtf/RefCounted.h>
32
#include <wtf/RefPtr.h>
33
#include <wtf/URL.h>
34
35
namespace WebCore {
36
37
class DeferredPromise;
38
class JSDOMGlobalObject;
39
class ModuleFetchParameters;
40
class ScriptExecutionContext;
41
class ModuleScriptLoaderClient;
42
class WorkerScriptLoader;
43
44
class WorkerModuleScriptLoader final : public ModuleScriptLoader, private WorkerScriptLoaderClient {
45
public:
46
    static Ref<WorkerModuleScriptLoader> create(ModuleScriptLoaderClient&, DeferredPromise&, CachedScriptFetcher&, RefPtr<ModuleFetchParameters>&&);
47
48
    virtual ~WorkerModuleScriptLoader();
49
50
    bool load(ScriptExecutionContext&, URL&& sourceURL);
51
52
    CachedScriptFetcher& scriptFetcher() { return m_scriptFetcher.get(); }
53
    ModuleFetchParameters* parameters() { return m_parameters.get(); }
54
    WorkerScriptLoader& scriptLoader() { return m_scriptLoader.get(); }
55
56
private:
57
    WorkerModuleScriptLoader(ModuleScriptLoaderClient&, DeferredPromise&, CachedScriptFetcher&, RefPtr<ModuleFetchParameters>&&);
58
59
    void didReceiveResponse(unsigned long, const ResourceResponse&) final { }
60
    void notifyFinished() final;
61
62
    RefPtr<DeferredPromise> m_promise;
63
    Ref<CachedScriptFetcher> m_scriptFetcher;
64
    RefPtr<ModuleFetchParameters> m_parameters;
65
    Ref<WorkerScriptLoader> m_scriptLoader;
66
    URL m_sourceURL;
67
};
68
69
} // namespace WebCore
- a/Source/WebCore/dom/Document.cpp -1 / +1 lines
Lines 615-621 Document::Document(Frame* frame, const Settings& settings, const URL& url, Docum a/Source/WebCore/dom/Document.cpp_sec1
615
    , m_documentCreationTime(MonotonicTime::now())
615
    , m_documentCreationTime(MonotonicTime::now())
616
#endif
616
#endif
617
    , m_scriptRunner(makeUnique<ScriptRunner>(*this))
617
    , m_scriptRunner(makeUnique<ScriptRunner>(*this))
618
    , m_moduleLoader(makeUnique<ScriptModuleLoader>(*this))
618
    , m_moduleLoader(makeUnique<ScriptModuleLoader>(*this, ScriptModuleLoader::OwnerType::Document))
619
#if ENABLE(XSLT)
619
#if ENABLE(XSLT)
620
    , m_applyPendingXSLTransformsTimer(*this, &Document::applyPendingXSLTransformsTimerFired)
620
    , m_applyPendingXSLTransformsTimer(*this, &Document::applyPendingXSLTransformsTimerFired)
621
#endif
621
#endif
- a/Source/WebCore/dom/LoadableModuleScript.cpp -12 lines
Lines 88-103 void LoadableModuleScript::execute(ScriptElement& scriptElement) a/Source/WebCore/dom/LoadableModuleScript.cpp_sec1
88
    scriptElement.executeModuleScript(*this);
88
    scriptElement.executeModuleScript(*this);
89
}
89
}
90
90
91
void LoadableModuleScript::load(Document& document, const URL& rootURL)
92
{
93
    if (auto* frame = document.frame())
94
        frame->script().loadModuleScript(*this, rootURL.string(), m_parameters.copyRef());
95
}
96
97
void LoadableModuleScript::load(Document& document, const ScriptSourceCode& sourceCode)
98
{
99
    if (auto* frame = document.frame())
100
        frame->script().loadModuleScript(*this, sourceCode);
101
}
102
103
}
91
}
- a/Source/WebCore/dom/LoadableModuleScript.h -3 / +2 lines
Lines 50-64 class LoadableModuleScript final : public LoadableScript { a/Source/WebCore/dom/LoadableModuleScript.h_sec1
50
50
51
    void setError(Error&&);
51
    void setError(Error&&);
52
52
53
    void load(Document&, const URL& rootURL);
54
    void load(Document&, const ScriptSourceCode&);
55
56
    void notifyLoadCompleted(UniquedStringImpl&);
53
    void notifyLoadCompleted(UniquedStringImpl&);
57
    void notifyLoadFailed(LoadableScript::Error&&);
54
    void notifyLoadFailed(LoadableScript::Error&&);
58
    void notifyLoadWasCanceled();
55
    void notifyLoadWasCanceled();
59
56
60
    UniquedStringImpl* moduleKey() const { return m_moduleKey.get(); }
57
    UniquedStringImpl* moduleKey() const { return m_moduleKey.get(); }
61
58
59
    ModuleFetchParameters& parameters() { return m_parameters.get(); }
60
62
private:
61
private:
63
    LoadableModuleScript(const String& nonce, const String& integrity, ReferrerPolicy, const String& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree);
62
    LoadableModuleScript(const String& nonce, const String& integrity, ReferrerPolicy, const String& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree);
64
63
- a/Source/WebCore/dom/ScriptElement.cpp -2 / +7 lines
Lines 42-47 a/Source/WebCore/dom/ScriptElement.cpp_sec1
42
#include "LoadableClassicScript.h"
42
#include "LoadableClassicScript.h"
43
#include "LoadableModuleScript.h"
43
#include "LoadableModuleScript.h"
44
#include "MIMETypeRegistry.h"
44
#include "MIMETypeRegistry.h"
45
#include "ModuleFetchParameters.h"
45
#include "PendingScript.h"
46
#include "PendingScript.h"
46
#include "RuntimeApplicationChecks.h"
47
#include "RuntimeApplicationChecks.h"
47
#include "SVGScriptElement.h"
48
#include "SVGScriptElement.h"
Lines 351-358 bool ScriptElement::requestModuleScript(const TextPosition& scriptStartPosition) a/Source/WebCore/dom/ScriptElement.cpp_sec2
351
            scriptCharset(),
352
            scriptCharset(),
352
            m_element.localName(),
353
            m_element.localName(),
353
            m_element.isInUserAgentShadowTree());
354
            m_element.isInUserAgentShadowTree());
354
        script->load(m_element.document(), moduleScriptRootURL);
355
        m_loadableScript = WTFMove(script);
355
        m_loadableScript = WTFMove(script);
356
        if (auto* frame = m_element.document().frame()) {
357
            auto& script = downcast<LoadableModuleScript>(*m_loadableScript.get());
358
            frame->script().loadModuleScript(script, moduleScriptRootURL.string(), makeRef(script.parameters()));
359
        }
356
        return true;
360
        return true;
357
    }
361
    }
358
362
Lines 367-374 bool ScriptElement::requestModuleScript(const TextPosition& scriptStartPosition) a/Source/WebCore/dom/ScriptElement.cpp_sec3
367
    if (!contentSecurityPolicy.allowInlineScript(m_element.document().url().string(), m_startLineNumber, sourceCode.source().toStringWithoutCopying(), hasKnownNonce))
371
    if (!contentSecurityPolicy.allowInlineScript(m_element.document().url().string(), m_startLineNumber, sourceCode.source().toStringWithoutCopying(), hasKnownNonce))
368
        return false;
372
        return false;
369
373
370
    script->load(m_element.document(), sourceCode);
371
    m_loadableScript = WTFMove(script);
374
    m_loadableScript = WTFMove(script);
375
    if (auto* frame = m_element.document().frame())
376
        frame->script().loadModuleScript(downcast<LoadableModuleScript>(*m_loadableScript.get()), sourceCode);
372
    return true;
377
    return true;
373
}
378
}
374
379
- a/Source/WebCore/workers/Worker.cpp -2 / +7 lines
Lines 70-75 inline Worker::Worker(ScriptExecutionContext& context, JSC::RuntimeFlags runtime a/Source/WebCore/workers/Worker.cpp_sec1
70
    , m_identifier("worker:" + Inspector::IdentifiersFactory::createIdentifier())
70
    , m_identifier("worker:" + Inspector::IdentifiersFactory::createIdentifier())
71
    , m_contextProxy(WorkerGlobalScopeProxy::create(*this))
71
    , m_contextProxy(WorkerGlobalScopeProxy::create(*this))
72
    , m_runtimeFlags(runtimeFlags)
72
    , m_runtimeFlags(runtimeFlags)
73
    , m_type(options.type)
74
    , m_credentials(options.credentials)
73
{
75
{
74
    static bool addedListener;
76
    static bool addedListener;
75
    if (!addedListener) {
77
    if (!addedListener) {
Lines 113-122 ExceptionOr<Ref<Worker>> Worker::create(ScriptExecutionContext& context, JSC::Ru a/Source/WebCore/workers/Worker.cpp_sec2
113
115
114
    FetchOptions fetchOptions;
116
    FetchOptions fetchOptions;
115
    fetchOptions.mode = FetchOptions::Mode::SameOrigin;
117
    fetchOptions.mode = FetchOptions::Mode::SameOrigin;
118
    if (worker->m_type == WorkerType::Module)
119
        fetchOptions.credentials = worker->m_credentials;
116
    fetchOptions.cache = FetchOptions::Cache::Default;
120
    fetchOptions.cache = FetchOptions::Cache::Default;
117
    fetchOptions.redirect = FetchOptions::Redirect::Follow;
121
    fetchOptions.redirect = FetchOptions::Redirect::Follow;
118
    fetchOptions.destination = FetchOptions::Destination::Worker;
122
    fetchOptions.destination = FetchOptions::Destination::Worker;
119
    worker->m_scriptLoader->loadAsynchronously(context, WTFMove(request), WTFMove(fetchOptions), contentSecurityPolicyEnforcement, ServiceWorkersMode::All, worker);
123
    worker->m_scriptLoader->loadAsynchronously(context, WTFMove(request), WTFMove(fetchOptions), contentSecurityPolicyEnforcement, ServiceWorkersMode::All, worker.get());
124
120
    return worker;
125
    return worker;
121
}
126
}
122
127
Lines 215-221 void Worker::notifyFinished() a/Source/WebCore/workers/Worker.cpp_sec3
215
    ReferrerPolicy referrerPolicy = ReferrerPolicy::EmptyString;
220
    ReferrerPolicy referrerPolicy = ReferrerPolicy::EmptyString;
216
    if (auto policy = parseReferrerPolicy(m_scriptLoader->referrerPolicy(), ReferrerPolicySource::HTTPHeader))
221
    if (auto policy = parseReferrerPolicy(m_scriptLoader->referrerPolicy(), ReferrerPolicySource::HTTPHeader))
217
        referrerPolicy = *policy;
222
        referrerPolicy = *policy;
218
    m_contextProxy.startWorkerGlobalScope(m_scriptLoader->url(), m_name, context->userAgent(m_scriptLoader->url()), isOnline, m_scriptLoader->script(), contentSecurityPolicyResponseHeaders, m_shouldBypassMainWorldContentSecurityPolicy, m_workerCreationTime, referrerPolicy, m_runtimeFlags);
223
    m_contextProxy.startWorkerGlobalScope(m_scriptLoader->url(), m_name, context->userAgent(m_scriptLoader->url()), isOnline, m_scriptLoader->script(), contentSecurityPolicyResponseHeaders, m_shouldBypassMainWorldContentSecurityPolicy, m_workerCreationTime, referrerPolicy, m_type, m_credentials, m_runtimeFlags);
219
    InspectorInstrumentation::scriptImported(*context, m_scriptLoader->identifier(), m_scriptLoader->script());
224
    InspectorInstrumentation::scriptImported(*context, m_scriptLoader->identifier(), m_scriptLoader->script());
220
}
225
}
221
226
- a/Source/WebCore/workers/Worker.h +8 lines
Lines 29-37 a/Source/WebCore/workers/Worker.h_sec1
29
#include "ActiveDOMObject.h"
29
#include "ActiveDOMObject.h"
30
#include "ContentSecurityPolicyResponseHeaders.h"
30
#include "ContentSecurityPolicyResponseHeaders.h"
31
#include "EventTarget.h"
31
#include "EventTarget.h"
32
#include "FetchRequestCredentials.h"
32
#include "MessagePort.h"
33
#include "MessagePort.h"
33
#include "PostMessageOptions.h"
34
#include "PostMessageOptions.h"
34
#include "WorkerScriptLoaderClient.h"
35
#include "WorkerScriptLoaderClient.h"
36
#include "WorkerType.h"
35
#include <JavaScriptCore/RuntimeFlags.h>
37
#include <JavaScriptCore/RuntimeFlags.h>
36
#include <wtf/MonotonicTime.h>
38
#include <wtf/MonotonicTime.h>
37
#include <wtf/Optional.h>
39
#include <wtf/Optional.h>
Lines 55-60 class Worker final : public AbstractWorker, public ActiveDOMObject, private Work a/Source/WebCore/workers/Worker.h_sec2
55
    WTF_MAKE_ISO_ALLOCATED(Worker);
57
    WTF_MAKE_ISO_ALLOCATED(Worker);
56
public:
58
public:
57
    struct Options {
59
    struct Options {
60
        WorkerType type;
61
        FetchRequestCredentials credentials;
58
        String name;
62
        String name;
59
    };
63
    };
60
    static ExceptionOr<Ref<Worker>> create(ScriptExecutionContext&, JSC::RuntimeFlags, const String& url, const Options&);
64
    static ExceptionOr<Ref<Worker>> create(ScriptExecutionContext&, JSC::RuntimeFlags, const String& url, const Options&);
Lines 79-84 class Worker final : public AbstractWorker, public ActiveDOMObject, private Work a/Source/WebCore/workers/Worker.h_sec3
79
    void postTaskToWorkerGlobalScope(Function<void(ScriptExecutionContext&)>&&);
83
    void postTaskToWorkerGlobalScope(Function<void(ScriptExecutionContext&)>&&);
80
#endif
84
#endif
81
85
86
    WorkerType type() const { return m_type; }
87
82
private:
88
private:
83
    explicit Worker(ScriptExecutionContext&, JSC::RuntimeFlags, const Options&);
89
    explicit Worker(ScriptExecutionContext&, JSC::RuntimeFlags, const Options&);
84
90
Lines 112-117 class Worker final : public AbstractWorker, public ActiveDOMObject, private Work a/Source/WebCore/workers/Worker.h_sec4
112
#if ENABLE(WEB_RTC)
118
#if ENABLE(WEB_RTC)
113
    HashSet<String> m_transformers;
119
    HashSet<String> m_transformers;
114
#endif
120
#endif
121
    WorkerType m_type { WorkerType::Classic };
122
    FetchRequestCredentials m_credentials { FetchRequestCredentials::SameOrigin };
115
};
123
};
116
124
117
} // namespace WebCore
125
} // namespace WebCore
- a/Source/WebCore/workers/Worker.idl +2 lines
Lines 38-43 a/Source/WebCore/workers/Worker.idl_sec1
38
};
38
};
39
39
40
dictionary WorkerOptions {
40
dictionary WorkerOptions {
41
    WorkerType type = "classic";
42
    FetchRequestCredentials credentials = "same-origin"; // credentials is only used if type is "module"
41
    DOMString name = "";
43
    DOMString name = "";
42
};
44
};
43
45
- a/Source/WebCore/workers/WorkerGlobalScope.h -2 lines
Lines 163-170 class WorkerGlobalScope : public Supplementable<WorkerGlobalScope>, public Base6 a/Source/WebCore/workers/WorkerGlobalScope.h_sec1
163
    mutable RefPtr<WorkerLocation> m_location;
163
    mutable RefPtr<WorkerLocation> m_location;
164
    mutable RefPtr<WorkerNavigator> m_navigator;
164
    mutable RefPtr<WorkerNavigator> m_navigator;
165
165
166
    std::unique_ptr<WorkerOrWorkletScriptController> m_script;
167
168
    bool m_isOnline;
166
    bool m_isOnline;
169
    bool m_shouldBypassMainWorldContentSecurityPolicy;
167
    bool m_shouldBypassMainWorldContentSecurityPolicy;
170
168
- a/Source/WebCore/workers/WorkerGlobalScopeProxy.h -1 / +1 lines
Lines 48-54 class WorkerGlobalScopeProxy { a/Source/WebCore/workers/WorkerGlobalScopeProxy.h_sec1
48
public:
48
public:
49
    static WorkerGlobalScopeProxy& create(Worker&);
49
    static WorkerGlobalScopeProxy& create(Worker&);
50
50
51
    virtual void startWorkerGlobalScope(const URL& scriptURL, const String& name, const String& userAgent, bool isOnline, const String& sourceCode, const ContentSecurityPolicyResponseHeaders&, bool shouldBypassMainWorldContentSecurityPolicy, MonotonicTime timeOrigin, ReferrerPolicy, JSC::RuntimeFlags) = 0;
51
    virtual void startWorkerGlobalScope(const URL& scriptURL, const String& name, const String& userAgent, bool isOnline, const String& sourceCode, const ContentSecurityPolicyResponseHeaders&, bool shouldBypassMainWorldContentSecurityPolicy, MonotonicTime timeOrigin, ReferrerPolicy, WorkerType workerType, FetchRequestCredentials credentials, JSC::RuntimeFlags) = 0;
52
    virtual void terminateWorkerGlobalScope() = 0;
52
    virtual void terminateWorkerGlobalScope() = 0;
53
    virtual void postMessageToWorkerGlobalScope(MessageWithMessagePorts&&) = 0;
53
    virtual void postMessageToWorkerGlobalScope(MessageWithMessagePorts&&) = 0;
54
    virtual void postTaskToWorkerGlobalScope(Function<void(ScriptExecutionContext&)>&&) = 0;
54
    virtual void postTaskToWorkerGlobalScope(Function<void(ScriptExecutionContext&)>&&) = 0;
- a/Source/WebCore/workers/WorkerMessagingProxy.cpp -2 / +2 lines
Lines 73-79 WorkerMessagingProxy::~WorkerMessagingProxy() a/Source/WebCore/workers/WorkerMessagingProxy.cpp_sec1
73
        || (is<WorkerGlobalScope>(*m_scriptExecutionContext) && downcast<WorkerGlobalScope>(*m_scriptExecutionContext).thread().thread() == &Thread::current()));
73
        || (is<WorkerGlobalScope>(*m_scriptExecutionContext) && downcast<WorkerGlobalScope>(*m_scriptExecutionContext).thread().thread() == &Thread::current()));
74
}
74
}
75
75
76
void WorkerMessagingProxy::startWorkerGlobalScope(const URL& scriptURL, const String& name, const String& userAgent, bool isOnline, const String& sourceCode, const ContentSecurityPolicyResponseHeaders& contentSecurityPolicyResponseHeaders, bool shouldBypassMainWorldContentSecurityPolicy, MonotonicTime timeOrigin, ReferrerPolicy referrerPolicy, JSC::RuntimeFlags runtimeFlags)
76
void WorkerMessagingProxy::startWorkerGlobalScope(const URL& scriptURL, const String& name, const String& userAgent, bool isOnline, const String& sourceCode, const ContentSecurityPolicyResponseHeaders& contentSecurityPolicyResponseHeaders, bool shouldBypassMainWorldContentSecurityPolicy, MonotonicTime timeOrigin, ReferrerPolicy referrerPolicy, WorkerType workerType, FetchRequestCredentials credentials, JSC::RuntimeFlags runtimeFlags)
77
{
77
{
78
    // FIXME: This need to be revisited when we support nested worker one day
78
    // FIXME: This need to be revisited when we support nested worker one day
79
    ASSERT(m_scriptExecutionContext);
79
    ASSERT(m_scriptExecutionContext);
Lines 89-95 void WorkerMessagingProxy::startWorkerGlobalScope(const URL& scriptURL, const St a/Source/WebCore/workers/WorkerMessagingProxy.cpp_sec2
89
89
90
    SocketProvider* socketProvider = document.socketProvider();
90
    SocketProvider* socketProvider = document.socketProvider();
91
91
92
    WorkerParameters params = { scriptURL, name, identifier, userAgent, isOnline, contentSecurityPolicyResponseHeaders, shouldBypassMainWorldContentSecurityPolicy, timeOrigin, referrerPolicy, document.settingsValues() };
92
    WorkerParameters params = { scriptURL, name, identifier, userAgent, isOnline, contentSecurityPolicyResponseHeaders, shouldBypassMainWorldContentSecurityPolicy, timeOrigin, referrerPolicy, workerType, credentials, document.settingsValues() };
93
    auto thread = DedicatedWorkerThread::create(params, sourceCode, *this, *this, *this, startMode, document.topOrigin(), proxy, socketProvider, runtimeFlags);
93
    auto thread = DedicatedWorkerThread::create(params, sourceCode, *this, *this, *this, startMode, document.topOrigin(), proxy, socketProvider, runtimeFlags);
94
94
95
    workerThreadCreated(thread.get());
95
    workerThreadCreated(thread.get());
- a/Source/WebCore/workers/WorkerMessagingProxy.h -1 / +1 lines
Lines 50-56 class WorkerMessagingProxy final : public ThreadSafeRefCounted<WorkerMessagingPr a/Source/WebCore/workers/WorkerMessagingProxy.h_sec1
50
private:
50
private:
51
    // Implementations of WorkerGlobalScopeProxy.
51
    // Implementations of WorkerGlobalScopeProxy.
52
    // (Only use these functions in the worker object thread.)
52
    // (Only use these functions in the worker object thread.)
53
    void startWorkerGlobalScope(const URL& scriptURL, const String& name, const String& userAgent, bool isOnline, const String& sourceCode, const ContentSecurityPolicyResponseHeaders&, bool shouldBypassMainWorldContentSecurityPolicy, MonotonicTime timeOrigin, ReferrerPolicy, JSC::RuntimeFlags) final;
53
    void startWorkerGlobalScope(const URL& scriptURL, const String& name, const String& userAgent, bool isOnline, const String& sourceCode, const ContentSecurityPolicyResponseHeaders&, bool shouldBypassMainWorldContentSecurityPolicy, MonotonicTime timeOrigin, ReferrerPolicy, WorkerType workerType, FetchRequestCredentials credentials, JSC::RuntimeFlags) final;
54
    void terminateWorkerGlobalScope() final;
54
    void terminateWorkerGlobalScope() final;
55
    void postMessageToWorkerGlobalScope(MessageWithMessagePorts&&) final;
55
    void postMessageToWorkerGlobalScope(MessageWithMessagePorts&&) final;
56
    void postTaskToWorkerGlobalScope(Function<void(ScriptExecutionContext&)>&&) final;
56
    void postTaskToWorkerGlobalScope(Function<void(ScriptExecutionContext&)>&&) final;
- a/Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp +2 lines
Lines 26-31 a/Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp_sec1
26
#include "config.h"
26
#include "config.h"
27
#include "WorkerOrWorkletGlobalScope.h"
27
#include "WorkerOrWorkletGlobalScope.h"
28
28
29
#include "ScriptModuleLoader.h"
29
#include "WorkerEventLoop.h"
30
#include "WorkerEventLoop.h"
30
#include "WorkerInspectorController.h"
31
#include "WorkerInspectorController.h"
31
#include "WorkerOrWorkletScriptController.h"
32
#include "WorkerOrWorkletScriptController.h"
Lines 39-44 WTF_MAKE_ISO_ALLOCATED_IMPL(WorkerOrWorkletGlobalScope); a/Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp_sec2
39
40
40
WorkerOrWorkletGlobalScope::WorkerOrWorkletGlobalScope(WorkerThreadType type, Ref<JSC::VM>&& vm, WorkerOrWorkletThread* thread)
41
WorkerOrWorkletGlobalScope::WorkerOrWorkletGlobalScope(WorkerThreadType type, Ref<JSC::VM>&& vm, WorkerOrWorkletThread* thread)
41
    : m_script(makeUnique<WorkerOrWorkletScriptController>(type, WTFMove(vm), this))
42
    : m_script(makeUnique<WorkerOrWorkletScriptController>(type, WTFMove(vm), this))
43
    , m_moduleLoader(makeUnique<ScriptModuleLoader>(*this, ScriptModuleLoader::OwnerType::WorkerOrWorklet))
42
    , m_thread(thread)
44
    , m_thread(thread)
43
    , m_inspectorController(makeUnique<WorkerInspectorController>(*this))
45
    , m_inspectorController(makeUnique<WorkerInspectorController>(*this))
44
{
46
{
- a/Source/WebCore/workers/WorkerOrWorkletGlobalScope.h +4 lines
Lines 32-37 a/Source/WebCore/workers/WorkerOrWorkletGlobalScope.h_sec1
32
namespace WebCore {
32
namespace WebCore {
33
33
34
class EventLoopTaskGroup;
34
class EventLoopTaskGroup;
35
class ScriptModuleLoader;
35
class WorkerEventLoop;
36
class WorkerEventLoop;
36
class WorkerInspectorController;
37
class WorkerInspectorController;
37
class WorkerOrWorkletScriptController;
38
class WorkerOrWorkletScriptController;
Lines 54-59 class WorkerOrWorkletGlobalScope : public ScriptExecutionContext, public RefCoun a/Source/WebCore/workers/WorkerOrWorkletGlobalScope.h_sec2
54
55
55
    unsigned long createUniqueIdentifier() { return m_uniqueIdentifier++; }
56
    unsigned long createUniqueIdentifier() { return m_uniqueIdentifier++; }
56
57
58
    ScriptModuleLoader& moduleLoader() { return *m_moduleLoader; }
59
57
    // ScriptExecutionContext.
60
    // ScriptExecutionContext.
58
    EventLoopTaskGroup& eventLoop() final;
61
    EventLoopTaskGroup& eventLoop() final;
59
    bool isContextThread() const final;
62
    bool isContextThread() const final;
Lines 88-93 class WorkerOrWorkletGlobalScope : public ScriptExecutionContext, public RefCoun a/Source/WebCore/workers/WorkerOrWorkletGlobalScope.h_sec3
88
    void derefEventTarget() final { deref(); }
91
    void derefEventTarget() final { deref(); }
89
92
90
    std::unique_ptr<WorkerOrWorkletScriptController> m_script;
93
    std::unique_ptr<WorkerOrWorkletScriptController> m_script;
94
    std::unique_ptr<ScriptModuleLoader> m_moduleLoader;
91
    WorkerOrWorkletThread* m_thread;
95
    WorkerOrWorkletThread* m_thread;
92
    RefPtr<WorkerEventLoop> m_eventLoop;
96
    RefPtr<WorkerEventLoop> m_eventLoop;
93
    std::unique_ptr<EventLoopTaskGroup> m_defaultTaskGroup;
97
    std::unique_ptr<EventLoopTaskGroup> m_defaultTaskGroup;
- a/Source/WebCore/workers/WorkerOrWorkletScriptController.cpp -1 / +137 lines
Lines 35-40 a/Source/WebCore/workers/WorkerOrWorkletScriptController.cpp_sec1
35
#include "JSExecState.h"
35
#include "JSExecState.h"
36
#include "JSPaintWorkletGlobalScope.h"
36
#include "JSPaintWorkletGlobalScope.h"
37
#include "JSServiceWorkerGlobalScope.h"
37
#include "JSServiceWorkerGlobalScope.h"
38
#include "LoadableModuleScript.h"
39
#include "ModuleFetchFailureKind.h"
40
#include "ModuleFetchParameters.h"
38
#include "ScriptSourceCode.h"
41
#include "ScriptSourceCode.h"
39
#include "WebCoreJSClientData.h"
42
#include "WebCoreJSClientData.h"
40
#include "WorkerConsoleClient.h"
43
#include "WorkerConsoleClient.h"
Lines 43-49 a/Source/WebCore/workers/WorkerOrWorkletScriptController.cpp_sec2
43
#include <JavaScriptCore/Exception.h>
46
#include <JavaScriptCore/Exception.h>
44
#include <JavaScriptCore/ExceptionHelpers.h>
47
#include <JavaScriptCore/ExceptionHelpers.h>
45
#include <JavaScriptCore/GCActivityCallback.h>
48
#include <JavaScriptCore/GCActivityCallback.h>
49
#include <JavaScriptCore/JSInternalPromise.h>
46
#include <JavaScriptCore/JSLock.h>
50
#include <JavaScriptCore/JSLock.h>
51
#include <JavaScriptCore/JSModuleRecord.h>
52
#include <JavaScriptCore/JSNativeStdFunction.h>
53
#include <JavaScriptCore/JSScriptFetchParameters.h>
54
#include <JavaScriptCore/JSScriptFetcher.h>
47
#include <JavaScriptCore/StrongInlines.h>
55
#include <JavaScriptCore/StrongInlines.h>
48
56
49
namespace WebCore {
57
namespace WebCore {
Lines 228-234 void WorkerOrWorkletScriptController::evaluate(const ScriptSourceCode& sourceCod a/Source/WebCore/workers/WorkerOrWorkletScriptController.cpp_sec3
228
    }
236
    }
229
}
237
}
230
238
231
template<typename JSGlobalScopePrototype, typename JSGlobalScope, typename GlobalScope>
239
static Identifier jsValueToModuleKey(JSGlobalObject* lexicalGlobalObject, JSValue value)
240
{
241
    if (value.isSymbol())
242
        return Identifier::fromUid(jsCast<Symbol*>(value)->privateName());
243
    ASSERT(value.isString());
244
    return asString(value)->toIdentifier(lexicalGlobalObject);
245
}
246
247
JSC::JSValue WorkerOrWorkletScriptController::evaluateModule(JSC::JSModuleRecord& moduleRecord)
248
{
249
    auto& globalObject = *m_globalScopeWrapper.get();
250
    VM& vm = globalObject.vm();
251
    JSLockHolder lock { vm };
252
    return moduleRecord.evaluate(&globalObject);
253
}
254
255
MessageQueueWaitResult WorkerOrWorkletScriptController::loadModuleSynchronously(LoadableModuleScript& moduleScript, const ScriptSourceCode& sourceCode)
256
{
257
    if (isExecutionForbidden())
258
        return MessageQueueTerminated;
259
260
    initScriptIfNeeded();
261
262
    auto& globalObject = *m_globalScopeWrapper.get();
263
    VM& vm = globalObject.vm();
264
    JSLockHolder lock { vm };
265
266
    RefPtr<LoadableModuleScript> moduleScriptRef;
267
    {
268
        auto& promise = JSExecState::loadModule(globalObject, sourceCode.jsSourceCode(), JSC::JSScriptFetcher::create(vm, { &moduleScript }));
269
270
        moduleScriptRef = &moduleScript;
271
272
        auto& fulfillHandler = *JSNativeStdFunction::create(vm, &globalObject, 1, String(), [moduleScriptRef](JSGlobalObject* globalObject, CallFrame* callFrame) -> JSC::EncodedJSValue {
273
            VM& vm = globalObject->vm();
274
            auto scope = DECLARE_THROW_SCOPE(vm);
275
            Identifier moduleKey = jsValueToModuleKey(globalObject, callFrame->argument(0));
276
            RETURN_IF_EXCEPTION(scope, { });
277
            moduleScriptRef->notifyLoadCompleted(*moduleKey.impl());
278
            return JSValue::encode(jsUndefined());
279
        });
280
281
        auto& rejectHandler = *JSNativeStdFunction::create(vm, &globalObject, 1, String(), [moduleScriptRef](JSGlobalObject* globalObject, CallFrame* callFrame) {
282
            VM& vm = globalObject->vm();
283
            JSValue errorValue = callFrame->argument(0);
284
            if (errorValue.isObject()) {
285
                auto* object = JSC::asObject(errorValue);
286
                if (JSValue failureKindValue = object->getDirect(vm, static_cast<JSVMClientData&>(*vm.clientData).builtinNames().failureKindPrivateName())) {
287
                    // This is host propagated error in the module loader pipeline.
288
                    switch (static_cast<ModuleFetchFailureKind>(failureKindValue.asInt32())) {
289
                    case ModuleFetchFailureKind::WasErrored:
290
                        moduleScriptRef->notifyLoadFailed(LoadableScript::Error {
291
                            LoadableScript::ErrorType::CachedScript,
292
                            WTF::nullopt
293
                        });
294
                        break;
295
                    case ModuleFetchFailureKind::WasCanceled:
296
                        moduleScriptRef->notifyLoadWasCanceled();
297
                        break;
298
                    }
299
                    return JSValue::encode(jsUndefined());
300
                }
301
            }
302
303
            auto scope = DECLARE_CATCH_SCOPE(vm);
304
            moduleScriptRef->notifyLoadFailed(LoadableScript::Error {
305
                LoadableScript::ErrorType::CachedScript,
306
                LoadableScript::ConsoleMessage {
307
                    MessageSource::JS,
308
                    MessageLevel::Error,
309
                    retrieveErrorMessage(*globalObject, vm, errorValue, scope),
310
                }
311
            });
312
            return JSValue::encode(jsUndefined());
313
        });
314
315
        promise.then(&globalObject, &fulfillHandler, &rejectHandler);
316
    }
317
    m_globalScope->eventLoop().performMicrotaskCheckpoint();
318
319
    // Drive RunLoop until we get either of "Worker is terminated", "Loading is done", or "Loading is failed".
320
    WorkerRunLoop& runLoop = m_globalScope->workerOrWorkletThread()->runLoop();
321
322
    MessageQueueWaitResult result = MessageQueueMessageReceived;
323
    while ((!moduleScriptRef->isLoaded() && !moduleScriptRef->wasCanceled()) && result != MessageQueueTerminated)
324
        result = runLoop.runInMode(m_globalScope, WorkerRunLoop::defaultMode());
325
326
    // FIXME: Currently we are not offering cancelling.
327
    // if (!loader->done() && result == MessageQueueTerminated)
328
    //     loader->cancel();
329
330
    return result;
331
}
332
333
void WorkerOrWorkletScriptController::linkAndEvaluateModule(LoadableModuleScript& moduleScript, const ScriptSourceCode& sourceCode, String* returnedExceptionMessage)
334
{
335
    if (isExecutionForbidden())
336
        return;
337
338
    initScriptIfNeeded();
339
340
    auto& globalObject = *m_globalScopeWrapper.get();
341
    VM& vm = globalObject.vm();
342
    JSLockHolder lock { vm };
343
344
    NakedPtr<JSC::Exception> returnedException;
345
    JSExecState::linkAndEvaluateModule(globalObject, Identifier::fromUid(vm, moduleScript.moduleKey()), jsUndefined(), returnedException);
346
    if ((returnedException && isTerminatedExecutionException(vm, returnedException)) || isTerminatingExecution()) {
347
        forbidExecution();
348
        return;
349
    }
350
351
    if (returnedException) {
352
        if (m_globalScope->canIncludeErrorDetails(sourceCode.cachedScript(), sourceCode.url().string())) {
353
            // FIXME: It's not great that this can run arbitrary code to string-ify the value of the exception.
354
            // Do we need to do anything to handle that properly, if it, say, raises another exception?
355
            if (returnedExceptionMessage)
356
                *returnedExceptionMessage = returnedException->value().toWTFString(&globalObject);
357
        } else {
358
            // Overwrite the detailed error with a generic error.
359
            String genericErrorMessage { "Script error."_s };
360
            if (returnedExceptionMessage)
361
                *returnedExceptionMessage = genericErrorMessage;
362
            returnedException = JSC::Exception::create(vm, createError(&globalObject, genericErrorMessage));
363
        }
364
    }
365
}
366
367
    template<typename JSGlobalScopePrototype, typename JSGlobalScope, typename GlobalScope>
232
void WorkerOrWorkletScriptController::initScriptWithSubclass()
368
void WorkerOrWorkletScriptController::initScriptWithSubclass()
233
{
369
{
234
    ASSERT(!m_globalScopeWrapper);
370
    ASSERT(!m_globalScopeWrapper);
- a/Source/WebCore/workers/WorkerOrWorkletScriptController.h +7 lines
Lines 31-36 a/Source/WebCore/workers/WorkerOrWorkletScriptController.h_sec1
31
#include <JavaScriptCore/JSRunLoopTimer.h>
31
#include <JavaScriptCore/JSRunLoopTimer.h>
32
#include <wtf/Forward.h>
32
#include <wtf/Forward.h>
33
#include <wtf/Lock.h>
33
#include <wtf/Lock.h>
34
#include <wtf/MessageQueue.h>
34
#include <wtf/NakedPtr.h>
35
#include <wtf/NakedPtr.h>
35
36
36
namespace JSC {
37
namespace JSC {
Lines 44-49 class JSGlobalObject; a/Source/WebCore/workers/WorkerOrWorkletScriptController.h_sec2
44
namespace WebCore {
45
namespace WebCore {
45
46
46
class JSDOMGlobalObject;
47
class JSDOMGlobalObject;
48
class LoadableModuleScript;
47
class ScriptSourceCode;
49
class ScriptSourceCode;
48
class WorkerConsoleClient;
50
class WorkerConsoleClient;
49
class WorkerOrWorkletGlobalScope;
51
class WorkerOrWorkletGlobalScope;
Lines 94-99 class WorkerOrWorkletScriptController { a/Source/WebCore/workers/WorkerOrWorkletScriptController.h_sec3
94
    void evaluate(const ScriptSourceCode&, String* returnedExceptionMessage = nullptr);
96
    void evaluate(const ScriptSourceCode&, String* returnedExceptionMessage = nullptr);
95
    void evaluate(const ScriptSourceCode&, NakedPtr<JSC::Exception>& returnedException, String* returnedExceptionMessage = nullptr);
97
    void evaluate(const ScriptSourceCode&, NakedPtr<JSC::Exception>& returnedException, String* returnedExceptionMessage = nullptr);
96
98
99
    JSC::JSValue evaluateModule(JSC::JSModuleRecord&);
100
101
    void linkAndEvaluateModule(LoadableModuleScript&, const ScriptSourceCode& sourceCode, String* returnedExceptionMessage = nullptr);
102
    MessageQueueWaitResult loadModuleSynchronously(LoadableModuleScript&, const ScriptSourceCode&);
103
97
protected:
104
protected:
98
    WorkerOrWorkletGlobalScope* globalScope() const { return m_globalScope; }
105
    WorkerOrWorkletGlobalScope* globalScope() const { return m_globalScope; }
99
106
- a/Source/WebCore/workers/WorkerThread.cpp -3 / +31 lines
Lines 28-37 a/Source/WebCore/workers/WorkerThread.cpp_sec1
28
#include "WorkerThread.h"
28
#include "WorkerThread.h"
29
29
30
#include "IDBConnectionProxy.h"
30
#include "IDBConnectionProxy.h"
31
#include "LoadableModuleScript.h"
31
#include "ScriptSourceCode.h"
32
#include "ScriptSourceCode.h"
32
#include "SecurityOrigin.h"
33
#include "SecurityOrigin.h"
33
#include "SocketProvider.h"
34
#include "SocketProvider.h"
34
#include "WorkerGlobalScope.h"
35
#include "WorkerGlobalScope.h"
36
#include <JavaScriptCore/ScriptCallStack.h>
35
#include <wtf/Threading.h>
37
#include <wtf/Threading.h>
36
38
37
namespace WebCore {
39
namespace WebCore {
Lines 55-60 WorkerParameters WorkerParameters::isolatedCopy() const a/Source/WebCore/workers/WorkerThread.cpp_sec2
55
        shouldBypassMainWorldContentSecurityPolicy,
57
        shouldBypassMainWorldContentSecurityPolicy,
56
        timeOrigin,
58
        timeOrigin,
57
        referrerPolicy,
59
        referrerPolicy,
60
        workerType,
61
        credentials,
58
        settingsValues.isolatedCopy()
62
        settingsValues.isolatedCopy()
59
    };
63
    };
60
}
64
}
Lines 123-131 bool WorkerThread::shouldWaitForWebInspectorOnStartup() const a/Source/WebCore/workers/WorkerThread.cpp_sec3
123
127
124
void WorkerThread::evaluateScriptIfNecessary(String& exceptionMessage)
128
void WorkerThread::evaluateScriptIfNecessary(String& exceptionMessage)
125
{
129
{
126
    globalScope()->script()->evaluate(ScriptSourceCode(m_startupData->sourceCode, URL(m_startupData->params.scriptURL)), &exceptionMessage);
130
    // We are currently holding only the initial script code. If the WorkerType is Module, we should fetch the entire graph before executing the rest of this.
127
131
    // We invoke module loader as if we are executing inline module script tag in Document.
128
    finishedEvaluatingScript();
132
133
    if (m_startupData->params.workerType == WorkerType::Classic) {
134
        globalScope()->script()->evaluate(ScriptSourceCode(m_startupData->sourceCode, URL(m_startupData->params.scriptURL)), &exceptionMessage);
135
        finishedEvaluatingScript();
136
    } else {
137
        // FIXME crossOrigin mode should be converted.
138
        // FIXME fix initiator name.
139
        // FIXME pass URL to module loader.
140
        ScriptSourceCode sourceCode(m_startupData->sourceCode, URL(m_startupData->params.scriptURL), { }, JSC::SourceProviderSourceType::Module);
141
        auto moduleScript = LoadableModuleScript::create(emptyString(), emptyString(), m_startupData->params.referrerPolicy, ScriptElementCachedScriptFetcher::defaultCrossOriginModeForModule, emptyString(), emptyAtom(), false);
142
        MessageQueueWaitResult result = globalScope()->script()->loadModuleSynchronously(moduleScript.get(), sourceCode);
143
        if (result != MessageQueueTerminated) {
144
            if (Optional<LoadableScript::Error> error = moduleScript->error()) {
145
                if (Optional<LoadableScript::ConsoleMessage> message = error->consoleMessage)
146
                    exceptionMessage = message->message;
147
                else
148
                    exceptionMessage = "Importing a module script failed."_s;
149
                globalScope()->reportException(exceptionMessage, { }, { }, { }, { }, { });
150
            } else if (!moduleScript->wasCanceled()) {
151
                // Evaluate.
152
                globalScope()->script()->linkAndEvaluateModule(moduleScript.get(), sourceCode, &exceptionMessage);
153
                finishedEvaluatingScript();
154
            }
155
        }
156
    }
129
157
130
    // Free the startup data to cause its member variable deref's happen on the worker's thread (since
158
    // Free the startup data to cause its member variable deref's happen on the worker's thread (since
131
    // all ref/derefs of these objects are happening on the thread at this point). Note that
159
    // all ref/derefs of these objects are happening on the thread at this point). Note that
- a/Source/WebCore/workers/WorkerThread.h +5 lines
Lines 26-32 a/Source/WebCore/workers/WorkerThread.h_sec1
26
#pragma once
26
#pragma once
27
27
28
#include "ContentSecurityPolicyResponseHeaders.h"
28
#include "ContentSecurityPolicyResponseHeaders.h"
29
#include "FetchRequestCredentials.h"
29
#include "WorkerOrWorkletThread.h"
30
#include "WorkerOrWorkletThread.h"
31
#include "WorkerRunLoop.h"
32
#include "WorkerType.h"
30
#include <JavaScriptCore/RuntimeFlags.h>
33
#include <JavaScriptCore/RuntimeFlags.h>
31
#include <memory>
34
#include <memory>
32
#include <wtf/URL.h>
35
#include <wtf/URL.h>
Lines 63-68 struct WorkerParameters { a/Source/WebCore/workers/WorkerThread.h_sec2
63
    bool shouldBypassMainWorldContentSecurityPolicy;
66
    bool shouldBypassMainWorldContentSecurityPolicy;
64
    MonotonicTime timeOrigin;
67
    MonotonicTime timeOrigin;
65
    ReferrerPolicy referrerPolicy;
68
    ReferrerPolicy referrerPolicy;
69
    WorkerType workerType;
70
    FetchRequestCredentials credentials;
66
    Settings::Values settingsValues;
71
    Settings::Values settingsValues;
67
72
68
    WorkerParameters isolatedCopy() const;
73
    WorkerParameters isolatedCopy() const;
- a/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp -1 / +2 lines
Lines 73-80 class DummyServiceWorkerThreadProxy : public WorkerObjectProxy { a/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp_sec1
73
// FIXME: Use a valid WorkerObjectProxy
73
// FIXME: Use a valid WorkerObjectProxy
74
// FIXME: Use valid runtime flags
74
// FIXME: Use valid runtime flags
75
75
76
// FIXME: Use a valid WorkerType and Credentails for module service workers.
76
ServiceWorkerThread::ServiceWorkerThread(const ServiceWorkerContextData& data, String&& userAgent, const Settings::Values& settingsValues, WorkerLoaderProxy& loaderProxy, WorkerDebuggerProxy& debuggerProxy, IDBClient::IDBConnectionProxy* idbConnectionProxy, SocketProvider* socketProvider)
77
ServiceWorkerThread::ServiceWorkerThread(const ServiceWorkerContextData& data, String&& userAgent, const Settings::Values& settingsValues, WorkerLoaderProxy& loaderProxy, WorkerDebuggerProxy& debuggerProxy, IDBClient::IDBConnectionProxy* idbConnectionProxy, SocketProvider* socketProvider)
77
    : WorkerThread({ data.scriptURL, emptyString(), "serviceworker:" + Inspector::IdentifiersFactory::createIdentifier(), WTFMove(userAgent), platformStrategies()->loaderStrategy()->isOnLine(), data.contentSecurityPolicy, false, MonotonicTime::now(), { }, settingsValues }, data.script, loaderProxy, debuggerProxy, DummyServiceWorkerThreadProxy::shared(), WorkerThreadStartMode::Normal, data.registration.key.topOrigin().securityOrigin().get(), idbConnectionProxy, socketProvider, JSC::RuntimeFlags::createAllEnabled())
78
    : WorkerThread({ data.scriptURL, emptyString(), "serviceworker:" + Inspector::IdentifiersFactory::createIdentifier(), WTFMove(userAgent), platformStrategies()->loaderStrategy()->isOnLine(), data.contentSecurityPolicy, false, MonotonicTime::now(), { }, WorkerType::Classic, FetchRequestCredentials::SameOrigin, settingsValues }, data.script, loaderProxy, debuggerProxy, DummyServiceWorkerThreadProxy::shared(), WorkerThreadStartMode::Normal, data.registration.key.topOrigin().securityOrigin().get(), idbConnectionProxy, socketProvider, JSC::RuntimeFlags::createAllEnabled())
78
    , m_data(data.isolatedCopy())
79
    , m_data(data.isolatedCopy())
79
    , m_workerObjectProxy(DummyServiceWorkerThreadProxy::shared())
80
    , m_workerObjectProxy(DummyServiceWorkerThreadProxy::shared())
80
    , m_heartBeatTimeout(SWContextManager::singleton().connection()->shouldUseShortTimeout() ? heartBeatTimeoutForTest : heartBeatTimeout)
81
    , m_heartBeatTimeout(SWContextManager::singleton().connection()->shouldUseShortTimeout() ? heartBeatTimeoutForTest : heartBeatTimeout)
- a/LayoutTests/imported/w3c/ChangeLog +11 lines
Lines 1-3 a/LayoutTests/imported/w3c/ChangeLog_sec1
1
2021-02-10  Yusuke Suzuki  <ysuzuki@apple.com>
2
3
        JS Modules in Workers
4
        https://bugs.webkit.org/show_bug.cgi?id=164860
5
6
        Reviewed by NOBODY (OOPS!).
7
8
        * web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-1-nothrow-worker-expected.txt:
9
        * web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-3-dynamic-worker-expected.txt:
10
        * web-platform-tests/workers/modules/dedicated-worker-options-type-expected.txt:
11
1
2021-02-06  Alex Christensen  <achristensen@webkit.org>
12
2021-02-06  Alex Christensen  <achristensen@webkit.org>
2
13
3
        Non-special URLs should have an opaque origin
14
        Non-special URLs should have an opaque origin
- a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-1-nothrow-worker-expected.txt -2 / +1 lines
Lines 1-4 a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-1-nothrow-worker-expected.txt_sec1
1
1
2
Harness Error (TIMEOUT), message = null
2
PASS Test evaluation order of modules
3
4
3
- a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-3-dynamic-worker-expected.txt -2 / +1 lines
Lines 1-4 a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-3-dynamic-worker-expected.txt_sec1
1
1
2
Harness Error (TIMEOUT), message = null
2
PASS Test evaluation order of modules
3
4
3
- a/LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-options-type-expected.txt -7 / +2 lines
Lines 2-12 a/LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-options-type-expected.txt_sec1
2
PASS Test worker construction with the default worker type.
2
PASS Test worker construction with the default worker type.
3
PASS Test worker construction with the "classic" worker type.
3
PASS Test worker construction with the "classic" worker type.
4
PASS Test worker construction with the "module" worker type.
4
PASS Test worker construction with the "module" worker type.
5
FAIL Test worker construction with an empty worker type. assert_throws_js: Worker construction with an empty type should throw an exception function "() => {
5
PASS Test worker construction with an empty worker type.
6
        new Worker('resources/post-message-on-load-worker.js', { type: '' });
6
PASS Test worker construction with an unknown worker type.
7
      }" did not throw
8
FAIL Test worker construction with an unknown worker type. assert_throws_js: Worker construction with an unknown type should throw an exception function "() => {
9
        new Worker('resources/post-message-on-load-worker.js',
10
                   { type: 'unknown' });
11
      }" did not throw
12
7

Return to Bug 164860