feat: Add support for PSC network connections #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enocom
requested changes
Jul 6, 2023
core/src/test/java/com/google/cloud/sql/core/SqlAdminApiFetcherTest.java
Outdated
Show resolved
Hide resolved
enocom
approved these changes
Jul 11, 2023
| @@ -207,6 +207,11 @@ private Metadata fetchMetadata(CloudSqlInstanceName instanceName, AuthType authT | |||
| ipAddrs.put(addr.getType(), addr.getIpAddress()); | |||
| } | |||
|
|
|||
| // resolve DnsName into IP address for PSC | |||
| if (instanceMetadata.getDnsName() != null && !instanceMetadata.getDnsName().isEmpty()) { | |||
| ipAddrs.put("PSC", instanceMetadata.getDnsName()); | |||
There was a problem hiding this comment.
nit: Making "PSC" a constant would be nice.
|
This was successfully hand-tested. The java connector successfully connected to a PSC database when |
enocom
approved these changes
Jul 11, 2023
hessjcg
commented
Jul 11, 2023
| } | ||
|
|
||
| @Test | ||
| public void testFetchInstanceData_returnsPscForNonIpDatabase() |
There was a problem hiding this comment.
This is the new test for PSC databases that have no IP address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.