Skip to content

Commit ec18c91

Browse files
committed
Remove View.getCoderInternal
1 parent df83ec3 commit ec18c91

File tree

3 files changed

+0
-24
lines changed

3 files changed

+0
-24
lines changed

sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -484,15 +484,6 @@ public TupleTag<Iterable<WindowedValue<?>>> getTagInternal() {
484484
return windowingStrategy;
485485
}
486486

487-
@Override
488-
public Coder<Iterable<WindowedValue<?>>> getCoderInternal() {
489-
// Safe cast: It is required that the rest of the SDK only use this untyped coder
490-
// for the elements of an appropriately typed underlying PCollection.
491-
@SuppressWarnings({"rawtypes", "unchecked"})
492-
Coder<Iterable<WindowedValue<?>>> untypedCoder = (Coder) coder;
493-
return untypedCoder;
494-
}
495-
496487
@Override
497488
public int hashCode() {
498489
return Objects.hash(tag);

sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionView.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
package org.apache.beam.sdk.values;
1919

2020
import java.io.Serializable;
21-
import org.apache.beam.sdk.coders.Coder;
2221
import org.apache.beam.sdk.transforms.ParDo;
2322
import org.apache.beam.sdk.transforms.View;
2423
import org.apache.beam.sdk.transforms.ViewFn;
@@ -67,12 +66,4 @@ public interface PCollectionView<T> extends PValue, Serializable {
6766
*/
6867
@Deprecated
6968
WindowingStrategy<?, ?> getWindowingStrategyInternal();
70-
71-
/**
72-
* @deprecated this method will be removed entirely. The {@link PCollection} underlying a side
73-
* input, including its {@link Coder}, is part of the side input's specification with a {@link
74-
* ParDo} transform, which will obtain that information via a package-private channel.
75-
*/
76-
@Deprecated
77-
Coder<Iterable<WindowedValue<?>>> getCoderInternal();
7869
}

sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PCollectionViewTesting.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -258,12 +258,6 @@ public ViewFn<Iterable<WindowedValue<?>>, ViewT> getViewFn() {
258258
return windowingStrategy;
259259
}
260260

261-
@SuppressWarnings({"unchecked", "rawtypes"})
262-
@Override
263-
public Coder<Iterable<WindowedValue<?>>> getCoderInternal() {
264-
return (Coder) coder;
265-
}
266-
267261
@Override
268262
public int hashCode() {
269263
return Objects.hash(tag);

0 commit comments

Comments
 (0)