[BEAM-65] Adds HasDefaultTracker for RestrictionTracker inference #2462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
tgroh
approved these changes
Apr 7, 2017
| @@ -85,8 +87,6 @@ | |||
| public static final String PROCESS_CONTEXT_PARAMETER_METHOD = "processContext"; | |||
| public static final String ON_TIMER_CONTEXT_PARAMETER_METHOD = "onTimerContext"; | |||
| public static final String WINDOW_PARAMETER_METHOD = "window"; | |||
| public static final String INPUT_PROVIDER_PARAMETER_METHOD = "inputProvider"; | |||
There was a problem hiding this comment.
This removal (although probably sane until we support it) doesn't seem related.
Allows a restriction type to implement HasDefaultTracker, in that case the splittable DoFn itself does not need to implement NewTracker - only ProcessElement and GetInitialRestriction.
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a restriction type to implement HasDefaultTracker, in that case the splittable DoFn itself does not need to implement NewTracker - only ProcessElement and GetInitialRestriction.
R: @tgroh
(this is less urgent to review than #2455 - just nice to have)