Skip to content

Commit ade1022

Browse files
fix: Resolving TODO to use the PSL futures executor (#514)
* fix: respect max messages per batch option * fix formatting * fix: use single subscriber service client * fix public method * fix: resolve todo * remove unused dep
1 parent 45c14fa commit ade1022

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/main/java/com/google/cloud/pubsublite/spark/internal/CachedPublishers.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,17 @@
1919
import com.google.api.core.ApiService;
2020
import com.google.cloud.pubsublite.MessageMetadata;
2121
import com.google.cloud.pubsublite.internal.Publisher;
22+
import com.google.cloud.pubsublite.internal.wire.SystemExecutors;
2223
import com.google.cloud.pubsublite.spark.PslWriteDataSourceOptions;
2324
import java.util.HashMap;
2425
import java.util.Map;
2526
import java.util.concurrent.Executor;
26-
import java.util.concurrent.Executors;
2727
import javax.annotation.concurrent.GuardedBy;
2828

2929
/** Cached {@link Publisher}s to reuse publisher of same settings in the same task. */
3030
public class CachedPublishers {
3131

32-
// TODO(jiangmichaellll): Use com.google.cloud.pubsublite.internal.wire.SystemExecutors
33-
// once new PSL client library is released.
34-
private final Executor listenerExecutor = Executors.newSingleThreadExecutor();
32+
private final Executor listenerExecutor = SystemExecutors.getFuturesExecutor();
3533

3634
@GuardedBy("this")
3735
private final Map<PslWriteDataSourceOptions, Publisher<MessageMetadata>> publishers =

0 commit comments

Comments
 (0)