Optimistic Next Edit Suggestions #222
Open
+166
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @ulugbekna, i'd appreciate your [& other code owners] insight on this. There are some kinks to iron out, but in my testing, this massively improves the UX of NES. some points for discussion: Optimistic NES will multiply the number of NES requests by 3, which may affect the rate limit/user allowance. |
ef9c8d9 to
24edf6a
Compare
|
@avarayr Thanks for the PR! We'll take a detailed look. We are also working on additional approaches to improve the experience while keeping the number of requests in check. (E.g., microsoft/vscode#255727 and microsoft/vscode#255728.) |
69b2edb to
89154be
Compare
- Add prefetch chain mechanism that triggers when edits are shown - Prefetch up to 3 edits deep to reduce latency for sequential edits - Integrate with existing NextEditCache infrastructure - Track active prefetches to avoid duplicates - Clean up resources on disposal
89154be to
f21a024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basis: Tab, Tab, Tab — Objects in motion want to stay in motion.
Summary
This PR implements optimistic prefetching for next edit suggestions, eliminating delay between accepting an edit and receiving the next suggestion by assuming that user will keep pressing tab to accept sequential edits.
Problem
Currently, when users accept an inline edit suggestion, there's a noticeable delay
before the next suggestion appears. This breaks the flow of rapid sequential edits.
Solution
Implement predictive fetching that anticipates user behavior based on the "objects in
motion stay in motion" principle. When a NES is shown, the system
immediately fetches the next edit in the background, assuming the user will continue
accepting suggestions.
All existing tests continue to pass.
Performance
Discussion
Optimistic NES will multiply the number of NES requests by 3, which may affect the rate limit/user allowance.