clearing a number input with invalid text, should actually clear it.

Fixes #1214

Author: lukeis

java/client/test/org/openqa/selenium/TypingTest.java

@@ -25,7 +25,6 @@
 import static org.junit.Assert.assertThat;
 import static org.junit.Assume.assumeFalse;
 import static org.openqa.selenium.WaitingConditions.elementValueToEqual;
-import static org.openqa.selenium.testing.Ignore.Driver.ALL;
 import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
 import static org.openqa.selenium.testing.Ignore.Driver.HTMLUNIT;
 import static org.openqa.selenium.testing.Ignore.Driver.IE;
@@ -781,6 +780,16 @@ public void canSafelyTypeOnElementThatIsRemovedFromTheDomOnKeyPress() {
     assertThat(getValueText(log), anyOf(equalTo(expected), equalTo(expected + "\nkeyup (body)")));
   }
 
+  @Test
+  public void canClearNumberInputAfterTypingInvalidInput() {
+    driver.get(pages.formPage);
+    WebElement input = driver.findElement(By.id("age"));
+    input.sendKeys("e");
+    input.clear();
+    input.sendKeys("3");
+    assertEquals("3", input.getAttribute("value"));
+  }
+
   private static String getValueText(WebElement el) {
     // Standardize on \n and strip any trailing whitespace.
     return el.getAttribute("value").replace("\r\n", "\n").trim();

javascript/atoms/action.js

@@ -91,6 +91,12 @@ bot.action.clear = function(element) {
   if (element.value) {
     element.value = '';
     bot.events.fire(element, bot.events.EventType.CHANGE);
+  } else if (bot.dom.isElement(element, goog.dom.TagName.INPUT) &&
+             element.getAttribute('type').toLowerCase() == "number") {
+    // number input fields that have invalid inputs
+    // report their value as empty string with no way to tell if there is a
+    // current value or not
+    element.value = '';
   }
 
   if (bot.dom.isContentEditable(element)) {