Skip to content

Commit 19184fe

Browse files
committed
rb - update specs with more race condition fixes
1 parent ef0f496 commit 19184fe

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

rb/spec/integration/selenium/webdriver/target_locator_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@
8282
driver.navigate.to url_for("xhtmlTest.html")
8383

8484
driver.find_element(:link, "Open new window").click
85+
wait.until { driver.window_handles.size == 2 }
8586
expect(driver.title).to eq("XHTML Test Page")
8687

8788
driver.switch_to.window(new_window) do
@@ -95,6 +96,7 @@
9596
driver.navigate.to url_for("xhtmlTest.html")
9697

9798
driver.find_element(:link, "Open new window").click
99+
wait.until { driver.window_handles.size == 2 }
98100
expect(driver.title).to eq("XHTML Test Page")
99101

100102
expect {
@@ -108,6 +110,7 @@
108110
driver.navigate.to url_for("xhtmlTest.html")
109111

110112
driver.find_element(:link, "Open new window").click
113+
wait.until { driver.window_handles.size == 2 }
111114
expect(driver.title).to eq("XHTML Test Page")
112115

113116
driver.switch_to.window(new_window)
@@ -120,6 +123,7 @@
120123
driver.navigate.to url_for("xhtmlTest.html")
121124

122125
driver.find_element(:link, "Open new window").click
126+
wait.until { driver.window_handles.size == 2 }
123127
expect(driver.title).to eq("XHTML Test Page")
124128

125129
driver.switch_to.window(new_window) do
@@ -147,7 +151,6 @@
147151
driver.find_element(:link, "Create a new anonymous window").click
148152
wait.until { driver.window_handles.size == 2 }
149153
driver.find_element(:link, "Open new window").click
150-
151154
wait.until { driver.window_handles.size == 3 }
152155

153156
driver.switch_to.window(driver.window_handle) {driver.close}
@@ -174,7 +177,6 @@
174177
driver.find_element(:link, "Create a new anonymous window").click
175178
wait.until { driver.window_handles.size == 2 }
176179
driver.find_element(:link, "Open new window").click
177-
178180
wait.until { driver.window_handles.size == 3 }
179181

180182
matching_window = driver.window_handles.find do |wh|
@@ -191,7 +193,6 @@
191193
driver.find_element(:link, "Create a new anonymous window").click
192194
wait.until { driver.window_handles.size == 2 }
193195
driver.find_element(:link, "Open new window").click
194-
195196
wait.until { driver.window_handles.size == 3 }
196197

197198
driver.close
@@ -211,7 +212,6 @@
211212
it "should switch to a window and execute a block when current window is closed" do
212213
driver.navigate.to url_for("xhtmlTest.html")
213214
driver.find_element(:link, "Open new window").click
214-
215215
wait.until { driver.window_handles.size == 2 }
216216

217217
driver.switch_to.window(new_window)

0 commit comments

Comments
 (0)