[dotnet] Fix error when we send non-base64 data for fetch command (#12431)

* Fix error when we send non-base64 data for fetch command

* Remove unnecessary playground

* Return back v114 in test

* Fire events asynchronously to avoid handlers which produce new pending task

* Use the latest cdp v115 in tests

---------

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

Author: nvborisenko

dotnet/src/webdriver/DevTools/DevToolsSession.cs

@@ -582,7 +582,10 @@ private void ProcessIncomingMessage(string message)
                 var eventData = messageObject["params"];
 
                 LogTrace("Recieved Event {0}: {1}", method, eventData.ToString());
-                OnDevToolsEventReceived(new DevToolsEventReceivedEventArgs(methodParts[0], methodParts[1], eventData));
+
+                // fire and forget
+                Task.Run(() => OnDevToolsEventReceived(new DevToolsEventReceivedEventArgs(methodParts[0], methodParts[1], eventData)));
+
                 return;
             }
 

dotnet/src/webdriver/DevTools/v113/V113Network.cs

@@ -142,7 +142,7 @@ public override async Task ContinueRequest(HttpRequestData requestData)
 
             if (!string.IsNullOrEmpty(requestData.PostData))
             {
-                commandSettings.PostData = requestData.PostData;
+                commandSettings.PostData = Convert.ToBase64String(Encoding.UTF8.GetBytes(requestData.PostData));
             }
 
             await fetch.ContinueRequest(commandSettings);

dotnet/src/webdriver/DevTools/v114/V114Network.cs

@@ -142,7 +142,7 @@ public override async Task ContinueRequest(HttpRequestData requestData)
 
             if (!string.IsNullOrEmpty(requestData.PostData))
             {
-                commandSettings.PostData = requestData.PostData;
+                commandSettings.PostData = Convert.ToBase64String(Encoding.UTF8.GetBytes(requestData.PostData));
             }
 
             await fetch.ContinueRequest(commandSettings);

dotnet/src/webdriver/DevTools/v115/V115Network.cs

@@ -142,7 +142,7 @@ public override async Task ContinueRequest(HttpRequestData requestData)
 
             if (!string.IsNullOrEmpty(requestData.PostData))
             {
-                commandSettings.PostData = requestData.PostData;
+                commandSettings.PostData = Convert.ToBase64String(Encoding.UTF8.GetBytes(requestData.PostData));
             }
 
             await fetch.ContinueRequest(commandSettings);
@@ -245,13 +245,16 @@ public override async Task AddResponseBody(HttpResponseData responseData)
             if (responseData.StatusCode < 300 || responseData.StatusCode > 399)
             {
                 var bodyResponse = await fetch.GetResponseBody(new Fetch.GetResponseBodyCommandSettings() { RequestId = responseData.RequestId });
-                if (bodyResponse.Base64Encoded)
+                if (bodyResponse != null)
                 {
-                    responseData.Body = Encoding.UTF8.GetString(Convert.FromBase64String(bodyResponse.Body));
-                }
-                else
-                {
-                    responseData.Body = bodyResponse.Body;
+                    if (bodyResponse.Base64Encoded)
+                    {
+                        responseData.Body = Encoding.UTF8.GetString(Convert.FromBase64String(bodyResponse.Body));
+                    }
+                    else
+                    {
+                        responseData.Body = bodyResponse.Body;
+                    }
                 }
             }
         }

dotnet/src/webdriver/DevTools/v85/V85Network.cs

@@ -142,7 +142,7 @@ public override async Task ContinueRequest(HttpRequestData requestData)
 
             if (!string.IsNullOrEmpty(requestData.PostData))
             {
-                commandSettings.PostData = requestData.PostData;
+                commandSettings.PostData = Convert.ToBase64String(Encoding.UTF8.GetBytes(requestData.PostData));
             }
 
             await fetch.ContinueRequest(commandSettings);

dotnet/test/common/DevTools/DevToolsConsoleTest.cs

@@ -1,14 +1,13 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 using NUnit.Framework;
 using OpenQA.Selenium.Environment;
 
 namespace OpenQA.Selenium.DevTools
 {
+    using CurrentCdpVersion = V115;
+
     [TestFixture]
     public class DevToolsConsoleTest : DevToolsTestFixture
     {
@@ -18,11 +17,11 @@ public class DevToolsConsoleTest : DevToolsTestFixture
         [IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
         public async Task VerifyMessageAdded()
         {
-            var domains = session.GetVersionSpecificDomains<V114.DevToolsSessionDomains>();
+            var domains = session.GetVersionSpecificDomains<CurrentCdpVersion.DevToolsSessionDomains>();
             string consoleMessage = "Hello Selenium";
 
             ManualResetEventSlim sync = new ManualResetEventSlim(false);
-            EventHandler<V114.Console.MessageAddedEventArgs> messageAddedHandler = (sender, e) =>
+            EventHandler<CurrentCdpVersion.Console.MessageAddedEventArgs> messageAddedHandler = (sender, e) =>
             {
                 Assert.That(e.Message.Text, Is.EqualTo(consoleMessage));
                 sync.Set();

dotnet/test/common/DevTools/DevToolsLogTest.cs

@@ -1,14 +1,13 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 using NUnit.Framework;
 using OpenQA.Selenium.Environment;
 
 namespace OpenQA.Selenium.DevTools
 {
+    using CurrentCdpVersion = V115;
+
     [TestFixture]
     public class DevToolsLogTest : DevToolsTestFixture
     {
@@ -19,12 +18,12 @@ public class DevToolsLogTest : DevToolsTestFixture
         [IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
         public async Task VerifyEntryAddedAndClearLog()
         {
-            var domains = session.GetVersionSpecificDomains<V114.DevToolsSessionDomains>();
+            var domains = session.GetVersionSpecificDomains<CurrentCdpVersion.DevToolsSessionDomains>();
             ManualResetEventSlim sync = new ManualResetEventSlim(false);
-            EventHandler<V114.Log.EntryAddedEventArgs> entryAddedHandler = (sender, e) =>
+            EventHandler<CurrentCdpVersion.Log.EntryAddedEventArgs> entryAddedHandler = (sender, e) =>
             {
                 Assert.That(e.Entry.Text.Contains("404"));
-                Assert.That(e.Entry.Level == V114.Log.LogEntryLevelValues.Error);
+                Assert.That(e.Entry.Level == CurrentCdpVersion.Log.LogEntryLevelValues.Error);
                 sync.Set();
             };