Skip to content

Commit 3d364f6

Browse files
shs96cshs96c
committed
Fix the Buck build for the safaridriver.
The resulting extension isn't quite ready for action, but it moves us closer. I need to figure out how to build a js_module_binary with Buck before we can move forward. How hard can it be?
1 parent f62d496 commit 3d364f6

File tree

3 files changed

+192
-8
lines changed

3 files changed

+192
-8
lines changed

‎javascript/safari-driver/BUCK

Lines changed: 129 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,3 +77,132 @@ js_binary(name = 'client',
7777
'//java/client/src/org/openqa/selenium/safari:client',
7878
],
7979
)
80+
81+
# Binary for the debug/logging window.
82+
js_binary(
83+
name = 'debug',
84+
srcs = [
85+
'deps.js',
86+
'debug/debug.js',
87+
],
88+
defines = [
89+
'goog.userAgent.ASSUME_WEBKIT=true',
90+
'goog.userAgent.product.ASSUME_SAFARI=true',
91+
'safaridriver.message.ORIGIN=1',
92+
'safaridriver.message.FORCE_SYNCHRONOUS_PROXY_SEND=true',
93+
],
94+
externs = [
95+
'externs/common.js',
96+
'externs/webcontent.js',
97+
],
98+
flags = [
99+
'--jscomp_error=accessControls',
100+
'--jscomp_error=ambiguousFunctionDecl',
101+
'--jscomp_error=checkRegExp',
102+
'--jscomp_error=checkTypes',
103+
'--jscomp_error=checkVars',
104+
'--jscomp_error=constantProperty',
105+
'--jscomp_error=deprecated',
106+
'--jscomp_error=duplicateMessage',
107+
'--jscomp_error=es5Strict',
108+
'--jscomp_error=externsValidation',
109+
'--jscomp_error=fileoverviewTags',
110+
'--jscomp_error=globalThis',
111+
'--jscomp_error=invalidCasts',
112+
'--jscomp_error=missingProperties',
113+
'--jscomp_error=nonStandardJsDocs',
114+
'--jscomp_error=strictModuleDepCheck',
115+
'--jscomp_error=typeInvalidation',
116+
'--jscomp_error=undefinedVars',
117+
'--jscomp_error=unknownDefines',
118+
'--jscomp_error=uselessCode',
119+
'--jscomp_error=visibility',
120+
121+
"--output_wrapper='%output%;safaridriver.debug.init();'",
122+
'--third_party=false',
123+
],
124+
deps = [
125+
':command',
126+
':common',
127+
'//javascript/safari-driver/message:message',
128+
'//javascript/webdriver:base',
129+
'//javascript/webdriver:capabilities',
130+
'//javascript/webdriver:session',
131+
'//javascript/webdriver:webdriver',
132+
'//third_party/closure:closure',
133+
],
134+
)
135+
136+
# The global extension script.
137+
js_binary(
138+
name = 'extension',
139+
srcs = [
140+
'deps.js',
141+
'extension/commands.js',
142+
'extension/extension.js',
143+
'extension/logdb.js',
144+
'extension/server.js',
145+
'extension/session.js',
146+
'extension/tab.js',
147+
'extension/tabmanager.js',
148+
],
149+
defines = [
150+
'goog.userAgent.ASSUME_WEBKIT=true',
151+
'goog.userAgent.product.ASSUME_SAFARI=true',
152+
'safaridriver.message.ORIGIN=0'
153+
],
154+
externs = [
155+
'externs/common.js',
156+
'externs/extension.js',
157+
],
158+
flags = [
159+
'--jscomp_error=accessControls',
160+
'--jscomp_error=ambiguousFunctionDecl',
161+
'--jscomp_error=checkRegExp',
162+
'--jscomp_error=checkTypes',
163+
'--jscomp_error=checkVars',
164+
'--jscomp_error=constantProperty',
165+
'--jscomp_error=deprecated',
166+
'--jscomp_error=duplicateMessage',
167+
'--jscomp_error=es5Strict',
168+
'--jscomp_error=externsValidation',
169+
'--jscomp_error=fileoverviewTags',
170+
'--jscomp_error=globalThis',
171+
'--jscomp_error=invalidCasts',
172+
'--jscomp_error=missingProperties',
173+
'--jscomp_error=nonStandardJsDocs',
174+
'--jscomp_error=strictModuleDepCheck',
175+
'--jscomp_error=typeInvalidation',
176+
'--jscomp_error=undefinedVars',
177+
'--jscomp_error=unknownDefines',
178+
'--jscomp_error=uselessCode',
179+
'--jscomp_error=visibility',
180+
181+
"--output_wrapper='%output%;safaridriver.extension.init();'",
182+
'--third_party=false',
183+
],
184+
deps = [
185+
':common',
186+
'//javascript/safari-driver/message:message',
187+
'//javascript/webdriver:webdriver',
188+
'//third_party/closure:closure',
189+
],
190+
)
191+
192+
# Packages everything up into a .safariextension folder that can be loaded by
193+
# Safari's Extension Builder.
194+
folder(
195+
name = 'safari-driver',
196+
out = 'SafariDriver.safariextension',
197+
srcs = [
198+
':debug',
199+
':extension',
200+
# ':injected',
201+
# ':page',
202+
'Info.plist',
203+
'icon.png',
204+
'toolbar.png',
205+
'debug/log.html',
206+
'extension/extension.html',
207+
],
208+
)

‎javascript/safari-driver/prebuilt/BUCK

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎javascript/webdriver/BUCK

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ js_library(name = 'base',
1515
],
1616
)
1717

18+
js_library(name = 'button',
19+
srcs = [
20+
'button.js',
21+
],
22+
)
23+
1824
js_library(name = 'capabilities',
1925
srcs = [
2026
'capabilities.js',
@@ -23,6 +29,9 @@ js_library(name = 'capabilities',
2329
':logging',
2430
':serializable',
2531
],
32+
visibility = [
33+
'//javascript/safari-driver/...'
34+
],
2635
)
2736

2837
js_library(name = 'events',
@@ -54,6 +63,15 @@ js_library(name = 'key',
5463
],
5564
)
5665

66+
js_library(name = 'locators',
67+
srcs = [
68+
'locators.js',
69+
],
70+
deps = [
71+
'//third_party/closure:closure',
72+
],
73+
)
74+
5775
js_library(name = 'logging',
5876
srcs = [
5977
'logging.js',
@@ -77,6 +95,19 @@ js_library(name = 'promise',
7795
],
7896
)
7997

98+
js_library(name = 'sequence',
99+
srcs = [
100+
'actionsequence.js',
101+
'touchsequence.js',
102+
],
103+
deps = [
104+
':base',
105+
':button',
106+
':key',
107+
'//third_party/closure:closure',
108+
],
109+
)
110+
80111
js_library(name = 'serializable',
81112
srcs = [
82113
'serializable.js',
@@ -94,6 +125,7 @@ js_library(name = 'session',
94125
],
95126
visibility = [
96127
'//javascript/remote:client',
128+
'//javascript/safari-driver/...'
97129
],
98130
)
99131

@@ -105,3 +137,34 @@ js_library(name = 'stacktrace',
105137
'//third_party/closure:closure',
106138
],
107139
)
140+
141+
js_library(name = 'until',
142+
srcs = [
143+
'until.js',
144+
],
145+
deps = [
146+
':locators',
147+
'//javascript/atoms:errors',
148+
'//third_party/closure:closure',
149+
],
150+
)
151+
152+
js_library(name = 'webdriver',
153+
srcs = [
154+
'webdriver.js',
155+
],
156+
deps = [
157+
':base',
158+
':key',
159+
':locators',
160+
':logging',
161+
':sequence',
162+
':session',
163+
':until',
164+
'//javascript/atoms:errors',
165+
'//third_party/closure:closure',
166+
],
167+
visibility = [
168+
'//javascript/safari-driver/...'
169+
],
170+
)

0 commit comments

Comments
 (0)