Skip to content

Commit 3efb867

Browse files
committed
Ensure createDefaultService is the same as new Builder().build()
1 parent e1df34e commit 3efb867

File tree

7 files changed

+12
-7
lines changed

7 files changed

+12
-7
lines changed

java/client/src/org/openqa/selenium/chrome/ChromeDriverService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public ChromeDriverService(File executable, int port, ImmutableList<String> args
8585
* @return A new ChromeDriverService using the default configuration.
8686
*/
8787
public static ChromeDriverService createDefaultService() {
88-
return new Builder().usingAnyFreePort().build();
88+
return new Builder().build();
8989
}
9090

9191
/**

java/client/src/org/openqa/selenium/edge/EdgeDriverService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public EdgeDriverService(File executable, int port, ImmutableList<String> args,
6464
* @return A new EdgeDriverService using the default configuration.
6565
*/
6666
public static EdgeDriverService createDefaultService() {
67-
return new Builder().usingAnyFreePort().build();
67+
return new Builder().build();
6868
}
6969

7070
public static class Builder extends DriverService.Builder<

java/client/src/org/openqa/selenium/firefox/GeckoDriverService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,11 @@ public GeckoDriverService(File executable, int port, ImmutableList<String> args,
6868
* @return A new GeckoDriverService using the default configuration.
6969
*/
7070
public static GeckoDriverService createDefaultService() {
71-
return new Builder().usingAnyFreePort().build();
71+
return new Builder().build();
7272
}
7373

7474
static GeckoDriverService createDefaultService(Capabilities caps) {
75-
Builder builder = new Builder().usingAnyFreePort();
75+
Builder builder = new Builder();
7676

7777
Object binary = caps.getCapability(FirefoxDriver.BINARY);
7878
if (binary != null) {

java/client/src/org/openqa/selenium/firefox/XpiDriverService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ private static Extension loadDefaultExtension() {
175175
*/
176176
public static XpiDriverService createDefaultService() {
177177
try {
178-
return new XpiDriverService.Builder().usingAnyFreePort().build();
178+
return new Builder().build();
179179
} catch (WebDriverException e) {
180180
throw new IllegalStateException(e.getMessage(), e.getCause());
181181
}
@@ -244,6 +244,7 @@ public static class Builder extends DriverService.Builder<XpiDriverService, XpiD
244244
private FirefoxBinary binary = null;
245245
private FirefoxProfile profile = null;
246246

247+
247248
private Builder() {
248249
// Only available through the static factory method in the XpiDriverService
249250
}

java/client/src/org/openqa/selenium/ie/InternetExplorerDriverService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ private InternetExplorerDriverService(File executable, int port, ImmutableList<S
9090
* @return A new InternetExplorerDriverService using the default configuration.
9191
*/
9292
public static InternetExplorerDriverService createDefaultService() {
93-
return new Builder().usingAnyFreePort().build();
93+
return new Builder().build();
9494
}
9595

9696
/**

java/client/src/org/openqa/selenium/opera/OperaDriverService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public OperaDriverService(File executable, int port, ImmutableList<String> args,
7979
* @return A new OperaDriverService using the default configuration.
8080
*/
8181
public static OperaDriverService createDefaultService() {
82-
return new Builder().usingAnyFreePort().build();
82+
return new Builder().build();
8383
}
8484

8585
/**

java/client/src/org/openqa/selenium/safari/SafariDriverService.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,10 @@ protected void waitUntilAvailable() {
7373
public static class Builder extends DriverService.Builder<
7474
SafariDriverService, SafariDriverService.Builder> {
7575

76+
public Builder() {
77+
usingTechnologyPreview(false);
78+
}
79+
7680
public SafariDriverService.Builder usingTechnologyPreview(boolean useTechnologyPreview) {
7781
if (useTechnologyPreview) {
7882
usingDriverExecutable(TP_SAFARI_DRIVER_EXECUTABLE);

0 commit comments

Comments
 (0)