Skip to content

Commit 4be56fb

Browse files
committed
Unignoring a bunch of tests in marionette, file uploading and d-n-d work now
1 parent fe0476d commit 4be56fb

File tree

6 files changed

+0
-10
lines changed

6 files changed

+0
-10
lines changed

java/client/test/org/openqa/selenium/CorrectEventFiringTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,6 @@ public void testSubmittingFormFromFormInputTextElementShouldFireOnSubmitForThatF
345345

346346
@Test
347347
@Ignore(value = SAFARI, reason = "Does not yet support file uploads, issue 4220")
348-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
349348
public void testUploadingFileShouldFireOnChangeEvent() throws IOException {
350349
driver.get(pages.formPage);
351350
WebElement uploadElement = driver.findElement(By.id("upload"));

java/client/test/org/openqa/selenium/FormHandlingTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ public void testShouldEnterDataIntoFormFields() {
159159

160160
@Test
161161
@Ignore(value = SAFARI, reason = "issue 4220")
162-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
163162
public void testShouldBeAbleToAlterTheContentsOfAFileUploadInputElement() throws IOException {
164163
driver.get(pages.formPage);
165164
WebElement uploadElement = driver.findElement(By.id("upload"));
@@ -176,7 +175,6 @@ public void testShouldBeAbleToAlterTheContentsOfAFileUploadInputElement() throws
176175

177176
@Test
178177
@Ignore(value = SAFARI, reason = "issue 4220")
179-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
180178
public void testShouldBeAbleToSendKeysToAFileUploadInputElementInAnXhtmlDocument()
181179
throws IOException {
182180
assumeFalse("IE before 9 doesn't handle pages served with an XHTML content type,"
@@ -198,7 +196,6 @@ public void testShouldBeAbleToSendKeysToAFileUploadInputElementInAnXhtmlDocument
198196

199197
@Test
200198
@Ignore(value = SAFARI, reason = "issue 4220")
201-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
202199
public void testShouldBeAbleToUploadTheSameFileTwice() throws IOException {
203200
File file = File.createTempFile("test", "txt");
204201
file.deleteOnExit();

java/client/test/org/openqa/selenium/PageLoadingTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,6 @@ public void testShouldTimeoutIfAPageTakesTooLongToLoad() {
440440

441441
@NoDriverAfterTest // Subsequent tests sometimes fail on Firefox.
442442
@Test
443-
@Ignore(value = MARIONETTE)
444443
@Ignore(value = SAFARI, reason = "issue 687, comment 41")
445444
@NeedsLocalEnvironment
446445
public void testShouldTimeoutIfAPageTakesTooLongToLoadAfterClick() {

java/client/test/org/openqa/selenium/UploadTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ public void setUp() throws Exception {
6060

6161
@SwitchToTopAfterTest
6262
@Test
63-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
6463
public void testFileUploading() throws Exception {
6564
assumeFalse(
6665
"This test as written assumes a file on local disk is accessible to the browser. "
@@ -84,7 +83,6 @@ public void testFileUploading() throws Exception {
8483
@Ignore(IE)
8584
@Ignore(PHANTOMJS)
8685
@Ignore(SAFARI)
87-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
8886
public void testCleanFileInput() throws Exception {
8987
driver.get(pages.uploadPage);
9088
WebElement element = driver.findElement(By.id("upload"));

java/client/test/org/openqa/selenium/interactions/BasicMouseInterfaceTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,6 @@ public void testMovingMouseToRelativeZeroElementOffset() {
401401

402402
@NeedsFreshDriver({IE, CHROME})
403403
@Test
404-
@Ignore(MARIONETTE)
405404
@NotYetImplemented(HTMLUNIT)
406405
public void testMoveRelativeToBody() {
407406
try {

java/client/test/org/openqa/selenium/interactions/DragAndDropTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
public class DragAndDropTest extends JUnit4TestBase {
5454

5555
@Test
56-
@Ignore(MARIONETTE)
5756
public void testDragAndDropRelative() {
5857
assumeFalse("See issue 2281", TestUtilities.getEffectivePlatform().is(Platform.MAC));
5958
assumeFalse(Browser.detect() == Browser.opera &&
@@ -73,7 +72,6 @@ public void testDragAndDropRelative() {
7372
}
7473

7574
@Test
76-
@Ignore(MARIONETTE)
7775
public void testDragAndDropToElement() {
7876
driver.get(pages.dragAndDropPage);
7977
WebElement img1 = driver.findElement(By.id("test1"));

0 commit comments

Comments
 (0)