Skip to content

Commit 4e4d599

Browse files
committed
Try and fix some of the failing RC tests
1 parent c1f4989 commit 4e4d599

File tree

4 files changed

+15
-2
lines changed

4 files changed

+15
-2
lines changed

java/client/test/com/thoughtworks/selenium/BUCK

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ java_library(
5959
'//java/client/test/org/openqa/selenium:helpers',
6060
'//java/client/test/org/openqa/selenium/environment:environment',
6161
'//java/client/test/org/openqa/selenium/testing:helpers',
62+
'//java/client/test/org/openqa/selenium/testing:test-base',
6263
'//java/client/test/org/openqa/selenium/testing/drivers:browser',
6364
'//java/client/test/org/openqa/selenium/testing/drivers:drivers',
6465
'//java/server/test/org/openqa/selenium:server-with-tests',

java/client/test/com/thoughtworks/selenium/corebased/TestBasicAuth.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,30 @@
1818

1919
package com.thoughtworks.selenium.corebased;
2020

21+
import static org.junit.Assume.assumeFalse;
22+
import static org.junit.Assume.assumeTrue;
23+
2124
import com.thoughtworks.selenium.InternalSelenseTestBase;
2225

26+
import org.junit.Assume;
2327
import org.junit.Test;
28+
import org.openqa.selenium.HasCapabilities;
29+
import org.openqa.selenium.WebDriver;
2430
import org.openqa.selenium.environment.GlobalTestEnvironment;
2531
import org.openqa.selenium.environment.webserver.AppServer;
32+
import org.openqa.selenium.internal.WrapsDriver;
33+
import org.openqa.selenium.testing.TestUtilities;
2634

2735
import java.net.MalformedURLException;
2836
import java.net.URL;
2937

3038
public class TestBasicAuth extends InternalSelenseTestBase {
3139
@Test
3240
public void testBasicAuth() throws Exception {
41+
assumeFalse(
42+
"Geckodriver does not support basic auth without user interaction.",
43+
selenium instanceof WrapsDriver &&
44+
TestUtilities.isFirefox(((WrapsDriver) selenium).getWrappedDriver()));
3345
selenium.open(getUrl());
3446
assertEquals(selenium.getTitle(), "Welcome");
3547
}

java/client/test/com/thoughtworks/selenium/corebased/TestClickAt.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import org.openqa.selenium.remote.CapabilityType;
2929

3030
public class TestClickAt extends InternalSelenseTestBase {
31-
@Test
31+
@Test(timeout = 60000)
3232
public void testClickAt() throws Exception {
3333
selenium.open("../tests/html/test_click_page1.html");
3434
verifyEquals(selenium.getText("link"), "Click here for next page");

java/client/test/org/openqa/selenium/firefox/MarionetteTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ public void canUseSameProfileInCapabilitiesAndDirectly() {
167167

168168
verifyItIsMarionette(localDriver);
169169
}
170-
170+
171171
@Test
172172
public void canPassCapabilitiesBinaryAndProfileSeparately() throws IOException {
173173
FirefoxBinary binary = spy(new FirefoxBinary());

0 commit comments

Comments
 (0)