[rb] redundant — asserting executable also asserts file

Author: titusfortner

rb/lib/selenium/webdriver/common/driver_finder.rb

@@ -31,7 +31,6 @@ def self.path(options, klass)
         end
 
         begin
-          Platform.assert_file(path)
           Platform.assert_executable(path)
         rescue TypeError
           raise Error::NoSuchDriverError, "Unable to locate or obtain #{klass::EXECUTABLE}"

rb/spec/unit/selenium/webdriver/chrome/driver_spec.rb

@@ -63,7 +63,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'does not require any parameters' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('path')
+          allow(DriverFinder).to receive(:path).and_return('path')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
 
@@ -73,7 +73,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'accepts provided Options as sole parameter' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('path')
+          allow(DriverFinder).to receive(:path).and_return('path')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
 

rb/spec/unit/selenium/webdriver/chrome/service_spec.rb

@@ -97,7 +97,7 @@ module Chrome
           end
 
           it 'is created when :url is not provided' do
-            allow(SeleniumManager).to receive(:driver_path).and_return('path')
+            allow(DriverFinder).to receive(:path).and_return('path')
             allow(Platform).to receive(:assert_file)
             allow(Platform).to receive(:assert_executable)
             allow(described_class).to receive(:new).and_return(service)
@@ -107,7 +107,7 @@ module Chrome
           end
 
           it 'accepts :service without creating a new instance' do
-            allow(SeleniumManager).to receive(:driver_path).and_return('path')
+            allow(DriverFinder).to receive(:path).and_return('path')
             allow(Platform).to receive(:assert_file)
             allow(Platform).to receive(:assert_executable)
             allow(described_class).to receive(:new)

rb/spec/unit/selenium/webdriver/edge/driver_spec.rb

@@ -63,7 +63,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'does not require any parameters' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('path')
+          allow(DriverFinder).to receive(:path).and_return('path')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
           expect_request
@@ -72,7 +72,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'accepts provided Options as sole parameter' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('path')
+          allow(DriverFinder).to receive(:path).and_return('path')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
           opts = {args: ['-f']}
@@ -82,7 +82,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'raises an ArgumentError if parameter is not recognized' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('path')
+          allow(DriverFinder).to receive(:path).and_return('path')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
           msg = 'unknown keyword: :invalid'

rb/spec/unit/selenium/webdriver/edge/service_spec.rb

@@ -88,7 +88,7 @@ module Edge
           end
 
           it 'is created when :url is not provided' do
-            allow(SeleniumManager).to receive(:driver_path).and_return('path')
+            allow(DriverFinder).to receive(:path).and_return('path')
             allow(Platform).to receive(:assert_file)
             allow(Platform).to receive(:assert_executable)
             allow(described_class).to receive(:new).and_return(service)
@@ -98,7 +98,7 @@ module Edge
           end
 
           it 'accepts :service without creating a new instance' do
-            allow(SeleniumManager).to receive(:driver_path).and_return('path')
+            allow(DriverFinder).to receive(:path).and_return('path')
             allow(Platform).to receive(:assert_file)
             allow(Platform).to receive(:assert_executable)
             allow(described_class).to receive(:new)

rb/spec/unit/selenium/webdriver/firefox/driver_spec.rb

@@ -66,7 +66,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'does not require any parameters' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('path')
+          allow(DriverFinder).to receive(:path).and_return('path')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
           expect_request
@@ -75,7 +75,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'accepts provided Options as sole parameter' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('path')
+          allow(DriverFinder).to receive(:path).and_return('path')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
 

rb/spec/unit/selenium/webdriver/firefox/service_spec.rb

@@ -82,7 +82,7 @@ module Firefox
           end
 
           it 'is created when :url is not provided' do
-            allow(SeleniumManager).to receive(:driver_path).and_return('path')
+            allow(DriverFinder).to receive(:path).and_return('path')
             allow(Platform).to receive(:assert_file)
             allow(Platform).to receive(:assert_executable)
             allow(described_class).to receive(:new).and_return(service)
@@ -93,7 +93,7 @@ module Firefox
           end
 
           it 'accepts :service without creating a new instance' do
-            allow(SeleniumManager).to receive(:driver_path).and_return('path')
+            allow(DriverFinder).to receive(:path).and_return('path')
             allow(Platform).to receive(:assert_file)
             allow(Platform).to receive(:assert_executable)
             allow(described_class).to receive(:new)

rb/spec/unit/selenium/webdriver/ie/driver_spec.rb

@@ -64,7 +64,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'does not require any parameters' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('path')
+          allow(DriverFinder).to receive(:path).and_return('path')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
           expect_request
@@ -73,7 +73,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'accepts provided Options as sole parameter' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('path')
+          allow(DriverFinder).to receive(:path).and_return('path')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
           opts = {args: ['-f']}

rb/spec/unit/selenium/webdriver/ie/service_spec.rb

@@ -95,7 +95,7 @@ module IE
           end
 
           it 'accepts :service without creating a new instance' do
-            allow(SeleniumManager).to receive(:driver_path).and_return('path')
+            allow(DriverFinder).to receive(:path).and_return('path')
             allow(Platform).to receive(:assert_file)
             allow(Platform).to receive(:assert_executable)
             allow(described_class).to receive(:new)

rb/spec/unit/selenium/webdriver/safari/driver_spec.rb

@@ -63,7 +63,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'does not require any parameters' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('/path/to/safaridriver')
+          allow(DriverFinder).to receive(:path).and_return('/path/to/safaridriver')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
           expect_request
@@ -72,7 +72,7 @@ def expect_request(body: nil, endpoint: nil)
         end
 
         it 'accepts provided Options as sole parameter' do
-          allow(SeleniumManager).to receive(:driver_path).and_return('/path/to/safaridriver')
+          allow(DriverFinder).to receive(:path).and_return('/path/to/safaridriver')
           allow(Platform).to receive(:assert_file)
           allow(Platform).to receive(:assert_executable)
           opts = {automatic_inspection: true}