Skip to content

Commit 6967db0

Browse files
committed
Fixing tests for JsonToBeanConverter to avoid "error" key collision that has got new semantics in the standard
1 parent 79a1fdb commit 6967db0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

java/client/test/org/openqa/selenium/remote/JsonToBeanConverterTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ public void testShouldUseAMapToRepresentComplexObjects() throws Exception {
171171
@Test
172172
public void testShouldConvertAResponseWithAnElementInIt() throws Exception {
173173
String json =
174-
"{\"value\":{\"value\":\"\",\"text\":\"\",\"selected\":false,\"enabled\":true,\"id\":\"three\"},\"context\":\"con\",\"sessionId\":\"sess\",\"error\":false}";
174+
"{\"value\":{\"value\":\"\",\"text\":\"\",\"selected\":false,\"enabled\":true,\"id\":\"three\"},\"context\":\"con\",\"sessionId\":\"sess\"}";
175175
Response converted = new JsonToBeanConverter().convert(Response.class, json);
176176

177177
Map<?,?> value = (Map<?,?>) converted.getValue();
@@ -188,7 +188,7 @@ public void testConvertABlankStringAsAStringEvenWhenAskedToReturnAnObject() thro
188188
@Test
189189
public void testShouldBeAbleToCopeWithStringsThatLookLikeBooleans() throws Exception {
190190
String json =
191-
"{\"value\":\"false\",\"context\":\"foo\",\"sessionId\":\"1210083863107\",\"error\":false}";
191+
"{\"value\":\"false\",\"context\":\"foo\",\"sessionId\":\"1210083863107\"}";
192192

193193
try {
194194
new JsonToBeanConverter().convert(Response.class, json);
@@ -201,7 +201,7 @@ public void testShouldBeAbleToCopeWithStringsThatLookLikeBooleans() throws Excep
201201
@Test
202202
public void testShouldBeAbleToSetAnObjectToABoolean() throws Exception {
203203
String json =
204-
"{\"value\":true,\"context\":\"foo\",\"sessionId\":\"1210084658750\",\"error\":false}";
204+
"{\"value\":true,\"context\":\"foo\",\"sessionId\":\"1210084658750\"}";
205205

206206
Response response = new JsonToBeanConverter().convert(Response.class, json);
207207

0 commit comments

Comments
 (0)