Fix incorrect use of 'NoReturn' type annotation. (#9540)

When a function or method explicitly or implicitly returns None, its
return type annotation should be 'None'.
'NoReturn' should only be used when a function or method never returns
e.g., it always raises an Exception.

Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>

Author: varunsurapaneni

py/selenium/webdriver/remote/webdriver.py

@@ -21,8 +21,7 @@
 
 import pkgutil
 import sys
-from typing import (Dict, List,
-                    NoReturn, Union)
+from typing import Dict, List, Union
 
 import warnings
 
@@ -318,7 +317,7 @@ def stop_client(self):
         """
         pass
 
-    def start_session(self, capabilities: dict, browser_profile=None) -> NoReturn:
+    def start_session(self, capabilities: dict, browser_profile=None) -> None:
         """
         Creates a new session with the desired capabilities.
 
@@ -405,7 +404,7 @@ def execute(self, driver_command: str, params: dict = None) -> dict:
         # a success
         return {'success': 0, 'value': None, 'sessionId': self.session_id}
 
-    def get(self, url: str) -> NoReturn:
+    def get(self, url: str) -> None:
         """
         Loads a web page in the current browser session.
         """
@@ -753,7 +752,7 @@ def pin_script(self, script, script_key=None) -> ScriptKey:
         self.pinned_scripts[_script_key.id] = script
         return _script_key
 
-    def unpin(self, script_key) -> NoReturn:
+    def unpin(self, script_key) -> None:
         """
 
         """
@@ -837,7 +836,7 @@ def page_source(self) -> str:
         """
         return self.execute(Command.GET_PAGE_SOURCE)['value']
 
-    def close(self) -> NoReturn:
+    def close(self) -> None:
         """
         Closes the current window.
 
@@ -848,7 +847,7 @@ def close(self) -> NoReturn:
         """
         self.execute(Command.CLOSE)
 
-    def quit(self) -> NoReturn:
+    def quit(self) -> None:
         """
         Quits the driver and closes every associated window.
 
@@ -887,21 +886,21 @@ def window_handles(self) -> List[str]:
         """
         return self.execute(Command.W3C_GET_WINDOW_HANDLES)['value']
 
-    def maximize_window(self) -> NoReturn:
+    def maximize_window(self) -> None:
         """
         Maximizes the current window that webdriver is using
         """
         params = None
         command = Command.W3C_MAXIMIZE_WINDOW
         self.execute(command, params)
 
-    def fullscreen_window(self) -> NoReturn:
+    def fullscreen_window(self) -> None:
         """
         Invokes the window manager-specific 'full screen' operation
         """
         self.execute(Command.FULLSCREEN_WINDOW)
 
-    def minimize_window(self) -> NoReturn:
+    def minimize_window(self) -> None:
         """
         Invokes the window manager-specific 'minimize' operation
         """
@@ -939,7 +938,7 @@ def switch_to(self) -> SwitchTo:
         return self._switch_to
 
     # Navigation
-    def back(self) -> NoReturn:
+    def back(self) -> None:
         """
         Goes one step backward in the browser history.
 
@@ -950,7 +949,7 @@ def back(self) -> NoReturn:
         """
         self.execute(Command.GO_BACK)
 
-    def forward(self) -> NoReturn:
+    def forward(self) -> None:
         """
         Goes one step forward in the browser history.
 
@@ -961,7 +960,7 @@ def forward(self) -> NoReturn:
         """
         self.execute(Command.GO_FORWARD)
 
-    def refresh(self) -> NoReturn:
+    def refresh(self) -> None:
         """
         Refreshes the current page.
 
@@ -998,7 +997,7 @@ def get_cookie(self, name) -> dict:
         except NoSuchCookieException:
             return None
 
-    def delete_cookie(self, name) -> NoReturn:
+    def delete_cookie(self, name) -> None:
         """
         Deletes a single cookie with the given name.
 
@@ -1009,7 +1008,7 @@ def delete_cookie(self, name) -> NoReturn:
         """
         self.execute(Command.DELETE_COOKIE, {'name': name})
 
-    def delete_all_cookies(self) -> NoReturn:
+    def delete_all_cookies(self) -> None:
         """
         Delete all cookies in the scope of the session.
 
@@ -1020,7 +1019,7 @@ def delete_all_cookies(self) -> NoReturn:
         """
         self.execute(Command.DELETE_ALL_COOKIES)
 
-    def add_cookie(self, cookie_dict) -> NoReturn:
+    def add_cookie(self, cookie_dict) -> None:
         """
         Adds a cookie to your current session.
 
@@ -1042,7 +1041,7 @@ def add_cookie(self, cookie_dict) -> NoReturn:
             self.execute(Command.ADD_COOKIE, {'cookie': cookie_dict})
 
     # Timeouts
-    def implicitly_wait(self, time_to_wait) -> NoReturn:
+    def implicitly_wait(self, time_to_wait) -> None:
         """
         Sets a sticky timeout to implicitly wait for an element to be found,
            or a command to complete. This method only needs to be called one
@@ -1060,7 +1059,7 @@ def implicitly_wait(self, time_to_wait) -> NoReturn:
         self.execute(Command.SET_TIMEOUTS, {
             'implicit': int(float(time_to_wait) * 1000)})
 
-    def set_script_timeout(self, time_to_wait) -> NoReturn:
+    def set_script_timeout(self, time_to_wait) -> None:
         """
         Set the amount of time that the script should wait during an
            execute_async_script call before throwing an error.
@@ -1076,7 +1075,7 @@ def set_script_timeout(self, time_to_wait) -> NoReturn:
         self.execute(Command.SET_TIMEOUTS, {
             'script': int(float(time_to_wait) * 1000)})
 
-    def set_page_load_timeout(self, time_to_wait) -> NoReturn:
+    def set_page_load_timeout(self, time_to_wait) -> None:
         """
         Set the amount of time to wait for a page load to complete
            before throwing an error.
@@ -1114,7 +1113,7 @@ def timeouts(self) -> Timeouts:
         return Timeouts(**timeouts)
 
     @timeouts.setter
-    def timeouts(self, timeouts) -> NoReturn:
+    def timeouts(self, timeouts) -> None:
         """
         Set all timeouts for the session. This will override any previously
         set timeouts.