Skip to content

Commit 78ca285

Browse files
committed
Updating IE driver to fix clearing of <input type='number'> fields
Also includes update to Java test to remove guards against IE.
1 parent ae09849 commit 78ca285

File tree

6 files changed

+10
-9
lines changed

6 files changed

+10
-9
lines changed

cpp/iedriver/Generated/atoms.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1612,11 +1612,11 @@ const wchar_t* const CLEAR[] = {
16121612
L"&b.focus()}a.value?(a.value=\"\",b=x(a),xc&&b.createEventObject?b=b.cr",
16131613
L"eateEventObject():(b=b.createEvent(\"HTMLEvents\"),b.initEvent(Xc.a,Xc",
16141614
L".b,Xc.h)),\"isTrusted\"in b||(b.isTrusted=!1),xc&&a.fireEvent?a.fireEv",
1615-
L"ent(\"on\"+Xc.a,b):a.dispatchEvent(b)):V(a,\"INPUT\")&&\"number\"==a.g",
1616-
L"etAttribute(\"type\").toLowerCase()&&(a.value=\"\");Hc(a)&&(a.innerHTM",
1617-
L"L=\" \")});; return this._.apply(null,arguments);}.apply({navigator:ty",
1618-
L"peof window!=undefined?window.navigator:null,document:typeof window!=u",
1619-
L"ndefined?window.document:null}, arguments);}",
1615+
L"ent(\"on\"+Xc.a,b):a.dispatchEvent(b)):V(a,\"INPUT\")&&a.getAttribute(",
1616+
L"\"type\")&&\"number\"==a.getAttribute(\"type\").toLowerCase()&&(a.valu",
1617+
L"e=\"\");Hc(a)&&(a.innerHTML=\" \")});; return this._.apply(null,argume",
1618+
L"nts);}.apply({navigator:typeof window!=undefined?window.navigator:null",
1619+
L",document:typeof window!=undefined?window.document:null}, arguments);}",
16201620
NULL
16211621
};
16221622

cpp/iedriverserver/CHANGELOG

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ available via the project downloads page. Changes in "revision" field indicate
99
private releases checked into the prebuilts directory of the source tree, but
1010
not made generally available on the downloads page.
1111

12+
v2.48.0.2
13+
=========
14+
* Updates to JavaScript automation atoms.
15+
* Includes fix for clearing input elements with type "number".
16+
1217
v2.48.0.1
1318
=========
1419
* Updating to return top-level URL when focused on a frame. This makes the

cpp/iedriverserver/IEDriverServer.rc

0 Bytes
Binary file not shown.
Binary file not shown.
6.5 KB
Binary file not shown.

java/client/test/org/openqa/selenium/TypingTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -785,10 +785,6 @@ public void canSafelyTypeOnElementThatIsRemovedFromTheDomOnKeyPress() {
785785
@Test
786786
@NotYetImplemented({CHROME, HTMLUNIT})
787787
public void canClearNumberInputAfterTypingInvalidInput() {
788-
// IE < 10 treats "number" inputs as regular text fields, so this
789-
// test passes.
790-
assumeFalse("IE 10+ does not validate input until focus change", isInternetExplorer(driver) && getIEVersion(driver) >= 10);
791-
792788
driver.get(pages.formPage);
793789
WebElement input = driver.findElement(By.id("age"));
794790
input.sendKeys("e");

0 commit comments

Comments
 (0)