Skip to content

Commit 81e023a

Browse files
luke-hillp0deje
authored andcommitted
Two of the failing specs are now marked as fixed by Chromium and uncoupling the expected errors now makes tests green!
Signed-off-by: Alex Rodionov <p0deje@gmail.com>
1 parent 448e3ff commit 81e023a

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

rb/spec/integration/selenium/webdriver/storage_spec.rb

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,20 @@ module Selenium
2121
module WebDriver
2222
module DriverExtensions
2323
describe HasWebStorage, only: {browser: %i[chrome firefox]} do
24-
shared_examples_for 'web storage' do
24+
shared_examples 'web storage' do
2525
before do
2626
driver.navigate.to url_for('clicks.html')
2727
storage.clear
2828
end
2929

30-
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2177
31-
it 'can get and set items', except: {browser: :chrome} do
30+
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2177 - To monitor as recently fixed
31+
it 'can get and set items' do
3232
expect(storage).to be_empty
3333
storage['foo'] = 'bar'
34-
expect(storage['foo']).to eq('bar')
3534

35+
expect(storage['foo']).to eq('bar')
3636
storage['foo1'] = 'bar1'
37+
3738
expect(storage['foo1']).to eq('bar1')
3839

3940
expect(storage.size).to eq(2)
@@ -48,8 +49,8 @@ module DriverExtensions
4849
expect(storage.keys).to include('foo1', 'foo2', 'foo3')
4950
end
5051

51-
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2177
52-
it 'can clear all items', except: {browser: :chrome} do
52+
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2177 - To monitor as recently fixed
53+
it 'can clear all items' do
5354
storage['foo1'] = 'bar1'
5455
storage['foo2'] = 'bar2'
5556
storage['foo3'] = 'bar3'

0 commit comments

Comments
 (0)