Skip to content

Commit 918be03

Browse files
joshbruningjuangj
authored andcommitted
Resolve flakiness in atoms tests.
Extends timeouts to resolve flakiness in history_test, inject_test, and mouse_test. Verified for 1000 runs of Chrome on Windows 7. Signed-off-by: Jason Juang <juangj@google.com>
1 parent 83984c0 commit 918be03

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

javascript/atoms/test/history_test.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
}
6767

6868
function setUpPage() {
69-
goog.testing.TestCase.getActiveTestCase().promiseTimeout = 10000; // 10s
69+
goog.testing.TestCase.getActiveTestCase().promiseTimeout = 30000; // 30s
7070
}
7171

7272
function setUp() {

javascript/atoms/test/inject_test.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,10 @@
4444

4545
var frame, frameWin, frameDoc;
4646

47+
function setUpPage() {
48+
goog.testing.TestCase.getActiveTestCase().promiseTimeout = 30000; // 30s
49+
}
50+
4751
function setUp() {
4852
frame = goog.dom.$('test-frame');
4953
frameWin = goog.dom.getFrameContentWindow(frame);

javascript/atoms/test/mouse_test.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@
6060
redDiv = bot.locators.findElement({id: 'red'});
6161
captureDiv = bot.locators.findElement({id: 'capture'});
6262
innerCaptureDiv = bot.locators.findElement({id: 'innerCapture'});
63+
goog.testing.TestCase.getActiveTestCase().promiseTimeout = 30000; // 30s
6364
}
6465

6566
function setUp() {

0 commit comments

Comments
 (0)