Skip to content

Commit ad13b0f

Browse files
committed
Annotate or fix some edge tests
1 parent 33ecb85 commit ad13b0f

File tree

2 files changed

+18
-10
lines changed

2 files changed

+18
-10
lines changed

java/test/org/openqa/selenium/edge/EdgeDriverFunctionalTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535

3636
import static org.assertj.core.api.Assertions.assertThat;
3737
import static org.assertj.core.api.Assertions.fail;
38+
import static org.assertj.core.api.Assumptions.assumeThat;
3839

3940
public class EdgeDriverFunctionalTest extends JUnit4TestBase {
4041

@@ -46,8 +47,8 @@ public void canSetPermission() {
4647
HasPermissions permissions = (HasPermissions) driver;
4748

4849
driver.get(pages.clicksPage);
49-
assertThat(checkPermission(driver, CLIPBOARD_READ)).isEqualTo("prompt");
50-
assertThat(checkPermission(driver, CLIPBOARD_WRITE)).isEqualTo("granted");
50+
assumeThat(checkPermission(driver, CLIPBOARD_READ)).isEqualTo("prompt");
51+
assumeThat(checkPermission(driver, CLIPBOARD_WRITE)).isEqualTo("granted");
5152

5253
permissions.setPermission(CLIPBOARD_READ, "denied");
5354
permissions.setPermission(CLIPBOARD_WRITE, "prompt");

java/test/org/openqa/selenium/edge/EdgeOptionsFunctionalTest.java

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,15 @@
2424
import org.junit.After;
2525
import org.junit.Test;
2626
import org.openqa.selenium.By;
27+
import org.openqa.selenium.HasCapabilities;
28+
import org.openqa.selenium.JavascriptExecutor;
2729
import org.openqa.selenium.Keys;
30+
import org.openqa.selenium.WebDriver;
2831
import org.openqa.selenium.build.InProject;
2932
import org.openqa.selenium.support.ui.WebDriverWait;
3033
import org.openqa.selenium.testing.JUnit4TestBase;
34+
import org.openqa.selenium.testing.NotYetImplemented;
35+
import org.openqa.selenium.testing.drivers.WebDriverBuilder;
3136

3237
import java.io.IOException;
3338
import java.nio.file.Files;
@@ -38,7 +43,7 @@ public class EdgeOptionsFunctionalTest extends JUnit4TestBase {
3843

3944
private static final String EXT_PATH = "third_party/chrome_ext/backspace.crx";
4045

41-
private EdgeDriver edgeDriver = null;
46+
private WebDriver edgeDriver = null;
4247

4348
@After
4449
public void tearDown() {
@@ -51,10 +56,10 @@ public void tearDown() {
5156
public void canStartChromeWithCustomOptions() {
5257
EdgeOptions options = new EdgeOptions();
5358
options.addArguments("user-agent=foo;bar");
54-
edgeDriver = new EdgeDriver(options);
59+
edgeDriver = new WebDriverBuilder().get(options);
5560

5661
edgeDriver.get(pages.clickJacker);
57-
Object userAgent = edgeDriver.executeScript("return window.navigator.userAgent");
62+
Object userAgent = ((JavascriptExecutor) edgeDriver).executeScript("return window.navigator.userAgent");
5863
assertThat(userAgent).isEqualTo("foo;bar");
5964
}
6065

@@ -71,17 +76,18 @@ public void optionsStayEqualAfterSerialization() {
7176
public void canSetAcceptInsecureCerts() {
7277
EdgeOptions options = new EdgeOptions();
7378
options.setAcceptInsecureCerts(true);
74-
edgeDriver = new EdgeDriver(options);
75-
System.out.println(edgeDriver.getCapabilities());
79+
edgeDriver = new WebDriverBuilder().get(options);
80+
System.out.println(((HasCapabilities) edgeDriver).getCapabilities());
7681

77-
assertThat(edgeDriver.getCapabilities().getCapability(ACCEPT_INSECURE_CERTS)).isEqualTo(true);
82+
assertThat(((HasCapabilities) edgeDriver).getCapabilities().getCapability(ACCEPT_INSECURE_CERTS)).isEqualTo(true);
7883
}
7984

8085
@Test
86+
@NotYetImplemented
8187
public void canAddExtensionFromFile() {
8288
EdgeOptions options = new EdgeOptions();
8389
options.addExtensions(InProject.locate(EXT_PATH).toFile());
84-
edgeDriver = new EdgeDriver(options);
90+
edgeDriver = new WebDriverBuilder().get(options);
8591

8692
edgeDriver.get(pages.clicksPage);
8793

@@ -93,11 +99,12 @@ public void canAddExtensionFromFile() {
9399
}
94100

95101
@Test
102+
@NotYetImplemented
96103
public void canAddExtensionFromStringEncodedInBase64() throws IOException {
97104
EdgeOptions options = new EdgeOptions();
98105
options.addEncodedExtensions(Base64.getEncoder().encodeToString(
99106
Files.readAllBytes(InProject.locate(EXT_PATH))));
100-
edgeDriver = new EdgeDriver(options);
107+
edgeDriver = new WebDriverBuilder().get(options);
101108

102109
edgeDriver.get(pages.clicksPage);
103110

0 commit comments

Comments
 (0)