[py] use setter for headless property in options classes

Author: lmtierney

py/selenium/webdriver/chrome/options.py

@@ -17,6 +17,7 @@
 
 import base64
 import os
+import warnings
 
 from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
 
@@ -158,19 +159,26 @@ def headless(self):
         """
         return '--headless' in self._arguments
 
-    def set_headless(self, headless=True):
+    @headless.setter
+    def headless(self, value):
         """
         Sets the headless argument
 
         Args:
-          headless: boolean value indicating to set the headless option
+          value: boolean value indicating to set the headless option
         """
         args = {'--headless', '--disable-gpu'}
-        if headless:
+        if value is True:
             self._arguments.extend(args)
         else:
             self._arguments = list(set(self._arguments) - args)
 
+    def set_headless(self, headless=True):
+        """ Deprecated, options.headless = True """
+        warnings.warn('use setter for headless property instead of set_headless',
+                      DeprecationWarning)
+        self.headless = headless
+
     def to_capabilities(self):
         """
             Creates a capabilities with all the options that have been set and

py/selenium/webdriver/firefox/options.py

@@ -14,6 +14,8 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+import warnings
+
 from selenium.common.exceptions import InvalidArgumentException
 from selenium.webdriver.common.proxy import Proxy
 from selenium.webdriver.firefox.firefox_binary import FirefoxBinary
@@ -119,18 +121,25 @@ def headless(self):
         """
         return '-headless' in self._arguments
 
-    def set_headless(self, headless=True):
+    @headless.setter
+    def headless(self, value):
         """
         Sets the headless argument
 
         Args:
-          headless: boolean value indicating to set the headless option
+          value: boolean value indicating to set the headless option
         """
-        if headless:
+        if value is True:
             self._arguments.append('-headless')
         elif '-headless' in self._arguments:
             self._arguments.remove('-headless')
 
+    def set_headless(self, headless=True):
+        """ Deprecated, options.headless = True """
+        warnings.warn('use setter for headless property instead of set_headless',
+                      DeprecationWarning)
+        self.headless = headless
+
     def to_capabilities(self):
         """Marshals the Firefox options to a `moz:firefoxOptions`
         object.

py/test/unit/selenium/webdriver/chrome/chrome_options_tests.py

@@ -112,14 +112,14 @@ def test_get_experimental_options(options):
 
 
 def test_set_headless(options):
-    options.set_headless()
+    options.headless = True
     assert '--headless' in options._arguments
     assert '--disable-gpu' in options._arguments
 
 
 def test_unset_headless(options):
     options._arguments = ['--headless', '--disable-gpu']
-    options.set_headless(False)
+    options.headless = False
     assert '--headless' not in options._arguments
     assert '--disable-gpu' not in options._arguments
 

py/test/unit/selenium/webdriver/firefox/firefox_options_tests.py

@@ -118,13 +118,13 @@ def test_set_log_level(options):
 
 
 def test_set_headless(options):
-    options.set_headless()
+    options.headless = True
     assert '-headless' in options._arguments
 
 
 def test_unset_headless(options):
     options._arguments = ['-headless']
-    options.set_headless(False)
+    options.headless = False
     assert '-headless' not in options._arguments