Skip to content

Commit b2e9e25

Browse files
committed
[java] Ignoring test for Firefox and fixing window size
1 parent 0088930 commit b2e9e25

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

java/test/org/openqa/selenium/WindowTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public void testCanMaximizeTheWindow() {
128128

129129
@SwitchToTopAfterTest
130130
@Test
131-
@Ignore(value = CHROME, travis = true)
131+
@Ignore(value = CHROME, gitHubActions = true)
132132
@Ignore(value = FIREFOX, gitHubActions = true)
133133
public void testCanMaximizeTheWindowFromFrame() {
134134
// Browser window cannot be resized or moved on ANDROID (and most mobile platforms
@@ -144,15 +144,15 @@ public void testCanMaximizeTheWindowFromFrame() {
144144

145145
@SwitchToTopAfterTest
146146
@Test
147-
@Ignore(value = CHROME, travis = true)
147+
@Ignore(value = CHROME, gitHubActions = true)
148148
@Ignore(value = FIREFOX, gitHubActions = true)
149149
public void testCanMaximizeTheWindowFromIframe() {
150150
// Browser window cannot be resized or moved on ANDROID (and most mobile platforms
151151
// though others aren't defined in org.openqa.selenium.Platform).
152152
assumeFalse(TestUtilities.getEffectivePlatform(driver).is(ANDROID));
153153

154154
driver.get(pages.iframePage);
155-
changeSizeTo(new Dimension(640, 325));
155+
changeSizeTo(new Dimension(640, 400));
156156

157157
driver.switchTo().frame("iframe1-name");
158158
enlargeBy(WebDriver.Window::maximize);
@@ -165,7 +165,7 @@ public void canMinimizeTheWindow() {
165165
// though others aren't defined in org.openqa.selenium.Platform).
166166
assumeFalse(TestUtilities.getEffectivePlatform(driver).is(ANDROID));
167167

168-
changeSizeTo(new Dimension(640, 323));
168+
changeSizeTo(new Dimension(640, 400));
169169
driver.manage().window().minimize();
170170
// TODO: how to verify the result of this operation?
171171
}
@@ -180,7 +180,7 @@ public void canFullscreenTheWindow() {
180180
assumeFalse(TestUtilities.getEffectivePlatform(driver).is(ANDROID));
181181

182182
try {
183-
changeSizeTo(new Dimension(640, 323));
183+
changeSizeTo(new Dimension(640, 400));
184184
enlargeBy(WebDriver.Window::fullscreen);
185185
} finally {
186186
driver.manage().window().setSize(new Dimension(640, 323));
@@ -198,7 +198,7 @@ public void canFullscreenTheWindowFromFrame() {
198198
assumeFalse(TestUtilities.getEffectivePlatform(driver).is(ANDROID));
199199

200200
driver.get(pages.framesetPage);
201-
changeSizeTo(new Dimension(640, 324));
201+
changeSizeTo(new Dimension(640, 400));
202202

203203
driver.switchTo().frame("fourth");
204204
enlargeBy(WebDriver.Window::fullscreen);
@@ -215,7 +215,7 @@ public void canFullscreenTheWindowFromIframe() {
215215
assumeFalse(TestUtilities.getEffectivePlatform(driver).is(ANDROID));
216216

217217
driver.get(pages.iframePage);
218-
changeSizeTo(new Dimension(640, 325));
218+
changeSizeTo(new Dimension(640, 400));
219219

220220
driver.switchTo().frame("iframe1-name");
221221
enlargeBy(WebDriver.Window::fullscreen);

java/test/org/openqa/selenium/devtools/WindowSwitchingTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,21 @@
11
package org.openqa.selenium.devtools;
22

3+
import static org.assertj.core.api.Assertions.assertThat;
4+
import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
5+
36
import org.junit.Test;
47
import org.openqa.selenium.WebDriver;
58
import org.openqa.selenium.WindowType;
69
import org.openqa.selenium.devtools.idealized.target.model.TargetInfo;
710
import org.openqa.selenium.remote.Augmenter;
11+
import org.openqa.selenium.testing.Ignore;
812

913
import java.util.List;
1014

11-
import static org.assertj.core.api.Assertions.assertThat;
12-
1315
public class WindowSwitchingTest extends DevToolsTestBase {
1416

1517
@Test
18+
@Ignore(FIREFOX)
1619
public void shouldBeAbleToSwitchWindowsAndCloseTheOriginal() {
1720
WebDriver driver = new Augmenter().augment(this.driver);
1821

0 commit comments

Comments
 (0)