Skip to content

Commit b4b76e2

Browse files
committed
[java] Removing deprecated ChromeDriverLogLevel
1 parent 8370c14 commit b4b76e2

File tree

4 files changed

+6
-111
lines changed

4 files changed

+6
-111
lines changed

java/src/org/openqa/selenium/chrome/ChromeDriverLogLevel.java

Lines changed: 0 additions & 72 deletions
This file was deleted.

java/src/org/openqa/selenium/chrome/ChromeDriverService.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -206,21 +206,6 @@ public Builder withBuildCheckDisabled(boolean noBuildCheck) {
206206
return this;
207207
}
208208

209-
/**
210-
* Configures the driver server verbosity.
211-
*
212-
* @param logLevel {@link ChromeDriverLogLevel} for desired log level output.
213-
* @return A self reference.
214-
* @deprecated use {@link #withLogLevel(ChromiumDriverLogLevel)} instead.
215-
*/
216-
@Deprecated
217-
public Builder withLogLevel(ChromeDriverLogLevel logLevel) {
218-
this.logLevel = ChromiumDriverLogLevel.fromString(logLevel.toString());
219-
this.silent = false;
220-
this.verbose = false;
221-
return this;
222-
}
223-
224209
/**
225210
* Configures the driver server log level.
226211
*

java/src/org/openqa/selenium/chrome/ChromeOptions.java

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -51,23 +51,13 @@ public class ChromeOptions extends ChromiumOptions<ChromeOptions> {
5151
/** Key used to store a set of ChromeOptions in a {@link Capabilities} object. */
5252
public static final String CAPABILITY = "goog:chromeOptions";
5353

54+
@SuppressWarnings("unused")
5455
public static final String LOGGING_PREFS = "goog:loggingPrefs";
55-
private ChromeDriverLogLevel logLevel;
5656

5757
public ChromeOptions() {
5858
super(CapabilityType.BROWSER_NAME, CHROME.browserName(), CAPABILITY);
5959
}
6060

61-
/**
62-
* @deprecated Use {@link ChromeDriverService.Builder#withLogLevel(ChromiumDriverLogLevel)} to set
63-
* log level.
64-
*/
65-
@Deprecated
66-
public ChromeOptions setLogLevel(ChromeDriverLogLevel logLevel) {
67-
this.logLevel = Require.nonNull("Log level", logLevel);
68-
return this;
69-
}
70-
7161
@Override
7262
public ChromeOptions merge(Capabilities extraCapabilities) {
7363
Require.nonNull("Capabilities to merge", extraCapabilities);
@@ -79,12 +69,4 @@ public ChromeOptions merge(Capabilities extraCapabilities) {
7969

8070
return newInstance;
8171
}
82-
83-
/**
84-
* @deprecated Log Level only applies to {@link ChromeDriverService}.
85-
*/
86-
@Deprecated
87-
public ChromeDriverLogLevel getLogLevel() {
88-
return logLevel;
89-
}
9072
}

java/test/org/openqa/selenium/chrome/ChromeOptionsTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
import static org.assertj.core.api.InstanceOfAssertFactories.LIST;
2424
import static org.assertj.core.api.InstanceOfAssertFactories.MAP;
2525
import static org.assertj.core.api.InstanceOfAssertFactories.STRING;
26-
import static org.openqa.selenium.chrome.ChromeDriverLogLevel.OFF;
27-
import static org.openqa.selenium.chrome.ChromeDriverLogLevel.SEVERE;
26+
import static org.openqa.selenium.chromium.ChromiumDriverLogLevel.OFF;
27+
import static org.openqa.selenium.chromium.ChromiumDriverLogLevel.SEVERE;
2828
import static org.openqa.selenium.remote.CapabilityType.ACCEPT_INSECURE_CERTS;
2929
import static org.openqa.selenium.remote.CapabilityType.TIMEOUTS;
3030

@@ -43,6 +43,7 @@
4343
import org.openqa.selenium.MutableCapabilities;
4444
import org.openqa.selenium.PageLoadStrategy;
4545
import org.openqa.selenium.UnexpectedAlertBehaviour;
46+
import org.openqa.selenium.chromium.ChromiumDriverLogLevel;
4647
import org.openqa.selenium.testing.TestUtilities;
4748

4849
@Tag("UnitTests")
@@ -69,8 +70,8 @@ void optionsAsMapShouldBeImmutable() {
6970

7071
@Test
7172
void canBuildLogLevelFromStringRepresentation() {
72-
assertThat(ChromeDriverLogLevel.fromString("off")).isEqualTo(OFF);
73-
assertThat(ChromeDriverLogLevel.fromString("SEVERE")).isEqualTo(SEVERE);
73+
assertThat(ChromiumDriverLogLevel.fromString("off")).isEqualTo(OFF);
74+
assertThat(ChromiumDriverLogLevel.fromString("SEVERE")).isEqualTo(SEVERE);
7475
}
7576

7677
@Test
@@ -363,7 +364,6 @@ void isW3CSafe() {
363364
new ChromeOptions()
364365
.setBinary("some/path")
365366
.addArguments("--headless")
366-
.setLogLevel(ChromeDriverLogLevel.INFO)
367367
.asMap();
368368

369369
Predicate<String> badKeys = new AcceptedW3CCapabilityKeys().negate();

0 commit comments

Comments
 (0)