Skip to content

Commit bec3298

Browse files
committed
Safari should only specify MAC as platform in default desired capabilities
Fixes #1186
1 parent cc0647a commit bec3298

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

dotnet/src/webdriver/Remote/DesiredCapabilities.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ public static DesiredCapabilities Opera()
280280
/// <returns>New instance of DesiredCapabilities for use with Safari</returns>
281281
public static DesiredCapabilities Safari()
282282
{
283-
return new DesiredCapabilities("safari", string.Empty, new Platform(PlatformType.Any));
283+
return new DesiredCapabilities("safari", string.Empty, new Platform(PlatformType.Mac));
284284
}
285285

286286
/// <summary>

java/client/src/org/openqa/selenium/remote/DesiredCapabilities.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ public static DesiredCapabilities operaBlink() {
252252
}
253253

254254
public static DesiredCapabilities safari() {
255-
return new DesiredCapabilities(BrowserType.SAFARI, "", Platform.ANY);
255+
return new DesiredCapabilities(BrowserType.SAFARI, "", Platform.MAC);
256256
}
257257

258258
public static DesiredCapabilities phantomjs() {

javascript/webdriver/capabilities.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,8 @@ webdriver.Capabilities.phantomjs = function() {
263263
*/
264264
webdriver.Capabilities.safari = function() {
265265
return new webdriver.Capabilities().
266-
set(webdriver.Capability.BROWSER_NAME, webdriver.Browser.SAFARI);
266+
set(webdriver.Capability.BROWSER_NAME, webdriver.Browser.SAFARI).
267+
set(webdriver.Capability.PLATFORM, 'MAC');
267268
};
268269

269270

py/selenium/webdriver/common/desired_capabilities.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class DesiredCapabilities(object):
8585
SAFARI = {
8686
"browserName": "safari",
8787
"version": "",
88-
"platform": "ANY",
88+
"platform": "MAC",
8989
"javascriptEnabled": True,
9090
}
9191

rb/lib/selenium/webdriver/remote/capabilities.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ def phantomjs(opts = {})
146146
def safari(opts = {})
147147
new({
148148
:browser_name => "safari",
149+
:platform => :mac,
149150
:javascript_enabled => true,
150151
:takes_screenshot => true,
151152
:css_selectors_enabled => true

0 commit comments

Comments
 (0)