Skip to content

Commit c067d6b

Browse files
committed
Re-registering node proxy in JMX on a node reconnect. Fixes #5186
1 parent ba71bfa commit c067d6b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

java/server/src/org/openqa/grid/selenium/proxy/DefaultRemoteProxy.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ public DefaultRemoteProxy(RegistrationRequest request, GridRegistry registry) {
7171
unregisterDelay = config.unregisterIfStillDownAfter != null ? config.unregisterIfStillDownAfter : DEFAULT_UNREGISTER_DELAY;
7272
downPollingLimit = config.downPollingLimit != null ? config.downPollingLimit : DEFAULT_DOWN_POLLING_LIMIT;
7373

74+
new JMXHelper().unregister(this.getObjectName());
7475
new JMXHelper().register(this);
7576
}
7677

java/server/src/org/openqa/selenium/remote/server/jmx/JMXHelper.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ public void unregister(ObjectName objectName) {
4141
MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
4242
try {
4343
mbs.unregisterMBean(objectName);
44-
} catch (Throwable t) {
45-
t.printStackTrace();
44+
} catch (Throwable ignore) {
4645
}
4746
}
4847
}

0 commit comments

Comments
 (0)