[rb] set a default file detector for Remote Driver

Author: titusfortner

rb/lib/selenium/webdriver/remote/driver.rb

@@ -42,6 +42,7 @@ def initialize(bridge: nil, listener: nil, **opts)
           end
           opts[:url] ||= "http://#{Platform.localhost}:4444/wd/hub"
           super
+          @bridge.file_detector = ->((filename, *)) { File.exist?(filename) && filename.to_s }
         end
 
         private

rb/spec/integration/selenium/webdriver/remote/driver_spec.rb

@@ -31,6 +31,20 @@ module Remote
           expect(driver).to be_kind_of(DriverExtensions::HasRemoteStatus)
           expect(driver.remote_status).to be_kind_of(Hash)
         end
+
+        it 'uses a default file detector' do
+          driver.navigate.to url_for('upload.html')
+
+          driver.find_element(id: 'upload').send_keys(__FILE__)
+          driver.find_element(id: 'go').submit
+          wait.until { driver.find_element(id: 'upload_label').displayed? }
+
+          driver.switch_to.frame('upload_target')
+          wait.until { driver.find_element(xpath: '//body') }
+
+          body = driver.find_element(xpath: '//body')
+          expect(body.text.scan('Licensed to the Software Freedom Conservancy').count).to eq(2)
+        end
       end
     end # Remote
   end # WebDriver

rb/spec/integration/selenium/webdriver/remote/element_spec.rb

@@ -31,7 +31,7 @@ module WebDriver
       end
 
       context 'when uploading one file' do
-        it 'uses the file detector' do
+        it 'uses the provided file detector' do
           driver.navigate.to url_for('upload.html')
 
           driver.find_element(id: 'upload').send_keys('element_spec.rb')
@@ -47,7 +47,7 @@ module WebDriver
       end
 
       context 'when uploading multiple files' do
-        it 'uses the file detector' do
+        it 'uses the provided file detector' do
           driver.navigate.to url_for('upload_multiple.html')
 
           driver.find_element(id: 'upload').send_keys("driver_spec.rb\nelement_spec.rb")
@@ -58,7 +58,7 @@ module WebDriver
           wait.until { driver.find_element(xpath: '//body') }
 
           body = driver.find_element(xpath: '//body')
-          expect(body.text.scan('Licensed to the Software Freedom Conservancy').count).to eq(4)
+          expect(body.text.scan('Licensed to the Software Freedom Conservancy').count).to eq(5)
         end
       end
     end