[java] Removing deprecated method in FirefoxProfile

Author: diemol

java/src/org/openqa/selenium/firefox/FirefoxProfile.java

@@ -310,13 +310,6 @@ public void cleanTemporaryModel() {
     clean(model);
   }
 
-  /**
-   * @deprecated This method will not be replaced as no default preferences are loaded anymore.
-   */
-  public void checkForChangesInFrozenPreferences() {
-    additionalPrefs.checkForChangesInFrozenPreferences();
-  }
-
   /**
    * Call this to cause the current profile to be written to disk. The profile directory is
    * returned. Note that this profile directory is a temporary one and will be deleted when the JVM

java/src/org/openqa/selenium/firefox/Preferences.java

@@ -17,8 +17,6 @@
 
 package org.openqa.selenium.firefox;
 
-import static org.openqa.selenium.json.Json.MAP_TYPE;
-
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.io.CharStreams;
 import com.google.common.io.Closeables;
@@ -39,6 +37,8 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
+import static org.openqa.selenium.json.Json.MAP_TYPE;
+
 class Preferences {
 
   /**
@@ -204,10 +204,6 @@ private boolean isStringified(String value) {
     return value.startsWith("\"") && value.endsWith("\"");
   }
 
-  void checkForChangesInFrozenPreferences() {
-    allPrefs.forEach((this::checkPreference));
-  }
-
   private void checkPreference(String key, Object value) {
     Require.nonNull("Key", key);
     Require.nonNull("Value", value);

java/test/org/openqa/selenium/firefox/PreferencesTest.java

@@ -17,16 +17,15 @@
 
 package org.openqa.selenium.firefox;
 
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
-
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
 
 import java.io.Reader;
 import java.io.StringReader;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 @Tag("UnitTests")
 class PreferencesTest {
 
@@ -105,17 +104,6 @@ void parsePreferences_multiline() {
     assertThat(prefs.getPreference("dom.max_script_run_time")).isEqualTo(32);
   }
 
-  @Test
-  void cannotOverrideAFrozenPreference() {
-    StringReader reader = new StringReader("{\"frozen\": {\"frozen.pref\": true }, \"mutable\": {}}");
-    Preferences preferences = new Preferences(reader);
-    preferences.setPreference("frozen.pref", false);
-
-    assertThatExceptionOfType(IllegalStateException.class)
-        .isThrownBy(preferences::checkForChangesInFrozenPreferences)
-        .withMessage("Preference frozen.pref may not be overridden: frozen value=true, requested value=false");
-  }
-
   @Test
   void canOverrideAFrozenPreferenceWithTheFrozenValue() {
     StringReader reader = new StringReader("{\"frozen\": {\"frozen.pref\": true }, \"mutable\": {}}");
@@ -126,19 +114,6 @@ void canOverrideAFrozenPreferenceWithTheFrozenValue() {
     assertThat(preferences.getPreference("frozen.pref")).isEqualTo(true);
   }
 
-  @Test
-  void canOverrideMaxScriptRuntimeIfGreaterThanDefaultValueOrSetToInfinity() {
-    Preferences preferences = new Preferences(defaults);
-    preferences.setPreference("dom.max_script_run_time", 29);
-
-    assertThatExceptionOfType(IllegalStateException.class)
-        .isThrownBy(preferences::checkForChangesInFrozenPreferences)
-        .withMessage("dom.max_script_run_time must be == 0 || >= 30");
-
-    preferences.setPreference("dom.max_script_run_time", 31);
-    preferences.setPreference("dom.max_script_run_time", 0);
-  }
-
   private boolean canSet(Preferences pref, String value) {
     try {
       pref.setPreference("key", value);