rb - update logging implementation to support chrome and safari by default

Author: titusfortner

rb/lib/selenium/webdriver/remote/bridge.rb

@@ -534,7 +534,11 @@ def getLog(type)
           data = execute :getLog, {}, :type => type.to_s
 
           Array(data).map do |l|
-            LogEntry.new l.fetch('level'), l.fetch('timestamp'), l.fetch('message')
+            begin
+              LogEntry.new l.fetch('level', 'UNKNOWN'), l.fetch('timestamp'), l.fetch('message')
+            rescue KeyError
+              next
+            end
           end
         end
 

rb/lib/selenium/webdriver/remote/capabilities.rb

@@ -74,8 +74,10 @@ def chrome(opts = {})
             new({
               :browser_name          => "chrome",
               :javascript_enabled    => true,
-              :css_selectors_enabled => true
-            }.merge(opts))
+              :css_selectors_enabled => true,
+              :loggingPrefs => {:browser => "ALL",
+                                :driver => "ALL"}
+                }.merge(opts))
           end
 
           def edge(opts = {})

rb/spec/integration/selenium/webdriver/options_spec.rb

@@ -24,21 +24,37 @@ module WebDriver
     describe Options do
 
       # Not supported in W3C Spec
-      not_compliant_on :driver => :marionette do
+      not_compliant_on :browser => :marionette do
         describe 'logs' do
-          compliant_on :driver => [:firefox] do
+          compliant_on :driver => :remote do
+            # Phantomjs Returns har instead of driver
+            not_compliant_on :browser => :phantomjs do
+              it 'can fetch available log types' do
+                expect(driver.manage.logs.available_types).to include(:browser, :driver, :server, :client)
+              end
+            end
+          end
+
+          # Phantomjs Returns har instead of driver
+          not_compliant_on :browser => :phantomjs do
             it 'can fetch available log types' do
-              expect(driver.manage.logs.available_types).to eq([:browser, :driver])
+              expect(driver.manage.logs.available_types).to include(:browser, :driver)
             end
+          end
 
+          # All other browsers show empty
+          compliant_on :browser => :firefox do
             it 'can get the browser log' do
               driver.navigate.to url_for("simpleTest.html")
 
               entries = driver.manage.logs.get(:browser)
               expect(entries).not_to be_empty
               expect(entries.first).to be_kind_of(LogEntry)
             end
+          end
 
+          # Phantomjs Returns har instead of driver
+          not_compliant_on :browser => :phantomjs do
             it 'can get the driver log' do
               driver.navigate.to url_for("simpleTest.html")