Skip to content

Commit d4d1108

Browse files
committed
[js] Remove more functions from firefox.Profile that are just holdovers from the
legacy FirefoxDriver
1 parent 647420b commit d4d1108

File tree

2 files changed

+7
-45
lines changed

2 files changed

+7
-45
lines changed

javascript/node/selenium-webdriver/CHANGES.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,13 @@ mode.
7474
- Added uninstallAddon(id)
7575
* Changes to `firefox.Options`
7676
- Removed setLoggingPreferences (was a no-op)
77+
* Changes to `firefox.Profile`
78+
- Removed no-op methods
79+
- acceptUntrustedCerts
80+
- assumeUntrustedCertIssuer
81+
- setAcceptUntrustedCerts
82+
- setAssumeUntrustedCertIssuer
83+
- setHost
7784
* Changes to `safari.Options`
7885
- Removed setCleanSession (was a no-op)
7986
- Removed setLoggingPreferences (was a no-op)

javascript/node/selenium-webdriver/firefox/profile.js

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -204,51 +204,6 @@ class Profile {
204204
return Object.assign({}, this.preferences_);
205205
}
206206

207-
/**
208-
* Specifies which host the driver should listen for commands on. If not
209-
* specified, the driver will default to "localhost". This option should be
210-
* specified when "localhost" is not mapped to the loopback address
211-
* (127.0.0.1) in `/etc/hosts`.
212-
*
213-
* @param {string} host the host the driver should listen for commands on
214-
*/
215-
setHost(host) {
216-
this.preferences_['webdriver_firefox_allowed_hosts'] = host;
217-
}
218-
219-
/**
220-
* @return {boolean} Whether the FirefoxDriver is configured to automatically
221-
* accept untrusted SSL certificates.
222-
*/
223-
acceptUntrustedCerts() {
224-
return !!this.preferences_['webdriver_accept_untrusted_certs'];
225-
}
226-
227-
/**
228-
* Sets whether the FirefoxDriver should automatically accept untrusted SSL
229-
* certificates.
230-
* @param {boolean} value .
231-
*/
232-
setAcceptUntrustedCerts(value) {
233-
this.preferences_['webdriver_accept_untrusted_certs'] = !!value;
234-
}
235-
236-
/**
237-
* Sets whether to assume untrusted certificates come from untrusted issuers.
238-
* @param {boolean} value .
239-
*/
240-
setAssumeUntrustedCertIssuer(value) {
241-
this.preferences_['webdriver_assume_untrusted_issuer'] = !!value;
242-
}
243-
244-
/**
245-
* @return {boolean} Whether to assume untrusted certs come from untrusted
246-
* issuers.
247-
*/
248-
assumeUntrustedCertIssuer() {
249-
return !!this.preferences_['webdriver_assume_untrusted_issuer'];
250-
}
251-
252207
/**
253208
* Writes this profile to disk.
254209
* @return {!Promise<string>} A promise for the path to the new profile

0 commit comments

Comments
 (0)