Skip to content

Commit e49e621

Browse files
committed
Remove Safari specific new window feature which no longer works; w3c compliant endpoint is available
1 parent f8e643f commit e49e621

File tree

2 files changed

+2
-62
lines changed

2 files changed

+2
-62
lines changed

java/src/org/openqa/selenium/safari/SafariDriver.java

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,11 @@
1717

1818
package org.openqa.selenium.safari;
1919

20-
import static java.util.Collections.singletonMap;
21-
22-
import org.openqa.selenium.Beta;
2320
import org.openqa.selenium.Capabilities;
2421
import org.openqa.selenium.WebDriverException;
2522
import org.openqa.selenium.remote.FileDetector;
2623
import org.openqa.selenium.remote.RemoteWebDriver;
27-
import org.openqa.selenium.remote.Response;
24+
import org.openqa.selenium.remote.service.DriverCommandExecutor;
2825

2926
/**
3027
* A WebDriver implementation that controls Safari using a browser extension
@@ -78,7 +75,7 @@ public SafariDriver(SafariDriverService safariService) {
7875
* @param safariOptions safari specific options / capabilities for the driver
7976
*/
8077
public SafariDriver(SafariDriverService safariServer, SafariOptions safariOptions) {
81-
super(new SafariDriverCommandExecutor(safariServer), safariOptions);
78+
super(new DriverCommandExecutor(safariServer), safariOptions);
8279
}
8380

8481
@Override
@@ -87,24 +84,4 @@ public void setFileDetector(FileDetector detector) {
8784
"Setting the file detector only works on remote webdriver instances obtained " +
8885
"via RemoteWebDriver");
8986
}
90-
91-
/**
92-
* Open either a new tab or window, depending on what is requested, and return the window handle
93-
* without switching to it.
94-
*
95-
* @return The handle of the new window.
96-
*/
97-
@Beta
98-
public String newWindow(WindowType type) {
99-
Response response = execute(
100-
"SAFARI_NEW_WINDOW",
101-
singletonMap("newTab", type == WindowType.TAB));
102-
103-
return (String) response.getValue();
104-
}
105-
106-
public enum WindowType {
107-
TAB,
108-
WINDOW,
109-
}
11087
}

java/src/org/openqa/selenium/safari/SafariDriverCommandExecutor.java

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)