adding selenium server pass throughs for W3C dialect of alert / window / cookie commands.

changing how W3C dialect is detected by checking if 'status' is sent in the new session response
switch to window in w3c passes in 'handle' variable instead of 'name'

Fixes #1242
Fixes #1241
Fixes #1240
Fixes #1238
Fixes #1237

Author: lukeis

java/client/src/org/openqa/selenium/BUCK

@@ -120,6 +120,7 @@ java_library(name = 'primitives',
   srcs = [
     'Dimension.java',
     'Point.java',
+    'Rectangle.java',
   ],
   visibility = [
     '//java/client/src/org/openqa/selenium/interactions:core',

java/client/src/org/openqa/selenium/Rectangle.java

@@ -0,0 +1,80 @@
+// Licensed to the Software Freedom Conservancy (SFC) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The SFC licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.openqa.selenium;
+
+public class Rectangle {
+
+  public int x;
+  public int y;
+  public int height;
+  public int width;
+
+  public Rectangle(int x, int y, int height, int width) {
+    this.x = x;
+    this.y = y;
+    this.height = height;
+    this.width = width;
+  }
+
+  public Rectangle(Point p, Dimension d) {
+    x = p.x;
+    y = p.y;
+    height = d.height;
+    width = d.width;
+  }
+
+  public int getX() {
+    return x;
+  }
+
+  public int getY() {
+    return y;
+  }
+
+  public void setX(int x) {
+    this.x = x;
+  }
+
+  public void setY(int y) {
+    this.y = y;
+  }
+
+  public int getHeight() {
+    return height;
+  }
+
+  public void setHeight(int height) {
+    this.height = height;
+  }
+
+  public int getWidth() {
+    return width;
+  }
+
+  public void setWidth(int width) {
+    this.width = width;
+  }
+
+  public Point getPoint() {
+    return new Point(x, y);
+  }
+
+  public Dimension getDimension() {
+    return new Dimension(x, y);
+  }
+}

java/client/src/org/openqa/selenium/WebDriver.java

@@ -238,7 +238,6 @@ interface Options {
     /**
      * @return the interface for managing the current window.
      */
-    @Beta
     Window window();
 
     /**
@@ -508,5 +507,10 @@ interface Window {
      * Maximizes the current window if it is not already maximized
      */
     void maximize();
+
+    /**
+     * Fullscreen the current window if it is not already fullscreen
+     */
+    void fullscreen();
   }
 }

java/client/src/org/openqa/selenium/WebElement.java

@@ -194,6 +194,11 @@ public interface WebElement extends SearchContext, TakesScreenshot {
    */
   Dimension getSize();
 
+  /**
+   * @return The location and size of the rendered element
+   */
+  Rectangle getRect();
+
   /**
    * Get the value of a given CSS property.
    * Color values should be returned as rgba strings, so,

java/client/src/org/openqa/selenium/build.desc

@@ -48,6 +48,7 @@ java_library(name = "webdriver-api",
     "NotFoundException.java",
     "OutputType.java",
     "Proxy.java",
+    "Rectangle.java",
     "Rotatable.java",
     "ScreenOrientation.java",
     "SearchContext.java",

java/client/src/org/openqa/selenium/firefox/MarionetteDriver.java

@@ -73,11 +73,6 @@ public MarionetteDriver(GeckoDriverService service, Capabilities capabilities,
     run(service, capabilities);
   }
 
-  @Override
-  public int getW3CStandardComplianceLevel() {
-    return 1;
-  }
-
   private void run(GeckoDriverService service, Capabilities capabilities) {
     setCommandExecutor(new DriverCommandExecutor(service));
 

java/client/src/org/openqa/selenium/htmlunit/HtmlUnitDriver.java

@@ -1678,6 +1678,11 @@ public void maximize() {
       setSize(initialWindowDimension);
       setPosition(new Point(0, 0));
     }
+
+    @Override
+    public void fullscreen() {
+      maximize();
+    }
   }
 
   @Override

java/client/src/org/openqa/selenium/htmlunit/HtmlUnitWebElement.java

@@ -34,6 +34,7 @@
 import org.openqa.selenium.NoSuchElementException;
 import org.openqa.selenium.OutputType;
 import org.openqa.selenium.Point;
+import org.openqa.selenium.Rectangle;
 import org.openqa.selenium.StaleElementReferenceException;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebDriverException;
@@ -513,6 +514,10 @@ public Dimension getSize() {
     }
   }
 
+  public Rectangle getRect() {
+    return new Rectangle(getLocation(), getSize());
+  }
+
   private int readAndRound(final String property) {
     final String cssValue = getCssValue(property).replaceAll("[^0-9\\.]", "");
     if (cssValue.length() == 0) {

java/client/src/org/openqa/selenium/remote/DriverCommand.java

@@ -40,6 +40,7 @@ public interface DriverCommand {
 
   String ADD_COOKIE = "addCookie";
   String GET_ALL_COOKIES = "getCookies";
+  String GET_COOKIE = "getCookie";
   String DELETE_COOKIE = "deleteCookie";
   String DELETE_ALL_COOKIES = "deleteAllCookies";
 
@@ -56,8 +57,9 @@ public interface DriverCommand {
   String UPLOAD_FILE = "uploadFile";
 
   String GET_CURRENT_WINDOW_HANDLE = "getCurrentWindowHandle";
-  String GET_CURRENT_WINDOW_HANDLE_LEVEL_1 = "getCurrentWindowHandleLevel1";
   String GET_WINDOW_HANDLES = "getWindowHandles";
+  String GET_WINDOW_HANDLES_W3C = "getWindowHandlesW3C";
+  String GET_CURRENT_WINDOW_HANDLE_W3C = "getCurrentWindowHandleW3C";
 
   String GET_CURRENT_CONTEXT_HANDLE = "getCurrentContextHandle";
   String GET_CONTEXT_HANDLES = "getContextHandles";
@@ -74,6 +76,8 @@ public interface DriverCommand {
 
   String EXECUTE_SCRIPT = "executeScript";
   String EXECUTE_ASYNC_SCRIPT = "executeAsyncScript";
+  String EXECUTE_SCRIPT_W3C = "executeScriptW3C";
+  String EXECUTE_ASYNC_SCRIPT_W3C = "executeAsyncScriptW3C";
 
   String GET_ELEMENT_TEXT = "getElementText";
   String GET_ELEMENT_TAG_NAME = "getElementTagName";
@@ -97,6 +101,11 @@ public interface DriverCommand {
   String SET_ALERT_VALUE = "setAlertValue";
   String SET_ALERT_CREDENTIALS = "setAlertCredentials";
 
+  String ACCEPT_ALERT_W3C = "acceptAlertW3C";
+  String DISMISS_ALERT_W3C = "dimissAlertW3C";
+  String GET_ALERT_TEXT_W3C = "getAlertTextW3C";
+  String SET_ALERT_VALUE_W3C = "setAlertValueW3C";
+
   String SET_TIMEOUT = "setTimeout";
   String IMPLICITLY_WAIT = "implicitlyWait";
   String SET_SCRIPT_TIMEOUT = "setScriptTimeout";
@@ -165,6 +174,7 @@ public interface DriverCommand {
   String SET_CURRENT_WINDOW_SIZE = "setCurrentWindowSize";
   String GET_CURRENT_WINDOW_SIZE = "getCurrentWindowSize";
   String MAXIMIZE_CURRENT_WINDOW = "maximizeCurrentWindow";
+  String FULLSCREEN_CURRENT_WINDOW = "fullscreenCurrentWindow";
 
   // Logging API
   String GET_AVAILABLE_LOG_TYPES = "getAvailableLogTypes";

java/client/src/org/openqa/selenium/remote/ErrorCodes.java

@@ -248,7 +248,7 @@ public boolean isMappableError(Throwable thrown) {
     return statusCode != SUCCESS && statusCode != UNHANDLED_ERROR;
   }
 
-  public static String toState(int status) {
+  public static String toState(Integer status) {
     return statusToState.get(status);
   }