Skip to content

Commit ff5e9a5

Browse files
committed
[rb] clarify cookie testss
1 parent d06a6ee commit ff5e9a5

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

rb/spec/integration/selenium/webdriver/manager_spec.rb

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,14 @@ module WebDriver
3939
expect(cookie[:secure]).to be(false)
4040
end
4141

42-
it 'sets samesite property of Default by default',
43-
except: [{browser: %i[chrome edge],
44-
reason: 'https://bugs.chromium.org/p/chromedriver/issues/detail?id=3732'},
45-
{browser: :firefox,
46-
reason: 'https://github.com/mozilla/geckodriver/issues/1841'}],
42+
it 'sets samesite property of Lax by default',
43+
except: {browser: :firefox,
44+
reason: 'https://github.com/mozilla/geckodriver/issues/1841'},
4745
only: {browser: %i[chrome edge firefox]} do
4846
driver.manage.add_cookie name: 'samesite',
4947
value: 'default'
5048

51-
expect(driver.manage.cookie_named('samesite')[:same_site]).to eq('Default')
49+
expect(driver.manage.cookie_named('samesite')[:same_site]).to eq('Lax')
5250
end
5351

5452
it 'respects path' do
@@ -90,10 +88,8 @@ module WebDriver
9088
end
9189

9290
it 'does not allow setting on a subdomain from parent domain',
93-
except: {browser: :chrome,
94-
reason: 'https://bugs.chromium.org/p/chromedriver/issues/detail?id=3734'},
9591
exclusive: {driver: :none,
96-
reason: 'Can only be tested on site with subdomains'} do
92+
reason: 'Can not run on our test server; needs subdomains'} do
9793
driver.get('https://saucelabs.com')
9894

9995
expect {
@@ -113,10 +109,11 @@ module WebDriver
113109
end
114110

115111
it 'does not add secure cookie when http',
116-
except: [{browser: :firefox,
117-
reason: 'https://github.com/mozilla/geckodriver/issues/1840'},
118-
{browser: %i[chrome edge],
119-
reason: 'https://bugs.chromium.org/p/chromium/issues/detail?id=1177877#c7'}] do
112+
except: {browser: :firefox,
113+
reason: 'https://github.com/mozilla/geckodriver/issues/1840'},
114+
exclusive: {driver: :none,
115+
reason: 'Cannot be tested on localhost'} do
116+
driver.get 'http://watir.com'
120117
driver.manage.add_cookie name: 'secure',
121118
value: 'http',
122119
secure: true

0 commit comments

Comments
 (0)