Skip to content

Fix/issue with timestamp at point #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Sep 2, 2022

Solves #974
Caused by two underlying issues:

  • The function TimeSeries.get_index_at_point() was not behaving as expected on integer-indexed series with index not starting at 0
  • The historical forecasts was having an issue when building the resulting series (when last_points_only=True) with stride>1.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Base: 93.73% // Head: 93.72% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f478a13) compared to base (0597937).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
- Coverage   93.73%   93.72%   -0.01%     
==========================================
  Files          83       83              
  Lines        8398     8387      -11     
==========================================
- Hits         7872     7861      -11     
  Misses        526      526              
Impacted Files Coverage Δ
darts/models/forecasting/forecasting_model.py 96.49% <ø> (ø)
darts/timeseries.py 92.24% <100.00%> (-0.05%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 87.45% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 98.55% <0.00%> (-0.02%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hrzn hrzn closed this Sep 6, 2022
@madtoinou madtoinou deleted the fix/issue-with-timestamp-at-point branch July 5, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants