-
Notifications
You must be signed in to change notification settings - Fork 600
Comparing changes
Open a pull request
base repository: serde-rs/json
base: v1.0.114
head repository: serde-rs/json
compare: v1.0.115
- 10 commits
- 12 files changed
- 2 contributors
Commits on Feb 26, 2024
-
Ignore non_local_definitions false positive in test
rust-lang/rust#121621 warning: non-local `impl` definition, they should be avoided as they go against expectation --> tests/test.rs:2338:5 | 2338 | / impl<'de> Deserialize<'de> for &'de RawMapKey { 2339 | | fn deserialize<D>(deserializer: D) -> Result<Self, D::Error> 2340 | | where 2341 | | D: serde::Deserializer<'de>, ... | 2345 | | } 2346 | | } | |_____^ | = help: move this `impl` block outside the of the current function `test_raw_value_in_map_key` = note: an `impl` definition is non-local if it is nested inside an item and neither the type nor the trait are at the same nesting level as the `impl` block = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <rust-lang/rust#120363> = note: `#[warn(non_local_definitions)]` on by default
Configuration menu - View commit details
-
Copy full SHA for fedf834 - Browse repository at this point
Copy the full SHA fedf834View commit details
Commits on Mar 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a25f6c6 - Browse repository at this point
Copy the full SHA a25f6c6View commit details -
Merge pull request #1118 from serde-rs/transparent
Remove conditional on repr(transparent)
Configuration menu - View commit details
-
Copy full SHA for 8e7b37b - Browse repository at this point
Copy the full SHA 8e7b37bView commit details
Commits on Mar 24, 2024
-
Ignore dead code lint in tests
New in nightly-2024-03-24 from rust-lang/rust#119552. warning: field `x` is never read --> tests/regression/issue795.rs:11:15 | 11 | Variant { x: u8 }, | ------- ^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default warning: field `i` is never read --> tests/regression/issue845.rs:63:9 | 61 | pub struct Struct { | ------ field in this struct 62 | #[serde(deserialize_with = "deserialize_integer_or_string")] 63 | pub i: i64, | ^ | = note: `Struct` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
Configuration menu - View commit details
-
Copy full SHA for d2dbbf7 - Browse repository at this point
Copy the full SHA d2dbbf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a0be88 - Browse repository at this point
Copy the full SHA 4a0be88View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3a3f61b - Browse repository at this point
Copy the full SHA 3a3f61bView commit details -
Fix missing backticks in doc comments
This was leading to rustdocs markdown parser to interpret slices like &[u8] as & and a link to u8
Configuration menu - View commit details
-
Copy full SHA for 840da8e - Browse repository at this point
Copy the full SHA 840da8eView commit details
Commits on Mar 26, 2024
-
Explicitly install a Rust toolchain for cargo-outdated job
Debugging a recent cargo-outdated bug, it would have been nice not to wonder whether a rustc version change in GitHub's runner image was a contributing factor.
Configuration menu - View commit details
-
Copy full SHA for 218770b - Browse repository at this point
Copy the full SHA 218770bView commit details -
Merge pull request #1119 from titaniumtraveler/pr
Fix missing backtick in doc comments letting markdown think &[u8] is a link to u8
Configuration menu - View commit details
-
Copy full SHA for c3dc153 - Browse repository at this point
Copy the full SHA c3dc153View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1ebf38 - Browse repository at this point
Copy the full SHA b1ebf38View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.114...v1.0.115