-
Notifications
You must be signed in to change notification settings - Fork 31
Georgian data processor #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ssofja
commented
May 20, 2024
- Added config file for Georgian MCV dataset
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, a few small changes
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just requesting one tiny fix to correct the formatting. So that if anyone bases their configs based on yours, they will also have correct formatting
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
I see that there are some tests failing due to some lhotse requirements issues. Lilit is including a fix in this PR: #61. Let's merge your PR once the fix is merged into main.
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
* Added georgian mcv dataset config file Signed-off-by: Ssofja <sofiakostandian@gmail.com> * add georgian documentation Signed-off-by: Ssofja <sofiakostandian@gmail.com> * add DropRepeatedFields processors Signed-off-by: Ssofja <sofiakostandian@gmail.com> * fix docs Signed-off-by: Ssofja <sofiakostandian@gmail.com> * fix config Signed-off-by: Ssofja <sofiakostandian@gmail.com> * added needed changes Signed-off-by: Ssofja <sofiakostandian@gmail.com> * deleted not needed spaces Signed-off-by: Ssofja <sofiakostandian@gmail.com> --------- Signed-off-by: Ssofja <sofiakostandian@gmail.com>
* Added georgian mcv dataset config file Signed-off-by: Ssofja <sofiakostandian@gmail.com> * add georgian documentation Signed-off-by: Ssofja <sofiakostandian@gmail.com> * add DropRepeatedFields processors Signed-off-by: Ssofja <sofiakostandian@gmail.com> * fix docs Signed-off-by: Ssofja <sofiakostandian@gmail.com> * fix config Signed-off-by: Ssofja <sofiakostandian@gmail.com> * added needed changes Signed-off-by: Ssofja <sofiakostandian@gmail.com> * deleted not needed spaces Signed-off-by: Ssofja <sofiakostandian@gmail.com> --------- Signed-off-by: Ssofja <sofiakostandian@gmail.com>