Skip to content

Georgian data processor #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 20, 2024
Merged

Georgian data processor #59

merged 11 commits into from
Aug 20, 2024

Conversation

Ssofja
Copy link
Collaborator

@Ssofja Ssofja commented May 20, 2024

  • Added config file for Georgian MCV dataset

@Ssofja Ssofja self-assigned this May 20, 2024
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Ssofja added 5 commits May 24, 2024 17:43
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Copy link
Collaborator

@erastorgueva-nv erastorgueva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, a few small changes

Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Copy link
Collaborator

@erastorgueva-nv erastorgueva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just requesting one tiny fix to correct the formatting. So that if anyone bases their configs based on yours, they will also have correct formatting

Copy link
Collaborator

@erastorgueva-nv erastorgueva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
I see that there are some tests failing due to some lhotse requirements issues. Lilit is including a fix in this PR: #61. Let's merge your PR once the fix is merged into main.

Ssofja added 2 commits August 16, 2024 12:50
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
@erastorgueva-nv erastorgueva-nv merged commit 208b09c into NVIDIA:main Aug 20, 2024
3 of 4 checks passed
rimashahbazyan pushed a commit that referenced this pull request Aug 29, 2024
* Added georgian mcv dataset config file

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* add georgian documentation

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* add DropRepeatedFields processors

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* fix docs

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* fix config

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* added needed changes

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* deleted not needed spaces

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

---------

Signed-off-by: Ssofja <sofiakostandian@gmail.com>
monica-sekoyan pushed a commit to monica-sekoyan/NeMo-speech-data-processor that referenced this pull request Oct 5, 2024
* Added georgian mcv dataset config file

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* add georgian documentation

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* add DropRepeatedFields processors

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* fix docs

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* fix config

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* added needed changes

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

* deleted not needed spaces

Signed-off-by: Ssofja <sofiakostandian@gmail.com>

---------

Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants