[nvbug 5304752][fix] enhance _check_arguments to filter illegal requests for pytorch backend #5541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/bot run |
|
PR_Github #10126 [ run ] triggered by Bot |
|
PR_Github #10126 [ run ] completed with state |
d0023fa to
7635b98
Compare
|
/bot run |
|
PR_Github #10147 [ run ] triggered by Bot |
|
PR_Github #10147 [ run ] completed with state |
kaiyux
reviewed
Jul 1, 2025
Superjomn
reviewed
Jul 1, 2025
Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
7635b98 to
a036283
Compare
|
/bot run |
|
PR_Github #10584 [ run ] triggered by Bot |
|
PR_Github #10584 [ run ] completed with state |
|
@kaiyux @Superjomn I think the latest change should resolve the previous reviews, do you have any other concerns? |
|
/bot run |
|
PR_Github #11136 [ run ] triggered by Bot |
|
PR_Github #11136 [ run ] completed with state |
kaiyux
approved these changes
Jul 7, 2025
dc3671
pushed a commit
to dc3671/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
…sts for pytorch backend (NVIDIA#5541) Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
dc3671
pushed a commit
to dc3671/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
…sts for pytorch backend (NVIDIA#5541) Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
dc3671
pushed a commit
to dc3671/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
…sts for pytorch backend (NVIDIA#5541) Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
dc3671
pushed a commit
to dc3671/TensorRT-LLM
that referenced
this pull request
Jul 11, 2025
…sts for pytorch backend (NVIDIA#5541) Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
dc3671
pushed a commit
to dc3671/TensorRT-LLM
that referenced
this pull request
Jul 14, 2025
…sts for pytorch backend (NVIDIA#5541) Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
dc3671
pushed a commit
to dc3671/TensorRT-LLM
that referenced
this pull request
Jul 14, 2025
…sts for pytorch backend (NVIDIA#5541) Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
dc3671
pushed a commit
to dc3671/TensorRT-LLM
that referenced
this pull request
Jul 14, 2025
…sts for pytorch backend (NVIDIA#5541) Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
dc3671
pushed a commit
that referenced
this pull request
Jul 14, 2025
…sts for pytorch backend (#5541) Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
LinPoly
added a commit
to LinPoly/TensorRT-LLM
that referenced
this pull request
Jul 17, 2025
…al requests for pytorch backend (NVIDIA#5541)" This reverts commit 388b491. Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
LinPoly
added a commit
to LinPoly/TensorRT-LLM
that referenced
this pull request
Jul 18, 2025
…al requests for pytorch backend (NVIDIA#5541)" This reverts commit 388b491. Signed-off-by: Pengyun Lin <81065165+LinPoly@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add check against the prompt length, to prevent a single illegal request from killing by the pytorch executor.
Test Coverage
Extend the backend of
test_llm_capture_request_errorto test pytorch backend.GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.