Skip to content

chore: Cleanup disable_fp4_allgather. #6006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025

Conversation

bobboli
Copy link
Collaborator

@bobboli bobboli commented Jul 14, 2025

PR title

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

disable_fp4_allgather was once used due to accuracy issue. It is useless now and cleaned up for tidiness.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
@bobboli bobboli requested a review from yuxianq July 14, 2025 13:40
@bobboli bobboli requested a review from a team as a code owner July 14, 2025 13:40
@bobboli bobboli requested a review from nv-yilinf July 14, 2025 13:40
@bobboli
Copy link
Collaborator Author

bobboli commented Jul 14, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11819 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11819 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8759 completed with status: 'FAILURE'

@bobboli
Copy link
Collaborator Author

bobboli commented Jul 14, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11832 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11832 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8768 completed with status: 'FAILURE'

bobboli added 3 commits July 16, 2025 11:50
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
…ays false.

Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
@bobboli
Copy link
Collaborator Author

bobboli commented Jul 16, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12020 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12020 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8926 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
@bobboli
Copy link
Collaborator Author

bobboli commented Jul 16, 2025

/bot skip --comment "Comment change only"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12071 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12071 [ skip ] completed with state SUCCESS
Skipping testing for commit 952b152

@bobboli bobboli merged commit fc2347e into NVIDIA:main Jul 16, 2025
3 checks passed
evezhier pushed a commit to evezhier/TensorRT-LLM that referenced this pull request Jul 16, 2025
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
yizhang-nv pushed a commit to yizhang-nv/TensorRT-LLM that referenced this pull request Jul 17, 2025
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants