Build fails for `go debug-server`

[seanpoulter]

Meta

OS: Windows 7
Selenium Version: master, 5b37f7e
Browser: N/A
Browser Version: N/A
JDK: javac 1.8.0_151

Expected Behavior -

Running go debug-server from the HEAD of the master branch should build / start / start tests.

Actual Behavior -

The build fails with the message No system compiler found. Did you install the JRE instead of the JDK?.

d:\software\dev\selenium>go debug-server
(in D:/software/dev/selenium)
Oct 25, 2017 12:48:46 AM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: logged_in=no; domain=.github.com; path=/; expires=Sun, 25 Oct 2037 04:49:07
 -0000; secure; HttpOnly". Invalid 'expires' attribute: Sun, 25 Oct 2037 04:49:07 -0000
python D:/software/dev/selenium/buck-out/crazy-fun/be2bf932342e5d67f58c9b26f5065c745d285d0d/buck.pex kill
Not using buckd because watchman isn't installed.
PARSING BUCK FILES... 4.4s (100%)
CREATING ACTION GRAPH: FINISHED IN 0.3s
BUILT 1/137 JOBS 0.5s //java/client/src/org/openqa/selenium:build-stamp
BUILT 2/137 JOBS 0.6s //java/client/src/org/openqa/selenium:template-pom
BUILT 3/137 JOBS 0.6s //third_party/java/servlet:servlet-api
BUILT 4/137 JOBS 0.6s //third_party/java/gson:gson
BUILT 5/137 JOBS 0.3s //third_party/java/commons-codec:commons-codec
BUILT 6/137 JOBS 0.6s //third_party/java/commons-logging:commons-logging#class-abi
BUILT 7/137 JOBS 0.8s //third_party/java/gson:gson#class-abi
BUILT 8/137 JOBS 0.2s //third_party/java/commons:commons-exec#class-abi
BUILT 9/137 JOBS 1.1s //third_party/java/httpcomponents:httpclient#class-abi
BUILT 10/137 JOBS 0.4s //third_party/java/httpcomponents:httpcore
BUILT 11/137 JOBS 0.4s //third_party/java/commons:commons-exec
BUILT 12/137 JOBS 1.3s //third_party/java/guava:guava
BUILT 13/137 JOBS 0.3s //third_party/java/commons-logging:commons-logging
BUILT 14/137 JOBS 0.2s //third_party/java/commons-codec:commons-codec#class-abi
BUILT 15/137 JOBS 0.3s //third_party/java/servlet:servlet-api#class-abi
BUILT 16/137 JOBS 0.3s //third_party/java/httpcomponents:httpcore#class-abi
BUILT 17/137 JOBS 0.1s //third_party/java/jetty:jarjar-rules
BUILT 18/137 JOBS 0.2s //javascript/atoms:bot
BUILT 19/137 JOBS 0.2s //javascript/atoms:errors
BUILT 20/137 JOBS 0.3s //third_party/java/inject:javax.inject
BUILT 21/137 JOBS 2.0s //third_party/java/guava:guava#class-abi
BUILT 22/137 JOBS 0.5s //third_party/java/sisu:org.eclipse.sisu.inject
BUILT 23/137 JOBS 0.2s //third_party/java/plexus:plexus-component-annotations
BUILT 24/137 JOBS 0.4s //third_party/java/annotation:jsr250-api
BUILT 25/137 JOBS 2.1s //third_party/java/bytebuddy:bytebuddy
BUILT 26/137 JOBS 0.4s //third_party/java/plexus:plexus-utils
BUILT 27/137 JOBS 0.3s //third_party/java/ant:ant-launcher
BUILT 28/137 JOBS 0.2s //third_party/java/hamcrest:hamcrest-core
BUILT 29/137 JOBS 0.3s //third_party/java/plexus:plexus-classworlds
BUILT 30/137 JOBS 0.3s //third_party/java/asm:asm
BUILT 34/137 JOBS 2.1s //third_party/java/bytebuddy:bytebuddy#class-abi
BUILT 35/137 JOBS 2.6s //third_party/closure:compiler-jar
BUILD FAILED: //java/client/src/org/openqa/selenium:beta failed:
javac -source 8 -target 8 -sourcepath  -g -proc:none -d D:\software\dev\selenium\buck-out\bin\java\client\src
\org\openqa\selenium\lib__beta__classes -classpath '' @buck-out\gen\java\client\src\org\openqa\selenium\__beta__srcs; ja
r cf buck-out\gen\java\client\src\org\openqa\selenium\lib__beta__output\beta.jar  buck-out\bin\java\client\src\org\openq
a\selenium\lib__beta__classes
No system compiler found. Did you install the JRE instead of the JDK?
BUILT 36/137 JOBS 10.1s //third_party/closure:closure
DOWNLOADED 0.00 BYTES/SEC AVG, 0 ARTIFACTS, 0.00 BYTES
BUILDING: FINISHED IN 20.0s (100%) 36/137 JOBS, 36 UPDATED, 25.5% CACHE MISS
BUILD FAILED
go aborted!
Buck build failed with exit code: 1
stdout:

(See full trace by running task with --trace)

To confirm, java, javac, and jar are also on the PATH:

> where java
C:\ProgramData\Oracle\Java\javapath\java.exe
C:\Program Files (x86)\Java\jdk1.8.0_151\bin\java.exe

> where javac
C:\Program Files (x86)\Java\jdk1.8.0_151\bin\javac.exe

> where jar
C:\Program Files (x86)\Java\jdk1.8.0_151\bin\jar.exe

Steps to reproduce -

1. Clone the repo
2. Install Java JDK 8 per the Requirements
3. Set JAVA_HOME to C:\Program Files (x86)\Java\jdk1.8.0_151
4. Add JAVA_HOME to the PATH
5. Run go debug-server in the terminal

[seanpoulter]

This is a known issue with Java, and there's an open issue in Buck. Can we update the Requirements docs to indicate that either:

• A file needs to be copied from the JDK to the JRE folder (lib/tools.jar)
• The environment variables must be configured to use java from the JDK, not JRE (default)