Skip to content

[java] Updating extraInfo object type in WebDriverException class #9926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hornyja4
Copy link
Contributor

Description

Changing type of extraInfo from HashMap to ConcurrentHasMap in WebDriverException class.

Motivation and Context

To avoid ConcurrentModificationException while reading exception message by parallel threads.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ConcurrentModificationException while reading exception message by parallel threads.
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hornyja4! Congrats on your first contribution 🎉

For context, this PR comes from this Slack conversation held on October 14, 2021.
image

@diemol diemol merged commit 1b81a90 into SeleniumHQ:trunk Oct 25, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
…ConcurrentModificationException while reading exception message by parallel threads. (SeleniumHQ#9926)

Co-authored-by: Jan Hornych <jan.hornych@smartea.tech>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants