-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Enable multi-reg LONG
nodes on 32 bit
#76263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multi-reg LONG
nodes on 32 bit
#76263
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsOr, rather, enable promotion of multi-reg The diffs are nice and simple: - mov dword ptr [esp], eax
- mov dword ptr [esp+04H], edx
- mov eax, dword ptr [esp]
- mov edx, dword ptr [esp+04H]
add eax, -1
adc edx, -1 And also numerous (
|
@dotnet/jit-contrib |
@TIHan perhaps you can review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit comment and a question.
I am not able to see |
No, unfortunately... Let's rerun the whole CI to get fresher coverage. |
GH doesn't show it, but |
Or, rather, enable promotion of multi-reg
LONG
variables, unblocking field enregistration.The diffs (x86) are nice and simple:
And also numerous (
-35K
for the benchmarks collection on x86).