Skip to content

Enable multi-reg LONG nodes on 32 bit #76263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Sep 27, 2022

Or, rather, enable promotion of multi-reg LONG variables, unblocking field enregistration.

The diffs (x86) are nice and simple:

-       mov      dword ptr [esp], eax
-       mov      dword ptr [esp+04H], edx
-       mov      eax, dword ptr [esp]
-       mov      edx, dword ptr [esp+04H]
        add      eax, -1
        adc      edx, -1

And also numerous (-35K for the benchmarks collection on x86).

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Sep 27, 2022
@ghost
Copy link

ghost commented Sep 27, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Or, rather, enable promotion of multi-reg LONG variables, unblocking field enregistration.

The diffs are nice and simple:

-       mov      dword ptr [esp], eax
-       mov      dword ptr [esp+04H], edx
-       mov      eax, dword ptr [esp]
-       mov      edx, dword ptr [esp+04H]
        add      eax, -1
        adc      edx, -1

And also numerous (-35K for the benchmarks collection on x86).

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review September 27, 2022 22:08
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@AndyAyersMS
Copy link
Member

@TIHan perhaps you can review this one?

Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit comment and a question.

@kunalspathak
Copy link
Contributor

I am not able to see arm Release failures. Tried rerunning the jobs, but they are not getting scheduled. Do you remember what the failure was?

@SingleAccretion
Copy link
Contributor Author

No, unfortunately... Let's rerun the whole CI to get fresher coverage.

@SingleAccretion
Copy link
Contributor Author

@kunalspathak kunalspathak merged commit 041aa3b into dotnet:main Oct 25, 2022
@SingleAccretion SingleAccretion deleted the Multi-Reg-Longs-Upstream branch October 25, 2022 16:23
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants