Skip to content

[PERF] Fix Linux arm64 AOT ROOTFS_DIR missing (Less Impactful) #77027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 14, 2022

Conversation

LoopedBard3
Copy link
Member

This adds the ROOTFS_DIR variable to the global-build-job for Linux AOT Arm64. This is a less impactful and smaller update to fix the problem than #77024 as this does not change global-build-job. Although it may still be worthwhile to check if the crossrootfsDir condition is incorrect and fix it.

Working build with the change: https://dev.azure.com/dnceng/internal/_build/results?buildId=2020245&view=logs&j=29aef6bf-22ff-5269-0c67-e98540f696db&t=d29db927-bdb9-52f6-e00d-5ad3c37b6beb

@ghost
Copy link

ghost commented Oct 13, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This adds the ROOTFS_DIR variable to the global-build-job for Linux AOT Arm64. This is a less impactful and smaller update to fix the problem than #77024 as this does not change global-build-job. Although it may still be worthwhile to check if the crossrootfsDir condition is incorrect and fix it.

Working build with the change: https://dev.azure.com/dnceng/internal/_build/results?buildId=2020245&view=logs&j=29aef6bf-22ff-5269-0c67-e98540f696db&t=d29db927-bdb9-52f6-e00d-5ad3c37b6beb

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-coreclr

Milestone: -

@sblom sblom self-requested a review October 13, 2022 22:47
@LoopedBard3 LoopedBard3 changed the title [PERF] Fix Linux arm64 AOT ROOTFS_DIR missing Less Impactful [PERF] Fix Linux arm64 AOT ROOTFS_DIR missing (Less Impactful) Oct 13, 2022
@LoopedBard3
Copy link
Member Author

This does not have any changes affecting non-perf infra or testing. A run with all impacted spots: https://dev.azure.com/dnceng/internal/_build/results?buildId=2020343&view=logs&j=b883b527-f236-5b5f-eaf1-fa938ac20612.

@LoopedBard3 LoopedBard3 merged commit ff4d324 into dotnet:main Oct 14, 2022
@LoopedBard3 LoopedBard3 deleted the PerfSlowFixLinuxAOTAlternative branch October 14, 2022 03:24
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants