Skip to content

Add AVX-512 testing pipeline #77930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

BruceForstall
Copy link
Contributor

Introduce DOTNET_JitForceEVEXEncoding to force EVEX encoding when possible. This will fail when not an an AVX-512 capable machine, by design (to know we are properly testing on capable machines).

Current pipeline definition only runs coreclr tests with JitForceEVEXEncoding set. Currently defined to automatically trigger when one of the JIT files instrsxarch.h, emitxarch.cpp, or emitxarch.h are changed, as it is expected these will be changed frequently as the AVX-512 feature is implemented. It is also expected this will be manually triggered as appropriate. Eventually, this pipeline will be removed and tests folded into the existing jitstress-isas-x86 pipeline.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 4, 2022
@ghost ghost assigned BruceForstall Nov 4, 2022
@ghost
Copy link

ghost commented Nov 4, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Introduce DOTNET_JitForceEVEXEncoding to force EVEX encoding when possible. This will fail when not an an AVX-512 capable machine, by design (to know we are properly testing on capable machines).

Current pipeline definition only runs coreclr tests with JitForceEVEXEncoding set. Currently defined to automatically trigger when one of the JIT files instrsxarch.h, emitxarch.cpp, or emitxarch.h are changed, as it is expected these will be changed frequently as the AVX-512 feature is implemented. It is also expected this will be manually triggered as appropriate. Eventually, this pipeline will be removed and tests folded into the existing jitstress-isas-x86 pipeline.

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall
Copy link
Contributor Author

cc @dotnet/jit-contrib

Introduce DOTNET_JitForceEVEXEncoding to force EVEX encoding when
possible. This will fail when not an an AVX-512 capable machine,
by design (to know we are properly testing on capable machines).

Current pipeline definition only runs coreclr tests with
JitForceEVEXEncoding set. Currently defined to automatically trigger when
one of the JIT files instrsxarch.h, emitxarch.cpp, or emitxarch.h are
changed, as it is expected these will be changed frequently as the AVX-512
feature is implemented. It is also expected this will be manually triggered
as appropriate. Eventually, this pipeline will be removed and tests folded
into the existing jitstress-isas-x86 pipeline.
Those OSes currently do not have AVX-512 capable machines in our test lab.
@BruceForstall
Copy link
Contributor Author

@tannergooding @kunalspathak @dotnet/jit-contrib PTAL

@BruceForstall
Copy link
Contributor Author

Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall BruceForstall merged commit 2aebbf7 into dotnet:main Nov 8, 2022
@BruceForstall BruceForstall deleted the AddAvx512Pipeline branch November 8, 2022 02:30
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants