Skip to content

add raw vector support (plus docs, example, tests) #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2020
Merged

add raw vector support (plus docs, example, tests) #36

merged 3 commits into from
Jul 8, 2020

Conversation

knapply
Copy link
Collaborator

@knapply knapply commented Jul 8, 2020 •
edited
Loading

Addresses #35

@knapply knapply requested a review from eddelbuettel July 8, 2020 16:35
eddelbuettel
eddelbuettel approved these changes Jul 8, 2020
View reviewed changes
Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're fast.

Quick addition of a ChangeLog entry?

@knapply
Copy link
Collaborator Author

knapply commented Jul 8, 2020

Just pushed. I added yesterday's as well.

@eddelbuettel
Copy link
Owner

Needed a small cleanup I just added.

@knapply
Copy link
Collaborator Author

knapply commented Jul 8, 2020

Needed a small cleanup I just added.

Thank you!

@knapply knapply merged commit 3cad6b5 into master Jul 8, 2020
@eddelbuettel eddelbuettel mentioned this pull request Jul 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knapply @eddelbuettel