Skip to content

Export deserialization function to both C++ and R (closes #80) #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

eddelbuettel
Copy link
Owner

This PR turns on exporting at the C++ and R level for the source file containing the deserialize_json internal workhorse function. No change at the R level, or how the package works internally, but simply offering other packages to utilize this.

Such cross-package use at the C(++) is currently not all that widely used but very powerful. We do not expect any side-effects based on similar use in another package.

Remains package-local at the R level
@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 99.12% // Head: 99.12% // No change to project coverage 👍

Coverage data is based on head (e5544e9) compared to base (78a2233).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          18       18           
  Lines        1375     1375           
=======================================
  Hits         1363     1363           
  Misses         12       12           
Impacted Files Coverage Δ
src/deserialize.cpp 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eddelbuettel eddelbuettel merged commit d03b327 into master Jan 21, 2023
@eddelbuettel eddelbuettel deleted the feature/export_c_level branch January 21, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant