Skip to content

[Actionable Observability][Metric Threshold Rule] Add histogram support for avg, max, min, sum and percentiles #139770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Aug 30, 2022

Summary

This PR add support for the histogram field type for the avg, max, min, sum, and percentile aggregations for the Metric Threshold Rule. This will enable users to create latency threshold alerts on the APM data specific to transaction names like the example below:

image

@simianhacker simianhacker added release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0 labels Aug 30, 2022
@simianhacker simianhacker requested a review from a team as a code owner August 30, 2022 21:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified locally and everything seems to work as expected
image

@matschaffer matschaffer self-requested a review September 13, 2022 02:34
@matschaffer
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a really good sign that all we had to do was extended the types list. :)

I took a quick look at https://www.elastic.co/guide/en/elasticsearch/reference/current/histogram.html#histogram-uses to see if there were any other aggs, but looks like you've got it covered. LGTM!

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.0MB 1.0MB +72.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit 08e9c63 into elastic:main Sep 22, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2022
…rt to avg, max, min, sum and percentiles (elastic#139770)

(cherry picked from commit 08e9c63)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 22, 2022
@simianhacker simianhacker deleted the histogram-support-for-metric-threshold-rule branch April 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants