Skip to content

[Lens] Add field filter to popover #141582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #140293

by providing a callback for the field filtering which allows a user to filter values from within the field summary popover like in Discover:

Kapture.2022-09-23.at.11.10.53.mp4

@flash1293 flash1293 added release_note:enhancement Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) Feature:Lens backport:skip This commit does not require backporting labels Sep 23, 2022
@flash1293 flash1293 marked this pull request as ready for review September 23, 2022 13:02
@flash1293 flash1293 requested a review from a team as a code owner September 23, 2022 13:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool :) LGTM! I tested it locally and works fine!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.2MB 1.2MB +198.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 0b97c50 into elastic:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Add filter buttons to field popovers
5 participants