[Lens] Edit data view in flyout #142362

flash1293 · 2022-09-30T14:18:23Z

Part of #141806

If the app supports it, "Manage this data view" will open the flyout instead of navigating away:

In this case there is a link below the heading to go to the management page if the user wants to do that.

Discover is currently changing the state handling in this area, that's why it's only implemented in Lens for now.

…nto inline-data-view-menu

…creen-2

elasticmachine · 2022-09-30T16:00:27Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

stratoula · 2022-10-03T10:13:42Z

@flash1293 this works fine. I have 2 questions:

I open the flyout for an existing dataview and I change the pattern. The Save button is unresponsive. Shouldn't it update the current dataview? If not, maybe we should disable the button?

When I create an adhoc dataview and then open the Edit flyout I see only the Save button. I expect that clicking it will save my dataview as permanent but it doesn't. When I refresh the page, the dataview is lost. Maybe this is just an update CTA? Should we change the text from Save to Update maybe in order to not be so confusing? Wdyt?

…creen-2

…ana into ad-hoc-management-screen-2

flash1293 · 2022-10-04T10:57:15Z

Thanks for your review @stratoula !

I open the flyout for an existing dataview and I change the pattern. The Save button is unresponsive. Shouldn't it update the current dataview? If not, maybe we should disable the button?

That was a bug in the data view editor plugin, I fixed it

When I create an adhoc dataview and then open the Edit flyout I see only the Save button. I expect that clicking it will save my dataview as permanent but it doesn't. When I refresh the page, the dataview is lost. Maybe this is just an update CTA

Good point - I changed the button label to "Continue to use without saving". It was meant to keep it as an ad-hoc data view but update it in-place.

flash1293 · 2022-10-04T10:57:50Z

I also pulled in https://github.com/elastic/kibana/pull/142562/files to fix another problem I noticed with not all parts of the UI updating correctly.

…creen-2

stratoula

Thanx @flash1293! This works great now! And thanx for pulling the changes from the other PR too. FYI, I did a latest change there because there were some unit tests failing e84bccb

…creen-2

Dosant

Code lgtm,

noticed some minor things during testing

src/plugins/data_view_editor/public/components/data_view_editor_flyout_content.tsx

Dosant · 2022-10-04T16:00:32Z

src/plugins/data_view_editor/public/components/data_view_editor_flyout_content.tsx

@@ -376,6 +385,17 @@ const IndexPatternEditorFlyoutContentComponent = ({
        <EuiTitle data-test-subj="flyoutTitle">
          <h2>{editData ? editorTitleEditMode : editorTitle}</h2>
        </EuiTitle>
+        {showManagementLink && editData && editData.id && (


I think we should hide it when you edit an ad-hoc data view (now we show it when you edit ad-hoc data view)

Good point, added that

…r_flyout_content.tsx Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

…ana into ad-hoc-management-screen-2

kibana-ci · 2022-10-05T07:07:47Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 76136cd

Failed CI Steps

FTR Configs #31

Test Failures

[job] [logs] FTR Configs #31 / Reporting Functional Tests with forced timeout adds a visual warning in the report output

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`unifiedSearch`	102	104	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataViewEditor`	30.6KB	31.1KB	+505.0B
`lens`	1.3MB	1.3MB	+265.0B
total			+770.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dataViewEditor`	10.3KB	10.4KB	+102.0B
`unifiedSearch`	48.4KB	48.6KB	+173.0B
total			+275.0B

Unknown metric groups

API count

id	before	after	diff
`dataViewEditor`	15	16	+1
`unifiedSearch`	128	131	+3
total			+4

History

💔 Build #78095 failed b16c472
💔 Build #78041 failed 3325160
💚 Build #77983 succeeded 9119bbc
💔 Build #77883 failed 0d55b10
💔 Build #77870 failed ea520f4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* add explore matching index * adjust type * move things around * fix types * fix tests * fix imports * fix limit * do not clean datasource on adding ad hoc data view * manage data view in flyout * fix phrase * make sure all changes are propagated correctly * fix test * Update src/plugins/data_view_editor/public/components/data_view_editor_flyout_content.tsx Co-authored-by: Anton Dosov <dosantappdev@gmail.com> * only show for persisted data views Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

flash1293 and others added 16 commits September 26, 2022 17:39

add explore matching index

b03f9e8

adjust type

b8e0ccd

Merge remote-tracking branch 'upstream/main' into inline-data-view-menu

6eb2721

move things around

3e3ae19

fix types

163f787

fix tests

7cbc5e2

fix imports

81beac7

Merge remote-tracking branch 'upstream/main' into inline-data-view-menu

a04dcb5

Merge remote-tracking branch 'upstream/main' into inline-data-view-menu

1474a10

fix limit

df5341d

Merge branch 'main' into inline-data-view-menu

32f1df8

Merge remote-tracking branch 'upstream/main' into inline-data-view-menu

68fe6d3

do not clean datasource on adding ad hoc data view

94ecf74

Merge branch 'inline-data-view-menu' of github.com:flash1293/kibana i…

f70a10d

…nto inline-data-view-menu

manage data view in flyout

fe55491

Merge remote-tracking branch 'upstream/main' into ad-hoc-management-s…

26352b0

…creen-2

flash1293 added release_note:enhancement Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) Feature:Lens Feature:Unified search Unified search related tasks labels Sep 30, 2022

flash1293 added 2 commits September 30, 2022 17:14

fix phrase

d25879b

Merge remote-tracking branch 'upstream/main' into ad-hoc-management-s…

732a79f

…creen-2

flash1293 marked this pull request as ready for review September 30, 2022 16:00

flash1293 requested review from a team as code owners September 30, 2022 16:00

flash1293 and others added 2 commits September 30, 2022 18:00

Merge branch 'main' into ad-hoc-management-screen-2

596d03f

Merge branch 'main' into ad-hoc-management-screen-2

5d906ab

Merge remote-tracking branch 'upstream/main' into ad-hoc-management-s…

a50561c

…creen-2

flash1293 added 2 commits October 4, 2022 12:55

make sure all changes are propagated correctly

6998f43

Merge branch 'ad-hoc-management-screen-2' of github.com:flash1293/kib…

ea520f4

…ana into ad-hoc-management-screen-2

Merge remote-tracking branch 'upstream/main' into ad-hoc-management-s…

0d55b10

…creen-2

stratoula approved these changes Oct 4, 2022

View reviewed changes

flash1293 added 2 commits October 4, 2022 16:36

fix test

7301a11

Merge remote-tracking branch 'upstream/main' into ad-hoc-management-s…

9119bbc

…creen-2

Dosant approved these changes Oct 4, 2022

View reviewed changes

flash1293 and others added 5 commits October 4, 2022 18:45

Update src/plugins/data_view_editor/public/components/data_view_edito…

2f1d2c7

…r_flyout_content.tsx Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

only show for persisted data views

9241413

Merge branch 'ad-hoc-management-screen-2' of github.com:flash1293/kib…

3325160

…ana into ad-hoc-management-screen-2

Merge branch 'main' into ad-hoc-management-screen-2

b16c472

Merge branch 'main' into ad-hoc-management-screen-2

76136cd

stratoula mentioned this pull request Oct 5, 2022

[Lens] Fixes the performance on setting the current index pattern #142562

Closed

flash1293 merged commit b270921 into elastic:main Oct 5, 2022

kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 5, 2022

KOTungseth mentioned this pull request Oct 6, 2022

Updates Edit data view link copy #142883

Merged

mattkime mentioned this pull request Oct 10, 2022

[data view editor] Form state refactor - create service, replace useEffect with observables #142421

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Lens] Edit data view in flyout #142362

[Lens] Edit data view in flyout #142362

Uh oh!

flash1293 commented Sep 30, 2022

Uh oh!

elasticmachine commented Sep 30, 2022

Uh oh!

stratoula commented Oct 3, 2022

Uh oh!

flash1293 commented Oct 4, 2022

Uh oh!

flash1293 commented Oct 4, 2022

Uh oh!

stratoula left a comment

Uh oh!

Dosant left a comment

Uh oh!

Uh oh!

Dosant Oct 4, 2022

Uh oh!

flash1293 Oct 4, 2022

Uh oh!

kibana-ci commented Oct 5, 2022

API count

Uh oh!

Uh oh!

[Lens] Edit data view in flyout #142362

[Lens] Edit data view in flyout #142362

Uh oh!

Conversation

flash1293 commented Sep 30, 2022

Uh oh!

elasticmachine commented Sep 30, 2022

Uh oh!

stratoula commented Oct 3, 2022

Uh oh!

flash1293 commented Oct 4, 2022

Uh oh!

flash1293 commented Oct 4, 2022

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Dosant Oct 4, 2022

Choose a reason for hiding this comment

Uh oh!

flash1293 Oct 4, 2022

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Oct 5, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

Uh oh!