-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[XY] Fixes the colors and tooltips sync #142957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tooltip work well when hovering over XY and syncing with Lens.
It doesn't work the other way around, but I think it's expected as the issue is about XY, right?
Untitled.mp4
@mbondyra this will also work well if you go to agg based and switch off the detailed tooltip switch. (it works only for the EC tooltip and not the custom one) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Chrome! Works as expected, approved 👌🏼
* [XY] Fixes the colors and tooltips sync * Fix types * Fix jest tests
* [XY] Fixes the colors and tooltips sync * Fix types * Fix jest tests
Summary
Closes #142954
This PR fixes the bug on the XY agg based visualizations that the colors and tooltips were not synced when the switches were on, on the dashboard level.