Skip to content

[APM] Display configuration table above code sample #143178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 17, 2022

Conversation

kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Oct 12, 2022

closes #142205

Additional

  • use default value for service name and environment for all agents
  • for consistency reorder the variables so all agents follow the same order
  • for consistency add environment configuration in php agent code sample
  • rename ServerUrls to ServerUrl for dotnet agent to match the latest changes (both are supported) - documentation
  • todo check java agent. it also has ServerUrls - Rename Delastic.apm.server_urls to Delastic.apm.server_url
    Questions:
  1. What do we want to display in the table if a variable value is empty?
    - now the column it's empy

Before

tokens node.js Django/Flask RoR Rack Rum(Js) Go(highlight in green) Java(no highlight) .Net PHP
service name ❌ commented out
secret token ❌ (service version)
server url
environment

java-agent
image

After

Tutorial

Screen.Recording.2022-10-13.at.11.37.34.mov

Agent

Screen.Recording.2022-10-13.at.11.40.40.mov

@kpatticha
Copy link
Contributor Author

/oblt-deploy

@kpatticha kpatticha force-pushed the 142205-agent-tokens branch from c6c4b2b to b8bf578 Compare October 13, 2022 08:47
@kpatticha
Copy link
Contributor Author

Unfortunately I'm unable to create a custom build due to an incident but I updated the ticket with recent recordings of the changes.

any early feedback from you @chrisdistasio @boriskirov would be really useful.

@kpatticha kpatticha marked this pull request as ready for review October 13, 2022 09:54
@kpatticha kpatticha requested a review from a team as a code owner October 13, 2022 09:54
@kpatticha
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@boriskirov
Copy link
Contributor

Everything looks good to me, great work @kpatticha !

@@ -30,19 +30,46 @@ const apmAgentCommandsMap: Record<string, string> = {
js_script: rumScript,
};

interface Variables {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to have a type defined here, it seems that it's the same for all agents?

@kpatticha kpatticha enabled auto-merge (squash) October 17, 2022 07:26
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1318 1319 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +5.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpatticha kpatticha merged commit 12acbac into elastic:main Oct 17, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Surface APM Agent Tokens on APM Tutorials
6 participants