Skip to content

[ML] Explain Log Rate Spikes: Allow to continue failed stream. #143301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 10, 2022
Merged

[ML] Explain Log Rate Spikes: Allow to continue failed stream. #143301

merged 12 commits into from
Nov 10, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Oct 13, 2022 •
edited
Loading

Summary

Part of #142568.

The analysis can be long running and in cases can time out depending on server/proxy settings. This update allows a user to try to continue the analysis if it failed half way through.

Review Note: I left in some temporary code that triggers an error on the first run so the continue button appears. During local tests, you can remove the code added in e799e08 to toggle between the default behavior and the intentional analysis fail. Please let me know once you're done with local testing so I can revert that commit.

Checklist

@walterra walterra self-assigned this Oct 13, 2022
@walterra walterra added ci:cloud-redeploy Always create a new Cloud deployment and removed ci:build-cloud-image labels Oct 13, 2022
@walterra walterra force-pushed the ml-aiops-continue-stream branch 6 times, most recently from 536c7c1 to ad10784 Compare October 20, 2022 14:00
@walterra walterra force-pushed the ml-aiops-continue-stream branch 5 times, most recently from fafb651 to 845ec8c Compare October 27, 2022 12:41
@walterra walterra added ci:build-cloud-image and removed ci:cloud-redeploy Always create a new Cloud deployment labels Oct 27, 2022
@walterra walterra force-pushed the ml-aiops-continue-stream branch from 845ec8c to e3c9329 Compare October 27, 2022 13:57
@walterra walterra added ci:cloud-redeploy Always create a new Cloud deployment and removed ci:build-cloud-image labels Oct 27, 2022
@walterra walterra force-pushed the ml-aiops-continue-stream branch 6 times, most recently from 9b836a2 to 4bfebd9 Compare November 3, 2022 09:57
@walterra walterra force-pushed the ml-aiops-continue-stream branch 3 times, most recently from 9e8816e to 677ae09 Compare November 8, 2022 16:53
@walterra walterra force-pushed the ml-aiops-continue-stream branch from cbb1acf to e799e08 Compare November 9, 2022 09:19
@walterra walterra added release_note:enhancement :ml Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.6.0 and removed ci:cloud-redeploy Always create a new Cloud deployment labels Nov 9, 2022
@walterra walterra marked this pull request as ready for review November 9, 2022 09:28
@walterra walterra requested a review from a team as a code owner November 9, 2022 09:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson reviewed Nov 9, 2022
View reviewed changes
...plugins/aiops/public/components/explain_log_rate_spikes/explain_log_rate_spikes_analysis.tsx Outdated
{overrides !== undefined ? (
<p>
<EuiButton size="s" onClick={() => startHandler(true)}>
Try to continue analysis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be internationalized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added i18n in 0011cf1.

peteharverson
peteharverson approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with your temporary code, and LGTM.

Just left one minor comment. Don't forget to remove the testing code :)

alvarezmelissa87
alvarezmelissa87 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 732.4KB 733.3KB +890.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
aiops 27 29 +2
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +21

Total ESLint disabled count

id before after diff
aiops 27 29 +2
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +22

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 1d511a4 into elastic:main Nov 10, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 10, 2022
@walterra walterra deleted the ml-aiops-continue-stream branch November 10, 2022 08:03
@walterra walterra mentioned this pull request Nov 10, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:enhancement v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibana-ci @alvarezmelissa87 @peteharverson @kibanamachine